Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>,
        Alex Williamson <alex.williamson@redhat.com>
CC:     Zhenyu Wang <zhenyuw@linux.intel.com>,
        "Wang, Zhi A" <zhi.a.wang@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Eric Farman <farman@linux.ibm.com>,
        Matthew Rosato <mjrosato@linux.ibm.com>,
        Halil Pasic <pasic@linux.ibm.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        "Peter Oberparleiter" <oberpar@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Tony Krowiak <akrowiak@linux.ibm.com>,
        Jason Herne <jjherne@linux.ibm.com>,
        Harald Freudenberger <freude@linux.ibm.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        "Cornelia Huck" <cohuck@redhat.com>,
        Longfang Liu <liulongfang@huawei.com>,
        "Shameer Kolothum" <shameerali.kolothum.thodi@huawei.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Eric Auger <eric.auger@redhat.com>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        Abhishek Sahu <abhsahu@nvidia.com>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [PATCH 15/15] vfio: Add struct device to vfio_device
Thread-Topic: [PATCH 15/15] vfio: Add struct device to vfio_device
Thread-Index: AQHYufqqXjqbWwGvv0ujITvL457lEa3ICPIAgAAacoCAAGT9wA==
Date:   Wed, 31 Aug 2022 06:10:51 +0000
Message-ID: <BN9PR11MB5276BF3B8D65B66DB292CAE58C789@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220827171037.30297-1-kevin.tian@intel.com>
 <20220827171037.30297-16-kevin.tian@intel.com>
 <20220830161838.4aa47045.alex.williamson@redhat.com>
 <Yw6i7btDKcUDPADP@ziepe.ca>
In-Reply-To: <Yw6i7btDKcUDPADP@ziepe.ca>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?WXAVl2Y9AA38oxSE3yrBgHGjA1hMPl0yHi6Jn+l7IX7wpRR70jE5Izlypvc5?=
 =?us-ascii?Q?ucuFy9RfWBKwx9aQ1nZgHLyE7H+8iqtuoTNs+N4DsNzU/idcA0I6JUfdqdiY?=
 =?us-ascii?Q?GNlv4iwVBnAs4EZzlgy9qOT6fGeysS9BwU/7yE86qM2KTVvLY6YsM4VQjLhv?=
 =?us-ascii?Q?UN5aXiqe1Awfnwh1meoaDMVt81HFUEvELiIoqoT5LLhIUGDA+fz9fOM6Lx5j?=
 =?us-ascii?Q?en7YkHG/dx4SU1posDmKSisfQdlZ7Y0pT1wmRXtpDQ27560yxvis1bJUl+4s?=
 =?us-ascii?Q?mi1SuwZ5Mh82GzRdqnYhMvt45YGTrgtmxumiGR0MwOYEBfFHRaP4OGD/3zbe?=
 =?us-ascii?Q?UMZ5kpMEbmIeo9Ub4WmOH+9dgOOwwiD5uqMtNG5sBX032rsJfLccBZEuQL2c?=
 =?us-ascii?Q?8jj+9HMt3G52iWl9BX5XDLoo7/Covt7SUNHjrXyQAisG+YDnO6XSq/0zu/gv?=
 =?us-ascii?Q?5iyKef1PyFQvcc9LbDFsg98DA/Y37eX9l6pR6SiSsuOY/z3n5EJZhUCud3pa?=
 =?us-ascii?Q?M+WrLjGGGjFx+jIAeDGbmdQroPg4Ag1HK8mfSuSfiHneg3dhi9q48aYk+VX7?=
 =?us-ascii?Q?e9JOVQ1HtJmNytQV6m+GitTSKdJSUiJNFSowxAHc5bEzTh79wkE9BSUNAJpr?=
 =?us-ascii?Q?gq9oCe8NCywIrktjsg6xnQcJeXa3LZzRgUvfrICH4bu+xPtIpCWqiRcmZjCQ?=
 =?us-ascii?Q?yp2LeTniraEC0auqcvAG274ipyeZc+NY4gw69M2x1WF2ghCp7SS0LVoAHIDD?=
 =?us-ascii?Q?f/X8dBrktxnSnDEd+NRNgEL3b5TM8JEMt05zmvh7yMXXamILNP2xXuDApuj2?=
 =?us-ascii?Q?g1zGTvWfY1omTLIWAkwKXKqq05m3jVHvjstCNFJEjGlfDiPZ8zhhTzPLsu0k?=
 =?us-ascii?Q?GRSrjEBWcXShhI4Ww8l6J4Ag2JR0SzxyIUjq1QJ7/Itd8ESrBFa4ub0er04E?=
 =?us-ascii?Q?a5Nf6wCWmTbJmLpHPmoMBcg6ThIiKborpZLZn+Ms/UivofbfSlxIxZ93kOT/?=
 =?us-ascii?Q?KS+OiMakgqw+04UCzL2Y5gysOzv1295diKH7/ZnL20zEEc4M36Kdql7JhpG4?=
 =?us-ascii?Q?h9Y45K1zoY3um6ilcuzaiiIRH9HNCMClrLJB1OeNfTqaOKeENKWEH4Ftv9/U?=
 =?us-ascii?Q?+dlwyAztY+hQr5O25dBXPTcjdTdXj69AI1POkXa4JrksZ1fEVt4KjexBLe+h?=
 =?us-ascii?Q?KTKAtpYMlKY9DNTjjzeD/59EdmngzGmWNwmdbUg9cQxB79dLxLqmPjF1QKZO?=
 =?us-ascii?Q?HiA2/wp/BK9lbOekmUPWMExmvd3eh7k1Ms7ZEu0aKDz9eF0ksGxuIy2RBZlW?=
 =?us-ascii?Q?TlOUwsNCrPHzuCAObzs3B18zp39/BcKuniHPvuks9JCrjo+vb4X5PAHTdICM?=
 =?us-ascii?Q?Tr5/bin4jAQVEn+DHO8CaxTOW2TGuShUq90bgwCZ7+3kjjSkppz1cIYVm2BG?=
 =?us-ascii?Q?agk/wIU7qJkzFaLDDSwoiictQNK2MlvaVSVg8hOserIH8AfNM7HgPKAZL5sR?=
 =?us-ascii?Q?Tb2gFLf94cOK1d/tb/19NSpbxEvc5SiMF5TDtE9KamsjHdHNouCjPMSje0Oj?=
 =?us-ascii?Q?maWTtXf+PumyoDa+UliQvoN1KHKJ5xQHVEwziHM8?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 296258f3-5005-490d-7e3e-08da8b178e1f
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2022 06:10:51.1127
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: u8BURVAaephkP4WRMyzRlWqcREvTqjTiXd/Xb4WRPWB4GGNd0ntaJkT0FYSSA2R6QmnDPA7iQpXpVWbMKFAz/g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3725
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Wednesday, August 31, 2022 7:53 AM
>=20
> On Tue, Aug 30, 2022 at 04:18:38PM -0600, Alex Williamson wrote:
> > On Sun, 28 Aug 2022 01:10:37 +0800
> > Kevin Tian <kevin.tian@intel.com> wrote:
> >
> > > From: Yi Liu <yi.l.liu@intel.com>
> > >
> > > and replace kref. With it a 'vfio-dev/vfioX' node is created under th=
e
> > > sysfs path of the parent, indicating the device is bound to a vfio
> > > driver, e.g.:
> > >
> > > /sys/devices/pci0000\:6f/0000\:6f\:01.0/vfio-dev/vfio0
> > >
> > > It is also a preparatory step toward adding cdev for supporting futur=
e
> > > device-oriented uAPI.
> >
> > Shall we start Documentation/ABI/testing/vfio-dev now?  Thanks.
>=20
> I always thought that was something to use when adding new custom
> sysfs attributes?
>=20
> Here we are just creating a standard struct device with its standard
> sysfs?
>=20

There is nothing special for vfio-dev/vfioX. But from pci device p.o.v
this does introduce a custom node in the directory, which is probably
what Alex referred to?

Anyway if required following can be introduced:

diff --git a/Documentation/ABI/testing/sysfs-devices-vfio-dev b/Documentati=
on/ABI/testing/sysfs-devices-vfio-dev
new file mode 100644
index 000000000000..dfe8baaf1ccb
--- /dev/null
+++ b/Documentation/ABI/testing/sysfs-devices-vfio-dev
@@ -0,0 +1,8 @@
+What:		 /sys/.../<device>/vfio-dev/vfioX/
+Date:		 September 2022
+Contact:	 Yi Liu <yi.l.liu@intel.com>
+Description:
+		 This directory is created when the device is bound to a
+		 vfio driver. The layout under this directory matches what
+		 exists for a standard 'struct device'. 'X' is a random
+		 number marking this device in vfio.

At the start I thought it might make more sense to add it into an
existing vfio ABI file. But looks it doesn't exist.

Curious why nobody asked for ABI doc for /dev/vfio/vfio, /sys/class/vfio, e=
tc...

Thanks
Kevin