Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>
CC:     Zhenyu Wang <zhenyuw@linux.intel.com>,
        "Wang, Zhi A" <zhi.a.wang@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Eric Farman <farman@linux.ibm.com>,
        Matthew Rosato <mjrosato@linux.ibm.com>,
        Halil Pasic <pasic@linux.ibm.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        "Peter Oberparleiter" <oberpar@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Tony Krowiak <akrowiak@linux.ibm.com>,
        Jason Herne <jjherne@linux.ibm.com>,
        Harald Freudenberger <freude@linux.ibm.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        "Alex Williamson" <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Longfang Liu <liulongfang@huawei.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Eric Auger <eric.auger@redhat.com>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        Abhishek Sahu <abhsahu@nvidia.com>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [PATCH 10/15] vfio/fsl-mc: Use the new device life cycle helpers
Thread-Topic: [PATCH 10/15] vfio/fsl-mc: Use the new device life cycle helpers
Thread-Index: AQHYufqRg4aE4TfjN0eFCB8lkLOEkK3IK44AgABhWIA=
Date:   Wed, 31 Aug 2022 06:14:11 +0000
Message-ID: <BN9PR11MB5276D146255D42CC00E1AD048C789@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220827171037.30297-1-kevin.tian@intel.com>
 <20220827171037.30297-11-kevin.tian@intel.com> <Yw6pxrS1zb5JKt8q@ziepe.ca>
In-Reply-To: <Yw6pxrS1zb5JKt8q@ziepe.ca>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?P9lBK4oM48CfULDBI9CMX5f+eZZHcVArGf2XAKV22mtv6PyV3MWAAjUNMl03?=
 =?us-ascii?Q?U9yScuy0ttHfyfNqwBabNqeBfKB9OlklsSw/cVtvOaVac5hJ1vuSiUyGC8iX?=
 =?us-ascii?Q?A9geSjKHtiSPNFWEeHLtB2Km9jEYowsg2W+lc4MvkoL9TiuYP553BSmWo7xt?=
 =?us-ascii?Q?8222Bhor/xF0Xg2T0aL6whCKRBSl32cVtTUFAopEyR7BailJJroejrcauqzd?=
 =?us-ascii?Q?4PPP/98nFBZUAoaAw3Kl345hDeDMbtFelupdHB5eGHrKFlgEC0PJV0KfIDaY?=
 =?us-ascii?Q?0xVvyE5pGkNrJ07mF+LmUif0sKCIrxx38TPs+Fpz7L58Eco9C+6qBeRC5+pS?=
 =?us-ascii?Q?3Y4cwUcXSPvKngfFOoat2FvD6DhYH4iPMGAjOGkRc4TrLnhSPOuN3TdSyvkt?=
 =?us-ascii?Q?l7FpzAEcxEtA2WN0RxvDJqTNqG14DcQbKZHTttAbSmOAQf45RoNTYt7J1Gpy?=
 =?us-ascii?Q?II5c16mvRwf6rjQnu1mKLm3UoRTNoqW5EciYyy3J880uVM5589jhfEEwsQq5?=
 =?us-ascii?Q?dRJ1nB24JnDDwdoWAG64TYTKriw8Y2kZ7zv2oh8ybYc1wTZre5R/Gz/mf13r?=
 =?us-ascii?Q?vmu6g3B6vNZ9nTUe3mEe1lCgAOEn27Q20kZMV0AwZAfKsOUAiHOZMz8Ek2FO?=
 =?us-ascii?Q?Y3llBadKZN9FstFqL31Ar22f5imU21BSGkRWl+GZBqbpJyE/JqEKwncw2WrH?=
 =?us-ascii?Q?4POKy5QJE3Ll74znXVPhR8/ddD7caseFCD/xuMe2e88b0/Uayca36i0MF+R2?=
 =?us-ascii?Q?QtqCMQOiBz3TI+9N+6rHnZJZhHsJM43kGOtKCueR34la7j6kLhUf59d8hLWU?=
 =?us-ascii?Q?ZUcdsClSnV1/uGjtI35wsc/p2sI9bCG4ON01Bgn1LhyHM5PvazPxeR5ZEYWw?=
 =?us-ascii?Q?weOKGWmnT/V08b8dd/yPTr6wC7PVQH7a23r2O+vPY7rCtPjwnmqi6Iu/Ja5Q?=
 =?us-ascii?Q?TBHyPveuHlooRxlNHeII9lGPfbvp0Zfgf2ADImG5sN9Lupgmhv+NsyppacjP?=
 =?us-ascii?Q?BvpqX9NRFuo8KChZppXqCqGCUsDL4HxlIoQvEK8ikk0UDyDubucL683oB/5q?=
 =?us-ascii?Q?JPvYEbmCgzNzqI5lQGmpDLY99xgFBeIsx8hFjdMwGwHs5VJtsKtK8gfOS+nz?=
 =?us-ascii?Q?TfXKXnY9M5vHPFGR0TzfELIJgghKprml1AeOrLkn59N7t9qowZgSBRER9GWB?=
 =?us-ascii?Q?L8YtmTVqnUJbuCQM3WARAYMmdzfJY5ywnuFp6FCDM5vbtG/KHOPjsf7Afc6b?=
 =?us-ascii?Q?WrHB1DhPEDd63/eN1sZK7/9biqjIzLaDA0MPh8NPw6MDbjOkAzqQfkmNNqU1?=
 =?us-ascii?Q?DM27afz9pzfOKqTSJRjPHsS2gBAWPFBA/aPa3SKepW09+yr7153px8DrqivF?=
 =?us-ascii?Q?9bp7EUSEQDBtkXvxMKID2rn+dXH/Y9iF0xvxwSO5VO7w8YCiR4aCqpFYaChZ?=
 =?us-ascii?Q?xCBgUNBk+Zj12yRuyUjDXngDtfYxNri/aSO6X0Ld3YQ6HuEGF8wPN2k3IXNR?=
 =?us-ascii?Q?gyx3+mSuNazKodtaXhj347SlcdXpFDqma1oFeAMONrwFFjg6N6ZSBM8uhjwJ?=
 =?us-ascii?Q?bwkKTkjq1KWq0B/DtfkhHaPqzf9eCOK2BtdpDyMB?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e1ccf5e1-daab-4b2b-f2cd-08da8b1805dc
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2022 06:14:11.9876
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: OC+o4cp8fuMu1Vas7qNGch+NAsS5vA7dYdhu1BPJG+JomioOxdr4pdDqoDr7yGpzmFIeD3iu8rfWQfi5Wi4oWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2233
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Wednesday, August 31, 2022 8:23 AM
>=20
> On Sun, Aug 28, 2022 at 01:10:32AM +0800, Kevin Tian wrote:
> > From: Yi Liu <yi.l.liu@intel.com>
> >
> > Export symbol of vfio_release_device_set() so fsl-mc @init can handle
> > the error path cleanly instead of assuming certain vfio core API can
> > help release device_set afterwards.
>=20
> I think you should leave it as is, the "device_set" cleanup is just
> something handled completely internally to vfio
>=20
> If ops->init fails then we expect the core code to clean the
> device_set, and it does because it calls vfio_init_device() already.
>=20
> Having a single weirdly placed release in the driver is pretty
> confusing, IMHO.
>=20

I considered both. In the end I chose the current way being it's
clearer if just looking at @init. But yes having a release called
by driver is also confusing. Probably having a pair of assign/deassign
helpers is more clearer, but I'll not continue this path for unnecessary
complexity.

So I'll leave it as is and add a comment to clarify it.