Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Tian, Kevin" <kevin.tian@intel.com>
To:     Jason Gunthorpe <jgg@ziepe.ca>
CC:     Zhenyu Wang <zhenyuw@linux.intel.com>,
        "Wang, Zhi A" <zhi.a.wang@intel.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        "Joonas Lahtinen" <joonas.lahtinen@linux.intel.com>,
        "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Eric Farman <farman@linux.ibm.com>,
        Matthew Rosato <mjrosato@linux.ibm.com>,
        Halil Pasic <pasic@linux.ibm.com>,
        Vineeth Vijayan <vneethv@linux.ibm.com>,
        "Peter Oberparleiter" <oberpar@linux.ibm.com>,
        Heiko Carstens <hca@linux.ibm.com>,
        Vasily Gorbik <gor@linux.ibm.com>,
        Alexander Gordeev <agordeev@linux.ibm.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Sven Schnelle <svens@linux.ibm.com>,
        Tony Krowiak <akrowiak@linux.ibm.com>,
        Jason Herne <jjherne@linux.ibm.com>,
        Harald Freudenberger <freude@linux.ibm.com>,
        Diana Craciun <diana.craciun@oss.nxp.com>,
        "Alex Williamson" <alex.williamson@redhat.com>,
        Cornelia Huck <cohuck@redhat.com>,
        Longfang Liu <liulongfang@huawei.com>,
        Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Eric Auger <eric.auger@redhat.com>,
        Kirti Wankhede <kwankhede@nvidia.com>,
        Leon Romanovsky <leon@kernel.org>,
        Abhishek Sahu <abhsahu@nvidia.com>,
        "intel-gvt-dev@lists.freedesktop.org" 
        <intel-gvt-dev@lists.freedesktop.org>,
        "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-s390@vger.kernel.org" <linux-s390@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "Liu, Yi L" <yi.l.liu@intel.com>
Subject: RE: [PATCH 15/15] vfio: Add struct device to vfio_device
Thread-Topic: [PATCH 15/15] vfio: Add struct device to vfio_device
Thread-Index: AQHYufqqXjqbWwGvv0ujITvL457lEa3ILkoAgABfkKA=
Date:   Wed, 31 Aug 2022 06:14:37 +0000
Message-ID: <BN9PR11MB52769058CD32020313A76C368C789@BN9PR11MB5276.namprd11.prod.outlook.com>
References: <20220827171037.30297-1-kevin.tian@intel.com>
 <20220827171037.30297-16-kevin.tian@intel.com> <Yw6sEghuAm6OAXWE@ziepe.ca>
In-Reply-To: <Yw6sEghuAm6OAXWE@ziepe.ca>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?/Kg15rFGBmtf32vVkvU2fQvPRMQ7Db7mhzISSe26wPPPu/Lt+z7n3EcoQfU4?=
 =?us-ascii?Q?foJvwvpczD9CgEIqiIgRZ/1igz2lgL/iOZTw/xdZeTxSB/YsX2eVCgxtVT5P?=
 =?us-ascii?Q?yAWa/sy0tGkl7JwW/S5Tkk9KwEYmKqjC1iQjvC6cOAA60k/Sx37DPE1fBeX2?=
 =?us-ascii?Q?OTG4LhV2cmOHMjsSv6RYSwu6ccZZXZ4EtHRhdHkNI4npxYDraceMhYQz8fCT?=
 =?us-ascii?Q?ztcqggRg/3MDkHbSP1+8djSvhs+wYzHJqnGZcHWG9UBoRikvGXoAO80Yo5uZ?=
 =?us-ascii?Q?bBTgSOrcX1Az3xyP9fph1EeW8E4vOmNMrMUcHoqEAi0H69UJx3hTnFU7Ob/E?=
 =?us-ascii?Q?GI4OBPOLznLWCoZUil+ordw+kdjc4Rb+KwW9/w9NME/KgXvy6nkNS+0RlXIH?=
 =?us-ascii?Q?9EBo86T5K+M+R6QzS9Ch0I1+bc7rjJiPS+uHOXdB+ePyqdhZ84r82RVx2zwY?=
 =?us-ascii?Q?DFjA55hj4Vqoo8DY42kwR0copqv+Hhs6Uh79qgfEWMDHTo0p32QUnGDWrr/r?=
 =?us-ascii?Q?VJaPPfqyiO6V/830eswcxYdaPowNPBY8YJLlFD6bfraEvegzpGr6OkDTsCp3?=
 =?us-ascii?Q?sdogWIL9/vhG5Lm+eo4dvjKcZivvQp5z7GIAZv3cKWkpUeYpXcd6JZvwucAA?=
 =?us-ascii?Q?UbPaLKm7flcdA6OwztindNTKtmJ7h5W+jOHFcHin/r7GF4gebj3ksWm0mu1r?=
 =?us-ascii?Q?87TLAnhkWGPv1Xv24tEGF1wzU5ZkY9niIl3LFU+0dQF797QMZhktjbnxKMtZ?=
 =?us-ascii?Q?JxBBsSa7P655nsrgbKy+BRF1zNj8NxVYTOFyw2kA9BkAJC6LQtOl/JCE6yVw?=
 =?us-ascii?Q?9Nrf7xvqNacWMQilWuYjUpyrVECliZZXyC4cI5M9T6XzqTribYXfet7R/fV0?=
 =?us-ascii?Q?bsW+mV9hqVIIKEyzbfRmo8RdTGt/npGjlLgA16brFBssFcbHzH8J8rcoOecz?=
 =?us-ascii?Q?Rl7hrdIsDTG2N7Br9GUVE4BEi1mbpzuoj/SxLCLvtKwaMzBQONg5H2PAX9iB?=
 =?us-ascii?Q?rKlUC1FXosmRhebnSsR8uKae+W8JzgdhFXrm0FrXFcZfe/uQ3X4/GXKwzCEk?=
 =?us-ascii?Q?x79yI1uD0BMkm+gF7qM71rl8rAESRhKdnYCYesXcYi1EER/3d5s75egwTxLi?=
 =?us-ascii?Q?eOPrnqM1eBLodhgIDKwkozBhHw4BTUKrp1K7iGpOWr5u0eCxJkz5hdPPcELN?=
 =?us-ascii?Q?WtW8SmfR91Cosag76WihA+UaEmfZbFEuoVlweXSktabnt6qSuh0X3ms9Hn62?=
 =?us-ascii?Q?Wm9q5MuEGJNXv9M3AyZklSQfgmHUiXsERb8yhDhT/nEyfe0zVxXAgbQ3s+RR?=
 =?us-ascii?Q?Wyhz5ZGdrFv/jYw5aZYdlSp9nK7F7vzgYGNmNLz2Gcw6Vf131AXG8sjO9NMT?=
 =?us-ascii?Q?qYt/CcEkU2wip/PtK1JUmfg2P3W9aauYT4KD6qWBWb7YiAReDsLH1/SVHatD?=
 =?us-ascii?Q?PIYTSD/WgGLm83ZTS65/jH2/pAzm80lqZB3gyEIt1aa9xJJn5gEIZpcdK8ys?=
 =?us-ascii?Q?Dc2swDCFqZYrXqO8NuzVHDj6IaWGd0bU1fXgXwwlgkilDYjnyqs7pkuIhUYm?=
 =?us-ascii?Q?o0cxX5APlK9IuMRi+tbexIpmZCGOZ4eM010BlxJH?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5276.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3ce41f1d-fed5-4cc7-31ff-08da8b181522
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2022 06:14:37.5916
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FjPs3sLf2u7iPXeQd6zC6ZDtVZTgCorW5bZnUMTaXtflq2/rRwycJbbLVqZnB89Hudc0XvQPCvQYuLdmLY0ceg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2233
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> From: Jason Gunthorpe <jgg@ziepe.ca>
> Sent: Wednesday, August 31, 2022 8:32 AM
>=20
> On Sun, Aug 28, 2022 at 01:10:37AM +0800, Kevin Tian wrote:
> > From: Yi Liu <yi.l.liu@intel.com>
> >
> > and replace kref. With it a 'vfio-dev/vfioX' node is created under the
> > sysfs path of the parent, indicating the device is bound to a vfio
> > driver, e.g.:
> >
> > /sys/devices/pci0000\:6f/0000\:6f\:01.0/vfio-dev/vfio0
> >
> > It is also a preparatory step toward adding cdev for supporting future
> > device-oriented uAPI.
> >
> > Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> > Signed-off-by: Yi Liu <yi.l.liu@intel.com>
> > Signed-off-by: Kevin Tian <kevin.tian@intel.com>
> > ---
> >  drivers/vfio/vfio_main.c | 70 +++++++++++++++++++++++++++++++++-------
> >  include/linux/vfio.h     |  6 ++--
> >  2 files changed, 61 insertions(+), 15 deletions(-)
> >
> > diff --git a/drivers/vfio/vfio_main.c b/drivers/vfio/vfio_main.c
> > index 0c5d120aeced..9ad0cbb83f1c 100644
> > --- a/drivers/vfio/vfio_main.c
> > +++ b/drivers/vfio/vfio_main.c
> > @@ -46,6 +46,8 @@ static struct vfio {
> >  	struct mutex			group_lock; /* locks group_list */
> >  	struct ida			group_ida;
> >  	dev_t				group_devt;
> > +	struct class			*device_class;
> > +	struct ida			device_ida;
> >  } vfio;
> >
> >  struct vfio_iommu_driver {
> > @@ -524,11 +526,19 @@ EXPORT_SYMBOL_GPL(_vfio_alloc_device);
> >   *
> >   * Only vfio-ccw driver should call this interface.
> >   */
> > +static void vfio_device_release(struct device *dev);
>=20
> Since you added this new function in patch 1, it would be nice to
> place it in a way that avoids this forward reference in this patch
>=20
> >  	ret =3D alloc_chrdev_region(&vfio.group_devt, 0, MINORMASK + 1,
> "vfio");
>=20
> I think we should change this "vfio" string at this point, it is
> really the group fd, so "vfio_group" ?
>=20
> It only shows in procfs.
>=20

All make sense and fixed.