Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <33d2da82-1e8a-c5dd-7f75-2454714357e6@foss.st.com>
Date:   Wed, 31 Aug 2022 09:22:08 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v1 1/2] spi: stm32-qspi: Replace of_gpio_named_count() by
 gpiod_count()
Content-Language: en-US
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mark Brown <broonie@kernel.org>, <linux-spi@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>
CC:     Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>
References: <20220830182821.47919-1-andriy.shevchenko@linux.intel.com>
From:   Patrice CHOTARD <patrice.chotard@foss.st.com>
In-Reply-To: <20220830182821.47919-1-andriy.shevchenko@linux.intel.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Andy

On 8/30/22 20:28, Andy Shevchenko wrote:
> As a preparation to unexport of_gpio_named_count(), convert the
> driver to use gpiod_count() instead.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/spi/spi-stm32-qspi.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-stm32-qspi.c b/drivers/spi/spi-stm32-qspi.c
> index 227f450aa5f0..5858f5f9c758 100644
> --- a/drivers/spi/spi-stm32-qspi.c
> +++ b/drivers/spi/spi-stm32-qspi.c
> @@ -656,7 +656,7 @@ static int stm32_qspi_setup(struct spi_device *spi)
>  	mode = spi->mode & (SPI_TX_OCTAL | SPI_RX_OCTAL);
>  	if ((mode == SPI_TX_OCTAL || mode == SPI_RX_OCTAL) ||
>  	    ((mode == (SPI_TX_OCTAL | SPI_RX_OCTAL)) &&
> -	    of_gpio_named_count(qspi->dev->of_node, "cs-gpios") == -ENOENT)) {
> +	    gpiod_count(qspi->dev, "cs") == -ENOENT)) {
>  		dev_err(qspi->dev, "spi-rx-bus-width\\/spi-tx-bus-width\\/cs-gpios\n");
>  		dev_err(qspi->dev, "configuration not supported\n");
>  
> @@ -681,7 +681,7 @@ static int stm32_qspi_setup(struct spi_device *spi)
>  	 * are both set in spi->mode and "cs-gpios" properties is found in DT
>  	 */
>  	if (((spi->mode & (SPI_TX_OCTAL | SPI_RX_OCTAL)) == (SPI_TX_OCTAL | SPI_RX_OCTAL)) &&
> -	    of_gpio_named_count(qspi->dev->of_node, "cs-gpios")) {
> +	    gpiod_count(qspi->dev, "cs")) {
>  		qspi->cr_reg |= CR_DFM;
>  		dev_dbg(qspi->dev, "Dual flash mode enable");
>  	}

Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>

Thanks
Patrice