Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Wed, 31 Aug 2022 09:30:26 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Konstantin Ryabitsev <konstantin@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/41] drm/tests: Order Kunit tests in Makefile
Message-ID: <20220831073026.rjlqkznm6qf2yri5@houat>
References: <20220728-rpi-analog-tv-properties-v2-0-459522d653a7@cerno.tech>
 <20220728-rpi-analog-tv-properties-v2-1-459522d653a7@cerno.tech>
 <f6289e5d-98e3-1a0d-f514-136e2b7978c1@tronnes.org>
 <20220829190242.tk2hinttzzmzhnaj@meerkat.local>
 <20220830083027.4iyi2s5r5bto4h2e@houat>
 <20220830122217.h52zswusnlb3iggq@meerkat.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220830122217.h52zswusnlb3iggq@meerkat.local>
Precedence: bulk

Hi,

On Tue, Aug 30, 2022 at 08:22:17AM -0400, Konstantin Ryabitsev wrote:
> (Dropping most cc's, who probably don't care about this thread.)
>=20
> On Tue, Aug 30, 2022 at 10:30:27AM +0200, Maxime Ripard wrote:
> > > I noticed this, too, and I think the reason is because these patches =
were
> > > generated with "b4 send -o", but actually sent using git-send-email. =
It's not
> > > a use-case I've considered (or tested) and the breakage is because wh=
en b4
> > > generates patches with "-o", they are written with CRLF line endings,=
 which is
> > > not something git-send-email expects.
> >=20
> > You're right
>=20
> OK, the latest master should allow you to do that without causing CRLF er=
rors
> like this series.

Thanks

> > For some reason, b4 send doesn't work for my setup and I haven't had the
> > time to look into why and let you know.
>=20
> Yeah, I see what the cause of it is:
>=20
> > Connecting to /home/max/.local/bin/msmtpq:0
> > Failed to configure the smtp connection:
> > [Errno -2] Name or service not known
>=20
> You have sendemail.smtpserver set to a path, which is supported by
> git-sendemail, but not by b4 (yet). I'll see if I can put that in today.

I saw that you fixed it in master, I'll give it a try, thanks!

Another thing I noticed when using b4 send is that I'm not sure how to
increment the version number of a series. With b4 send --dry-run it
wasn't happening automatically, and I couldn't find anything related in
the options (except for --force-revision but that wasn't permanent I
think?)

I ended up amending the commit json by hand to set the proper revision
number, but I'm almost sure it isn't the right way :)

Maxime