Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp210691rwe; Wed, 31 Aug 2022 01:06:22 -0700 (PDT) X-Google-Smtp-Source: AA6agR7GNtc+arJfZTVbOtAJ8E8lAHiOplydWn5F2HYLIfuvYjMLwjTJENylc4U3Cv0egkgVMkfY X-Received: by 2002:a63:88c8:0:b0:42b:59d4:ea81 with SMTP id l191-20020a6388c8000000b0042b59d4ea81mr20147560pgd.344.1661933182144; Wed, 31 Aug 2022 01:06:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661933182; cv=none; d=google.com; s=arc-20160816; b=HDoat4kvjI2yzYbGaZ9WGr0iDCgnngltPN7hBlNI/vCb5vuZpymwKRsRtepxTq8K8Y 3eZ64AdGzSmX5vbR1Te9e9wi3Ve8Q8BDhpopujZEJ+8uESFW17So49SdlzWu6MZqA5V4 5c6pQMgAdwrjUt/Y8hGAMsiOSHPBQBdKNAgYW4jQ9/fJXyZBQOkk/cWJnvYk6BdTcGv9 aiqtYYYdk5RcMDs2UElzD1shpeV64c5DtzYRPLF623JizFcpCHpvDqNJFsDLrEh8LCVt 2F2Taxjds5TodyKxbm9bk8Fwg8LHRShP6RchrhaSll7cZyadYsPrCAAb2LjYYRnqUMHu A2zQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=iGO5Ml64lx4Ghg7S5GW+N9lDHzlfPsq+e8iHlkdfcpc=; b=AO4qGJ1EJcmAWO+NhVwsLFuuz1nE7qttDOGAZpxzhShITwHj1BvhSY7wyC8ekqEpdh nPXTTf2JG2ZbDkP9YLmQKAP43cberc6wjAXA29orZU/F2rKz4S6ZCUtY/Z6Cwem2IVN5 lCDWQfMGFzgcvqREsqo0WJle7IdiKKBGAysK2dHJXBhCucVkTXDupllq+AF9oOKuWAYT zKdvg1ymjPN7VW50OFDvcCDv+jviNAl7QDtL+VZi7mW8Qm2Pk+UYaCkU7NXVpcD0pC0f 6Zj7w9m+2emNssdmK5tajKyKoMNWXaqAgjnZBxDGW+U/v+B5Irvr1NHUZij1fbKM8sd8 6sVA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ls6-20020a17090b350600b001fbbef201e1si1286264pjb.162.2022.08.31.01.06.11; Wed, 31 Aug 2022 01:06:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230347AbiHaHlh (ORCPT + 99 others); Wed, 31 Aug 2022 03:41:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44328 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230208AbiHaHlO (ORCPT ); Wed, 31 Aug 2022 03:41:14 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id D4A91726AC; Wed, 31 Aug 2022 00:40:52 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C842DED1; Wed, 31 Aug 2022 00:40:57 -0700 (PDT) Received: from entos-ampere-02.shanghai.arm.com (entos-ampere-02.shanghai.arm.com [10.169.212.212]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 8D9DE3F766; Wed, 31 Aug 2022 00:41:13 -0700 (PDT) From: Jia He To: Len Brown , James Morse , Tony Luck , Borislav Petkov , Mauro Carvalho Chehab , Robert Richter , Robert Moore , Qiuxu Zhuo , Yazen Ghannam , Jan Luebbe , Khuong Dinh , Kani Toshi Cc: Ard Biesheuvel , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, devel@acpica.org, "Rafael J . Wysocki" , Shuai Xue , Jarkko Sakkinen , linux-efi@vger.kernel.org, nd@arm.com, Jia He Subject: [PATCH v4 0/8] Make ghes_edac a proper module Date: Wed, 31 Aug 2022 07:40:19 +0000 Message-Id: <20220831074027.13849-1-justin.he@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit dc4e8c07e9e2 ("ACPI: APEI: explicit init of HEST and GHES in apci_init()") introduced a bug that ghes_edac_register() would be invoked before edac_init(). Because at that time, the bus "edac" hasn't been even registered, this created sysfs /devices/mc0 instead of /sys/devices/system/edac/mc/mc0 on an Ampere eMag server. The proper solution is to make ghes_edac a proper module. Changelog: v4: - move the kernel boot option to ghes module parameter - collapse th ghes_present and ghes_edac_preferred into one patch v3: https://lore.kernel.org/lkml/20220822154048.188253-1-justin.he@arm.com/ - refine the commit logs - introduce ghes preferred and present flag (by Toshi) - move force_load to setup parameter - add the ghes_edac_preferred() check for x86/Arm edac drivers (incompleted list) v2: https://lore.kernel.org/lkml/20220817143458.335938-1-justin.he@arm.com/ - add acked-by tag of Patch 1 from Ard - split the notifier patch - add 2 patch to get regular drivers selected when ghes edac is not loaded - fix an errno in igen6 driver - add a patch to fix the sparse warning of ghes - refine the commit logs v1: https://lore.kernel.org/lkml/20220811091713.10427-1-justin.he@arm.com/ Jia He (8): efi/cper: export several helpers for ghes_edac to use EDAC/ghes: Add a notifier for reporting memory errors EDAC:ghes: Move ghes_edac.force_load to ghes module parameter ghes: Introduce a helper ghes_edac_preferred() EDAC/ghes: Make ghes_edac a proper module to remove the dependency on ghes EDAC: Add the ghes_edac_preferred check for chipset-specific edac drivers apei/ghes: Use unrcu_pointer for cmpxchg EDAC/igen6: Return consistent errno when another edac driver is enabled drivers/acpi/apei/ghes.c | 85 +++++++++++++++++++++++++++++++--- drivers/edac/Kconfig | 4 +- drivers/edac/amd64_edac.c | 3 ++ drivers/edac/armada_xp_edac.c | 3 ++ drivers/edac/edac_module.h | 1 + drivers/edac/ghes_edac.c | 77 +++++++++++++++++++----------- drivers/edac/i10nm_base.c | 3 ++ drivers/edac/igen6_edac.c | 5 +- drivers/edac/layerscape_edac.c | 3 ++ drivers/edac/pnd2_edac.c | 3 ++ drivers/edac/sb_edac.c | 3 ++ drivers/edac/skx_base.c | 3 ++ drivers/edac/thunderx_edac.c | 3 ++ drivers/edac/xgene_edac.c | 3 ++ drivers/firmware/efi/cper.c | 3 ++ include/acpi/apei.h | 2 + include/acpi/ghes.h | 36 +++++--------- 17 files changed, 179 insertions(+), 61 deletions(-) -- 2.25.1