Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220829062202.3287-1-zong.li@sifive.com> <a0425472-00ed-81dc-e98d-fbccc1e95575@sifive.com>
In-Reply-To: <a0425472-00ed-81dc-e98d-fbccc1e95575@sifive.com>
From:   Zong Li <zong.li@sifive.com>
Date:   Wed, 31 Aug 2022 16:23:11 +0800
Message-ID: <CANXhq0rbMmARbjpijH7G_eFbQsQOb4Hsupoj-OOccrPiG8PY=w@mail.gmail.com>
Subject: Re: [PATCH 0/3] Rename sifive L2 cache to sifive CCACHE
To:     Ben Dooks <ben.dooks@sifive.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        krzysztof.kozlowski+dt@linaro.org,
        Palmer Dabbelt <palmer@dabbelt.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Greentime Hu <greentime.hu@sifive.com>,
        Conor Dooley <conor.dooley@microchip.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>,
        linux-riscv <linux-riscv@lists.infradead.org>,
        "linux-kernel@vger.kernel.org List" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Aug 30, 2022 at 3:59 PM Ben Dooks <ben.dooks@sifive.com> wrote:
>
> On 29/08/2022 07:21, Zong Li wrote:
> > Since composible cache may be L3 cache if private L2 cache exists, we
> > should use its original name "composible cache" to prevent confusion.
> >
> > This patchset contains the modification which is related to ccache, such
> > as DT binding and EDAC driver.
> >
> > Greentime Hu (1):
> >    soc: sifive: l2 cache: Rename SiFive L2 cache to composible cache.
> >
> > Zong Li (2):
> >    dt-bindings: sifive-ccache: rename SiFive L2 cache to composible cache
> >    EDAC/sifive: use sifive_ccache instead of sifive_l2
> >
> >   ...ifive-l2-cache.yaml => sifive-ccache.yaml} |   6 +-
> >   drivers/edac/Kconfig                          |   2 +-
> >   drivers/edac/sifive_edac.c                    |  12 +-
> >   drivers/soc/sifive/Kconfig                    |   7 +-
> >   drivers/soc/sifive/Makefile                   |   2 +-
> >   drivers/soc/sifive/sifive_ccache.c            | 221 ++++++++++++++++
> >   drivers/soc/sifive/sifive_l2_cache.c          | 237 ------------------
> >   include/soc/sifive/sifive_ccache.h            |  16 ++
> >   include/soc/sifive/sifive_l2_cache.h          |  16 --
> >   9 files changed, 253 insertions(+), 266 deletions(-)
> >   rename Documentation/devicetree/bindings/riscv/{sifive-l2-cache.yaml => sifive-ccache.yaml} (92%)
> >   create mode 100644 drivers/soc/sifive/sifive_ccache.c
> >   delete mode 100644 drivers/soc/sifive/sifive_l2_cache.c
> >   create mode 100644 include/soc/sifive/sifive_ccache.h
> >   delete mode 100644 include/soc/sifive/sifive_l2_cache.h
>
> Is this series available on a git branch anywhere, I have at least
> one other cleanup I was doing in a similar move to rename and make
> it usable as the l3 cache.
>
> I gave the series a quick review and did not find any issues so far.
>

Thanks for your review, I don't push the series to a public
repository, if you needed, I can push it to somewhere.

> --
> Ben
>
>