Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp265258rwe; Wed, 31 Aug 2022 02:21:35 -0700 (PDT) X-Google-Smtp-Source: AA6agR45W6IzojEOONS4xuOQs1CGBf6oQfFVAyY9vsMNRsJjr395wNAVTr99/ukKRXT0vIbj/YiG X-Received: by 2002:a65:6944:0:b0:41b:4483:35cc with SMTP id w4-20020a656944000000b0041b448335ccmr22009922pgq.296.1661937694981; Wed, 31 Aug 2022 02:21:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661937694; cv=none; d=google.com; s=arc-20160816; b=btpkKlDyoug4TNpd5thrn7p9yrTLer/TvMJY1iDtfwwJ17wxVge8eZKlcKbPj/d7Jh HE853OibiUQbC7JQ5tMygRdz6dERbSO9Y7WqnQjI02NPLz+2XvdRV4YzxwB4ZzXGwkZU 73saHbX7gvAvtQWh64wTncDd9rMGLMMwtSCMe8rGw/mXKQf9oy2LlzLpYITrkeLVwiVA lX9bq0HdBGCuWTJjD6nFZADkyn8m/oA0VyG0j/2Ax5otyozNWj/+JnUiiOScr8D0IPxA pqpHWFe//tEyjdw0I+rt+91U53kSVHJ1KEtSgDvtZADknZu7yrEznt6eUysZWXvTv0uJ xJBw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=itawxFFk/gSTBSLN6TrrwNrQybZGExiMiIJrjy0+E3Y=; b=fqCsatTKrnga8StO9Iz26S9Yx/K1wfGqPyB54YD+0XQBzvibYPrKTPI1CtP4qEjHNM Az48De/T8e9lkhZSKP3Sv542tRc/GdDoEfo0FFfgFlYq9u49WYs8ey8RNpsDY/dyZNij jsFcXohwuWZDMxeU8k3jr8klRqR8BDB692aDds09p71T91TLDZuBxeTEusJaKUT9T7vq TIVucSXGbVG2yfE84QMe/aHYWl8vuOG6+jMO6dCofGYe3CcVa2/vM4j1eC+n9QLbPCLt mvTwob6dPwQrj5SfkDmC5dDhHTJatHCWeHNWYhsjY5pVmFiT8cuFmmM8jV2JVmarlD2l +wUA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id l186-20020a6391c3000000b0041603077be7si4209594pge.612.2022.08.31.02.21.24; Wed, 31 Aug 2022 02:21:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231715AbiHaJH2 (ORCPT + 99 others); Wed, 31 Aug 2022 05:07:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43198 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230393AbiHaJH1 (ORCPT ); Wed, 31 Aug 2022 05:07:27 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2763DB7EEE for ; Wed, 31 Aug 2022 02:07:25 -0700 (PDT) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oTJgx-0003MS-E4; Wed, 31 Aug 2022 11:07:23 +0200 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1oTJgw-0005v6-Ho; Wed, 31 Aug 2022 11:07:22 +0200 Date: Wed, 31 Aug 2022 11:07:22 +0200 From: Sascha Hauer To: Marco Felsch Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven , kernel@pengutronix.de, Bartosz Golaszewski , Linus Walleij Subject: Re: [PATCH v2 1/2] gpio: Add gpio latch driver Message-ID: <20220831090722.GN24324@pengutronix.de> References: <20220831055811.1936613-1-s.hauer@pengutronix.de> <20220831055811.1936613-2-s.hauer@pengutronix.de> <20220831080109.tqzwgm3o47c7wlzi@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220831080109.tqzwgm3o47c7wlzi@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2022 at 10:01:09AM +0200, Marco Felsch wrote: > Hi Sascha, > > On 22-08-31, Sascha Hauer wrote: > > This driver implements a GPIO multiplexer based on latches connected to > > other GPIOs. A set of data GPIOs is connected to the data input of > > multiple latches. The clock input of each latch is driven by another > > set of GPIOs. With two 8-bit latches 10 GPIOs can be multiplexed into > > 16 GPIOs. GPOs might be a better term as in fact the multiplexed pins > > are output only. > > > > Signed-off-by: Sascha Hauer > > apart the one minor nit (see end) feel free to add my > > Reviewed-by: Marco Felsch > > > +// SPDX-License-Identifier: GPL-2.0-or-later [snip] > > +MODULE_LICENSE("GPL v2"); > > checkpatch.pl should complain about this since it it now GPL, see commit > bf7fbeeae6db. Sorry for not spotted that earlier. Just checked, checkpatch doesn't complain. Will fix in v3 Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |