Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <92cdeaeb8aebb22852e7a5079f41216852c27de9.camel@pengutronix.de>
Subject: Re: [PATCH v3 04/19] dt-bindings: hwmon: (mr75203) change "reset"
 property to be optional
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     "Farber, Eliav" <farbere@amazon.com>, jdelvare@suse.com,
        linux@roeck-us.net, robh+dt@kernel.org, rtanwar@maxlinear.com,
        linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Cc:     talel@amazon.com, hhhawa@amazon.com, jonnyc@amazon.com,
        hanochu@amazon.com, ronenk@amazon.com, itamark@amazon.com,
        shellykz@amazon.com, shorer@amazon.com, amitlavi@amazon.com,
        almogbs@amazon.com, dkl@amazon.com, andriy.shevchenko@intel.com
Date:   Wed, 31 Aug 2022 11:48:32 +0200
In-Reply-To: <671a0ee8-9b0d-b417-19ff-013681cc73d8@amazon.com>
References: <20220830192212.28570-1-farbere@amazon.com>
         <20220830192212.28570-5-farbere@amazon.com>
         <3bd5f46dff622e375c4f60140f479bf6ee483aec.camel@pengutronix.de>
         <671a0ee8-9b0d-b417-19ff-013681cc73d8@amazon.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8BIT
User-Agent: Evolution 3.38.3-1 
MIME-Version: 1.0
Precedence: bulk

On Mi, 2022-08-31 at 12:43 +0300, Farber, Eliav wrote:
> On 8/31/2022 11:21 AM, Philipp Zabel wrote:
> > On Di, 2022-08-30 at 19:21 +0000, Eliav Farber wrote:
> > > Change "reset" property to be optional instead of required, for SOCs 
> > > that
> > > don't support a reset controller.
> > > 
> > > Signed-off-by: Eliav Farber <farbere@amazon.com>
> > > ---
> > > V3 -> v2:
> > > - Change "reset" property to be optional instead of adding new
> > >   "reset-control-skip" property.
> > > 
> > >  Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml | 1 -
> > >  1 file changed, 1 deletion(-)
> > > 
> > > diff --git 
> > > a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml 
> > > b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > index 6abde48b746e..2ec4b9da4b92 100644
> > > --- a/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > +++ b/Documentation/devicetree/bindings/hwmon/moortec,mr75203.yaml
> > > @@ -49,7 +49,6 @@ required:
> > >    - reg
> > >    - reg-names
> > >    - clocks
> > > -  - resets
> > 
> > Is this just for mr76006? Or does mr75203 work without reset as well?
> > 
> > If it is the former, maybe a new compatible should be added and resets
> > should be kept required
> 
> mr75203 also works without a reset.
> As I replied in PATCH v3 14/19, series 5/6 is relevant only for the
> temperature sensor.
> The “reset” property is relevant to the controller.

In that case,

Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>

regards
Philipp