Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp338207rwe; Wed, 31 Aug 2022 03:52:55 -0700 (PDT) X-Google-Smtp-Source: AA6agR7AN1u7t6coN8RLQ+vN2pRwfOn/eLqVRirypkUDMNC0Cgcdl13ADf0rLEwF5EtqhfPiytrP X-Received: by 2002:a17:902:bd49:b0:172:df88:8981 with SMTP id b9-20020a170902bd4900b00172df888981mr25276528plx.120.1661943175393; Wed, 31 Aug 2022 03:52:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661943175; cv=none; d=google.com; s=arc-20160816; b=Y8YJ8ma9jL4gnLExxdnym33kAAEhCx4U1JoGofzprinrEtOF7AowV5VkyxYdm1r5M0 8yvZe9YxX+Fhc+CF3SQfSpmuzFiF7VN2lvw97UBXrw8ynH/ybYlnIQWu5vqFb0Z+MI+2 0/XIt3f5pcvjHAhPDyTia5gWSl68o7uanMcFzjAUUUJ3Tx3QxW6H5840cMbSwH+DuCSu oZw5/0NJQfhvs0kXl+LS7ypMwW8ARMiIsKlmwX6dRiwM5Nex5Uq0Wfmfz5sx7Hvng/A8 IbJuetcrZg5V6uczEz3CtyY2OQWkkQF/cYKyVVal/g8oFDbYFMJIiY1w0oHrv95lR9iu YFqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=61tT55nDB+Ib4pGWtWcvw1GGG33bPqZDR/VePuIijw0=; b=fq5EQ+2VqEcdUaDWNjXl9iF3oJPKnHvJ9eKuxSR+zK26N5GeGSuUJLubPx3WVow66M o9LILb/P5/ZG7FHSDgqz5vNLDikKTXpPT4BSIkWtmNzaQI69L6GqqeQY1zeSwSp1JIu8 aPFBjTbqTE9bidxUMPrkkNDF86nbdDYEMEnyJ6N4MrUxRwlNvF4q1Jl8vJvdDljYhVhn m90qUk+HbQzicZ3375TVwfEstmwm++QWcwy7mgS09u3sUplEqKfryFsSzfc7gXL02Rn5 RoUK2JzZveYoD2oNse5vwnu7d+VYVYmlzGWuy6vHHxS0q8JHWndqG6eDBznLK0xn9J2q WGcQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id lt24-20020a17090b355800b001fdc277fd64si1525239pjb.15.2022.08.31.03.52.42; Wed, 31 Aug 2022 03:52:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230507AbiHaK0z (ORCPT + 99 others); Wed, 31 Aug 2022 06:26:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229921AbiHaK0x (ORCPT ); Wed, 31 Aug 2022 06:26:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC15BB7EDD for ; Wed, 31 Aug 2022 03:26:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9B4F4B81FF7 for ; Wed, 31 Aug 2022 10:26:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A33BC433D6; Wed, 31 Aug 2022 10:26:47 +0000 (UTC) Date: Wed, 31 Aug 2022 11:26:33 +0100 From: Catalin Marinas To: Yun Levi Cc: Baoquan He , will@kernel.org, nramas@linux.microsoft.com, thunder.leizhen@huawei.com, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List , kexec@lists.infradead.org Subject: Re: [PATCH v2-RESEND] arm64/kexec: Fix missing extra range for crashkres_low. Message-ID: References: <20220830092839.3197-1-ppbuk5246@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2022 at 10:49:30AM +0900, Yun Levi wrote: > Like crashk_res, Calling crash_exclude_mem_range function with > crashk_low_res area would need extra crash_mem range too. > > Add one more extra cmem slot in case of crashk_low_res is used. > > Signed-off-by: Levi Yun > Fixes: 944a45abfabc ("arm64: kdump: Reimplement crashkernel=X") > Cc: stable@vger.kernel.org To be even more precise, it should be: Cc: # 5.19.x > Acked-by: Baoquan He > Reviewed-by: Catalin Marinas > --- > arch/arm64/kernel/machine_kexec_file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/machine_kexec_file.c > b/arch/arm64/kernel/machine_kexec_file.c > index 889951291cc0..a11a6e14ba89 100644 > --- a/arch/arm64/kernel/machine_kexec_file.c > +++ b/arch/arm64/kernel/machine_kexec_file.c > @@ -47,7 +47,7 @@ static int prepare_elf_headers(void **addr, unsigned long *sz) > u64 i; > phys_addr_t start, end; > > - nr_ranges = 1; /* for exclusion of crashkernel region */ > + nr_ranges = 2; /* for exclusion of crashkernel region */ > for_each_mem_range(i, &start, &end) > nr_ranges++; Something happened to the whitespace here, so the patch can't be applied. -- Catalin