Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 Aug 2022 12:49:41 +0200
From:   =?utf-8?Q?Micha=C5=82?= Winiarski <michal.winiarski@intel.com>
To:     =?utf-8?B?TWHDrXJh?= Canal <mairacanal@riseup.net>
CC:     Isabella Basso <isabbasso@riseup.net>, <magalilemes00@gmail.com>,
        <tales.aparecida@gmail.com>, <mwen@igalia.com>,
        <andrealmeid@riseup.net>, <siqueirajordao@riseup.net>,
        Trevor Woerner <twoerner@gmail.com>,
        "Daniel Vetter" <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
        "Javier Martinez Canillas" <javierm@redhat.com>,
        David Gow <davidgow@google.com>, <brendanhiggins@google.com>,
        Arthur Grillo <arthur.grillo@usp.br>,
        =?utf-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>,
        <kunit-dev@googlegroups.com>, <linux-kselftest@vger.kernel.org>,
        <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] drm/tests: Split drm_framebuffer_create_test into
 parameterized tests
Message-ID: <20220831104941.doc75juindcm5mcl@nostramo.hardline.pl>
References: <20220830211603.191734-1-mairacanal@riseup.net>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220830211603.191734-1-mairacanal@riseup.net>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NkJyTFJObWdCTWZ4L3NIdGRzUlVMT2t1MVAyRjRZM2orWWtXQUc0ZXo5NDZk?=
 =?utf-8?B?bXJJbWtjdnVYUFFxNVJ4bXppUnVFWHc1REFOVjhkZTllazYrZmlvK0doRHdt?=
 =?utf-8?B?ckpXNmR5UWo1bndnNjBlMU9vQm1EajhGcEtNQlBaMFQwZ1lRaU5UTUFaVjNV?=
 =?utf-8?B?QU81eG5KZVhmYTJCb3FGUzFhZ0VyZ3JJWDZEbWNHRHg0bVYxL2NZOHk2d1Vo?=
 =?utf-8?B?Z2YxQmdjWTdkNEx6T1RFSExjZU9xWmFvakdVejY0cWZzbzdHa3gyZUY0azJv?=
 =?utf-8?B?cjlHM0ljNGZXSEJ3dk96aDFwY0tsZFFlNndKNk5TL2JJUFVRZzM3V1gzZzZw?=
 =?utf-8?B?WXU4TDRmak9VTy93Y3d2cFhFN1lQVnJPUFhqUFNFQVhrVXh1cWJmOEk1ODFP?=
 =?utf-8?B?dWk2bFNTUWhGRzE0RTc1MC9ManZzRkQxWHhXR0hRNkQyQStvd3RDSHZ3Y2t5?=
 =?utf-8?B?aDUzelhEQkZGeExLTTgzUE00UFladW5lRnp0OFMzWlIzakhwVHdkVnJyellO?=
 =?utf-8?B?cnZpQi9EWTVvS2gzdE1vZEZSMko0YnNzVERXTmo3cWpFOFBrM0RZZVpSYjhC?=
 =?utf-8?B?VVRjNmtCY2djSGxPSzYwQmh4cHNKQjl6a1duL3YvbG50bDJmYVREcnkwOURE?=
 =?utf-8?B?dGViL0x6SlVIUnlGYzJXYmZyWWdxcVR2Yk9oUHROdllNa1lGRUFjdW5mMVQ5?=
 =?utf-8?B?NldZWjBMZFRFQ3BGZGJvajYxTWxPbS9ZQlU1N2c2aHVzVFBwR0dyL1JZdzBr?=
 =?utf-8?B?TG1yUnE0U0U5djBycWh4WCtHd0I5dCs4ejJYZmwxMkZXaS9xcWpab3ZQUDRK?=
 =?utf-8?B?aCtOVThpWDNqSVl1MkxpSWg4M0VFYXFsTXdmRmcyNmMyT1poVXlhSmR0UXcy?=
 =?utf-8?B?KzdrcVBkSzg3citwWS9iVnVvN0k1OUJTOWw4YkhpMGZMNDMxN1I0Qk5NaThX?=
 =?utf-8?B?d25scTg4ZFVOWXV1aFF1eFdJZTR1WDlWTnFKcFJjZnZnZHVRNkExQUlPdExN?=
 =?utf-8?B?Vi9kNDAwRmh2VDZ3VTlGMTBodlZvdTNPUWtaUlROT1RDRzUrSE9aUDNSaWtp?=
 =?utf-8?B?M2FHYnNQU2haTFVJTHBBV3BSZjIzdjdrS3M3QUtQcWllQjVMdXdiMXlSOE1J?=
 =?utf-8?B?VUVMSFQrOUJFejlKUU5GS09iZHhQc3h2eG9JcE9sNzBWa1Fwc0g2WlExdjZh?=
 =?utf-8?B?S1RSMWRpZzVCZytkaE1DUFQ4TnJFaHFmS1I5eW9ObTVQZGx2L3NmcGp5RGRu?=
 =?utf-8?B?Z3E3RGwwaVQ1eENWbjYyL2xQTDl5SHR5QzNRaTYrR0tpcUxtK05TTDVFRmZQ?=
 =?utf-8?B?K2p0MzFNWE1iMFh3V0tVYjZkWjhla2Z2V0RoYWkxTVdmb1Znbis2Qzd4bWdy?=
 =?utf-8?B?SXNDY2N0Q1YyZ1FQT3dQZUZCVUVxUVVUK1VKSGkxRW1wb0RHdmhVZWJ6a0lV?=
 =?utf-8?B?azl2aTVDaGM4OXFybzh2dFZtWVFmZWZqM3F1S25odHhnM3V5RlpXS3hTMzls?=
 =?utf-8?B?L2tMdGZ5NlNBTFhrTWtqbXNuMXNQb3grbUpkM0R5T0YrcGM3ZzF5a1FRMXNZ?=
 =?utf-8?B?MkdmSUdkRlNhNGxKazhjbmVHdTVtZzltVU5yamMvcDB3Tk5McDZhMGtPakFC?=
 =?utf-8?B?SXYreWxZUVlCaUZzNEFCTlNzZGJaZmdjc2pJaUQwTlI1M09RL3RBVUFrdUF4?=
 =?utf-8?B?NFJ3eG1oUkJPMTNJL3pCSnNScnlzRE8xUEZKeE1BZ3B1dGc0L0s2cFJ1UVhD?=
 =?utf-8?B?d3JkM3BQUWg3Vy84QTMwVUFaNmU5eC94d0V5ckNtVkdqb1Q5MlZEUWtiNXhO?=
 =?utf-8?B?ZTAxOEVoZ0VoV2RGMVZWNURoU1Z5ZEVseXNGZks2OU1oTGoyTERSL3RKR2lX?=
 =?utf-8?B?YkJleTNiTzlFeW52SmhnTllUSk5CVE9BT21sUWZYR1VCREYzc2JuSmxqcU9Q?=
 =?utf-8?B?MnpScnQydGw2WStqWmwvMlVBMElhTDl6SE1BS080Nm94OU5YSEdQeU11NVZN?=
 =?utf-8?B?ekNZdnA1d3AwelhkZFJUeTl4ZEpKMkh5NWxCZlhCQW5UTlcrZWVuYSs1a2RV?=
 =?utf-8?B?TUdEbXl5T2ZiL21CbnFPTWp2YTU0cXo5Wk41bVlpbm12eVVVc3kwWGUySkJQ?=
 =?utf-8?B?MjBhdUdmallSRVcyTnlQeUtiMGNkb0VyZjNPQXJBWkJVZWlHTW8xU0k5QjRI?=
 =?utf-8?B?TWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 28df23b4-9a0e-437b-2f74-08da8b3e8650
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5373.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 10:49:48.5856
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UXGWuphzuJvGZ4RtAljYO1y3HeLcFqxe8JUYkmxFnq/4BjaGzSZhw6LK+UQk6srJj2ky6x0o9TWTRjn8TNPqNf8AeCRw9bau1/c0M0SW3Ts=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3996
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 30, 2022 at 06:16:02PM -0300, Maíra Canal wrote:
> The igt_check_drm_framebuffer_create is based on a loop that executes
> tests for all createbuffer_tests test cases. This could be better
> represented by parameterized tests, provided by KUnit.
> 
> So, convert the igt_check_drm_framebuffer_create test into parameterized tests.
> 
> Signed-off-by: Maíra Canal <mairacanal@riseup.net>

Now that we have separate testcases, we may also want to consider using .init
for mock_drm_device instead of a global
(see:
https://lore.kernel.org/dri-devel/20220117232259.180459-5-michal.winiarski@intel.com/
for reference)

Either way:
Reviewed-by: Michał Winiarski <michal.winiarski@intel.com>

-Michał

> ---
>  drivers/gpu/drm/tests/drm_framebuffer_test.c | 23 +++++++++-----------
>  1 file changed, 10 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/gpu/drm/tests/drm_framebuffer_test.c b/drivers/gpu/drm/tests/drm_framebuffer_test.c
> index ec7a08ba4056..3e46fd9f6615 100644
> --- a/drivers/gpu/drm/tests/drm_framebuffer_test.c
> +++ b/drivers/gpu/drm/tests/drm_framebuffer_test.c
> @@ -25,7 +25,7 @@ struct drm_framebuffer_test {
>  	const char *name;
>  };