Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp421172rwe; Wed, 31 Aug 2022 05:16:33 -0700 (PDT) X-Google-Smtp-Source: AA6agR4XgYnzB9UamwbLmUD4QDafyRGOlYXbRQ3woSNAytAMDmiwBZJm6FKitt90R0tBGlOg72DQ X-Received: by 2002:a17:907:2d23:b0:730:acf0:4907 with SMTP id gs35-20020a1709072d2300b00730acf04907mr20452124ejc.700.1661948192862; Wed, 31 Aug 2022 05:16:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661948192; cv=none; d=google.com; s=arc-20160816; b=o4bHmiR29xih+ve8TD7r2cpGcHZBkzYorE2k7CqX4nkcFCjPnYIJGb2pskYK71VEZ1 P2S6bUKCwuPDZjeds30k/WxjH1wgAG+s0jKNNqzuooypq16FiVUE1De92OHItextWym/ 9Em0VmM1MWzx+zQKDMsxnuKKkT++LRFd/LLrCEksNM2QKvuLE5czjRNE2TTaCnQ9XXmG omalRhCdfZmxYhDrhd+OTfOBBDMSRb0LBMyq3yA9eTstqdVmt6lvL8JGq3s7B5FuWoDC TkkxFvjyqx8chE/V7Yj6B5qebwjI2IOV/NNQ0ruEHSReTVZEr93/p6CnkT1uCrPVfW9l u7EA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=NOgcZXUTYF+CKTpWFn+A9sP/evQoRjIfePhgBFwX91w=; b=YpsCoU+U1kuxAbGkiv/arBtElWXWL2TLhh3n+oNznUDQRenNLpT8XUdmkat4AIREsu JkUMR0cPtLKImRRNd6vxkg7gIdSUkFQh5qkQpCyotjniJdsxGvvAYZnNGToDaEJN6YeM /YVQ32OAZi+UjyH/iLi8qtxynzoKEOfcNRSvWBp2Zcy56Ye5apxDfu1KZIZ4Qq7tl00Z iOzBwOHJoEeheZK+qvD8rq5HZV09g/C2AXdGSSeLIVbUr2O134m0X5U5nbd8YFMe7Oct 0wiFaflRwZiVdXozU3bxD0EsFIcff7vO7lu1rFpvct1zgcKtSfO3ebNkYQMrGerDBbDo Rbjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b="P/lmgXyj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nd10-20020a170907628a00b0072b3ccd50dasi11387478ejc.905.2022.08.31.05.16.06; Wed, 31 Aug 2022 05:16:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b="P/lmgXyj"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230232AbiHaL6A (ORCPT + 99 others); Wed, 31 Aug 2022 07:58:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230151AbiHaL56 (ORCPT ); Wed, 31 Aug 2022 07:57:58 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5FBED25E5 for ; Wed, 31 Aug 2022 04:57:57 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id se27so20132113ejb.8 for ; Wed, 31 Aug 2022 04:57:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=NOgcZXUTYF+CKTpWFn+A9sP/evQoRjIfePhgBFwX91w=; b=P/lmgXyjfnF9cfsP7itAQaj19CLSaJGb6guFQ1cfK6CxFlWbyvhw++VLNHOhDUeKmw xJaXySbkDo3rj+OPPSEbCMzqtbDIlQEkYN6JGQJu/k7s9ubidS25IcLVCBGVK8UMx55o c8COb3V3GAvHWb6ATXRLizY3KaokdIwuvdOj2SKv+JVdKurRthef19aHhgKqHKVsJbYW qqJIbAeLJnXWoYsf1MeXLxVi/9majHbX8AcBY/B4iXytkeGync+UxWqpLdjA1Q3LwnuI TCVvc03WL66ygsbKcSxCK8CheAHVcuJMi0lfAX2TSz2KsShzHKBzNdNDk7UPV7E2lsDD qIEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=NOgcZXUTYF+CKTpWFn+A9sP/evQoRjIfePhgBFwX91w=; b=GcHm+Y4cBHQwrX0oKGGt9ODjxCRl2BjS2I3zkqHzwFwrjR+TQqVuRWNtHc390MR8xL uzW4S71kU0suK537Muz0Pa0lZcAHoQoN1EzfaCbCBzbbSM0wXrtrXQyPklZOmCdZtl2h 7E2PxvHx+yNlKs+zcxvroQ9wStExuNV79zu3fURPWzlI6Z7FZrSJmJRA10WlGqupTv1A U6mzQsUDYqV+clPwAR+OOZxFDuK2RFdvtZEJduTvnKsC13afmUUMYalceWb/WHjkoOiM +5PGCsPAx/+obYhjauo7Y+S8Vpt5rdcd2v5ZcNwfHxXzd0V4AaB1967lUh/o1YQt+cmh NgxQ== X-Gm-Message-State: ACgBeo2qTXP4i8w6+5iPntzfgBMAPYloOdzH/ZMvS7u5PJ7FOqdf1ff0 1DuIgox69699ZrnJSXRbf59jwfZWUeyx3TSybWKCLdnqGBA= X-Received: by 2002:a17:907:2722:b0:731:2aeb:7942 with SMTP id d2-20020a170907272200b007312aeb7942mr20187601ejl.734.1661947076458; Wed, 31 Aug 2022 04:57:56 -0700 (PDT) MIME-Version: 1.0 References: <20220829133923.1114555-1-martyn.welch@collabora.com> <20220829133923.1114555-5-martyn.welch@collabora.com> In-Reply-To: <20220829133923.1114555-5-martyn.welch@collabora.com> From: Bartosz Golaszewski Date: Wed, 31 Aug 2022 13:57:45 +0200 Message-ID: Subject: Re: [PATCH 5/5] gpio: pca953x: Add support for PCAL6534 and compatible To: Martyn Welch Cc: Linus Walleij , kernel@collabora.com, "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2022 at 3:39 PM Martyn Welch wrote: > > Add support for the NXP PCAL6534 and Diodes Inc. PI4IOE5V6534Q. These > devices, which have identical register layouts and features, are broadly a > 34-bit version of the PCAL6524. > > However, whilst the registers are broadly what you'd expect for a 34-bit > version of the PCAL6524, the spacing of the registers has been > compacted. This has the unfortunate effect of breaking the bit shift > based mechanism that is employed to work out register locations used by > the other chips supported by this driver, resulting in special handling > needing to be introduced in pca953x_recalc_addr() and > pca953x_check_register(). > > Datasheet: https://www.nxp.com/docs/en/data-sheet/PCAL6534.pdf > Datasheet: https://www.diodes.com/assets/Datasheets/PI4IOE5V6534Q.pdf > Signed-off-by: Martyn Welch > --- Is this series complete? I don't have patch 1/5 in my inbox and neither does patchwork. Bart