Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220830192212.28570-1-farbere@amazon.com> <20220830192212.28570-9-farbere@amazon.com>
 <1661945961.480039.3614528.nullmailer@robh.at.kernel.org> <a8557b5a-6e27-2e66-161e-814fc0f69c1d@amazon.com>
In-Reply-To: <a8557b5a-6e27-2e66-161e-814fc0f69c1d@amazon.com>
From:   Rob Herring <robh@kernel.org>
Date:   Wed, 31 Aug 2022 07:17:32 -0500
Message-ID: <CAL_Jsq+c7DaJFCgeHDsXQT8oqHmPS57S-o_EALz=nHDREhqc7g@mail.gmail.com>
Subject: Re: [PATCH v3 08/19] dt-bindings: hwmon: (mr75203) add "moortec,
 vm-active-channels" property
To:     "Farber, Eliav" <farbere@amazon.com>
Cc:     almogbs@amazon.com, Rahul Tanwar <rtanwar@maxlinear.com>,
        Talel Shenhar <talel@amazon.com>,
        Linux HWMON List <linux-hwmon@vger.kernel.org>,
        itamark@amazon.com, amitlavi@amazon.com,
        Guenter Roeck <linux@roeck-us.net>,
        Jonathan Chocron <jonnyc@amazon.com>,
        Philipp Zabel <p.zabel@pengutronix.de>, shellykz@amazon.com,
        Jean Delvare <jdelvare@suse.com>, shorer@amazon.com,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        devicetree@vger.kernel.org, dkl@amazon.com,
        "Hanoch, Uri" <hanochu@amazon.com>,
        Andy Shevchenko <andriy.shevchenko@intel.com>,
        "Hawa, Hanna" <hhhawa@amazon.com>,
        "Krupnik, Ronen" <ronenk@amazon.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Aug 31, 2022 at 6:53 AM Farber, Eliav <farbere@amazon.com> wrote:
>
> On 8/31/2022 2:39 PM, Rob Herring wrote:
>
> On Tue, 30 Aug 2022 19:22:01 +0000, Eliav Farber wrote:
>
> Add optional "moortec,vm-active-channels" property to define the number
> of active channels per VM.
>
> This shall be useful to avoid exposing sysfs for reading inputs that are
> not connected to any voltage source.
>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
> V3 -> V2:
> - Add "moortec" prefix to property name.
> - Add explanation why this change is needed.
>
>  .../devicetree/bindings/hwmon/moortec,mr75203.yaml    | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> I used dt_binding_check on my changes (I ported it to my kernel).
> The error is related to "intel-vm-map" which I did not add.

The error is the vendor prefix is not defined in vendor-prefixes.yaml.

> I don't mind fixing it if you wish.
> It requires changing:
>   intel,vm-map = [03 01 04 ff ff];
> to:
>   intel,vm-map = /bits/8 <0x03 0x01 0x04 0xff 0xff>;

That is not the issue. The issue is the type is unknown because your
schema fails and we can't get the type from it. Once your schema
passes, this should go away.

Rob