Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 Aug 2022 20:49:06 +0800
From:   <zhangxuezhi3@gmail.com>
To:     Ian Abbott <abbotti@mev.co.uk>
Cc:     hsweeten@visionengravers.com, gregkh@linuxfoundation.org,
        zhangxuezhi1@coolpad.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] comedi: sysfs: convert sysfs snprintf to sysfs_emit
Message-ID: <20220831204906.730b0363@carlis-virtual-machine>
In-Reply-To: <0a0e568e-e3fc-56da-8370-e4796b480fe3@mev.co.uk>
References: <20220831121456.210835-1-zhangxuezhi3@gmail.com>
        <0a0e568e-e3fc-56da-8370-e4796b480fe3@mev.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 31 Aug 2022 13:33:18 +0100
Ian Abbott <abbotti@mev.co.uk> wrote:

> On 31/08/2022 13:14, Xuezhi Zhang wrote:
> > From: zhangxuezhi1 <zhangxuezhi1@coolpad.com>
> > 
> > Fix up all sysfs show entries to use sysfs_emit
> > 
> > Signed-off-by: zhangxuezhi1 <zhangxuezhi1@coolpad.com>  
> 
> The patch looks fine apart from the Signed-off-by line.  Please use a 
> proper name for the Signed-off-by line.  Generally, a romanized
> version of the forename(s) (given name(s)) followed by the surname
> (family name) is preferred, for example: Xuezhi Zhang.
> 
> Could you please post a "PATCH v2" with a proper Signed-off-by line? 
> Thanks.
Hi,
  OK, I see.

Thanks.

> > ---
> >   drivers/comedi/comedi_fops.c | 8 ++++----
> >   1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/comedi/comedi_fops.c
> > b/drivers/comedi/comedi_fops.c index 55a0cae04b8d..e2114bcf815a
> > 100644 --- a/drivers/comedi/comedi_fops.c
> > +++ b/drivers/comedi/comedi_fops.c
> > @@ -396,7 +396,7 @@ static ssize_t max_read_buffer_kb_show(struct
> > device *csdev, mutex_unlock(&dev->mutex);
> >   
> >   	comedi_dev_put(dev);
> > -	return snprintf(buf, PAGE_SIZE, "%u\n", size);
> > +	return sysfs_emit(buf, "%u\n", size);
> >   }
> >   
> >   static ssize_t max_read_buffer_kb_store(struct device *csdev,
> > @@ -452,7 +452,7 @@ static ssize_t read_buffer_kb_show(struct
> > device *csdev, mutex_unlock(&dev->mutex);
> >   
> >   	comedi_dev_put(dev);
> > -	return snprintf(buf, PAGE_SIZE, "%u\n", size);
> > +	return sysfs_emit(buf, "%u\n", size);
> >   }
> >   
> >   static ssize_t read_buffer_kb_store(struct device *csdev,
> > @@ -509,7 +509,7 @@ static ssize_t max_write_buffer_kb_show(struct
> > device *csdev, mutex_unlock(&dev->mutex);
> >   
> >   	comedi_dev_put(dev);
> > -	return snprintf(buf, PAGE_SIZE, "%u\n", size);
> > +	return sysfs_emit(buf, "%u\n", size);
> >   }
> >   
> >   static ssize_t max_write_buffer_kb_store(struct device *csdev,
> > @@ -565,7 +565,7 @@ static ssize_t write_buffer_kb_show(struct
> > device *csdev, mutex_unlock(&dev->mutex);
> >   
> >   	comedi_dev_put(dev);
> > -	return snprintf(buf, PAGE_SIZE, "%u\n", size);
> > +	return sysfs_emit(buf, "%u\n", size);
> >   }
> >   
> >   static ssize_t write_buffer_kb_store(struct device *csdev,  
>