Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp489709rwe; Wed, 31 Aug 2022 06:18:54 -0700 (PDT) X-Google-Smtp-Source: AA6agR5shVoT4QZoeM4EPo+xRjBXC6Vdz+d2dlPmYnIv5Od75tr92iHSgn+vEvouSSzERrfARaCD X-Received: by 2002:a63:f304:0:b0:42c:1057:e37 with SMTP id l4-20020a63f304000000b0042c10570e37mr12607101pgh.379.1661951934658; Wed, 31 Aug 2022 06:18:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661951934; cv=none; d=google.com; s=arc-20160816; b=uFXVJfxIdiD0XuuhK7lvgP2ZMl5BdF3M5mjHpzuc8qhCSeUqNNG4r+Pz8+IuhaWzBm YS4BnGmgGfI3NVWBSoXbYynvkcFLCGoJkE4OsLiB3ga3/UtXa2adny3gXP8Hp1fl1rWK 0YlAZNTGnFEF4Ip32W095+Xj4I6O/Mdz/IneK528DM2uRDc7QhtrFc4te8SAEC28pP1O tIg/gmJA+iZm9bsS1iodei+OI56MlXIzXzp05cyen3CyspbcJpsf9ACFvVae9CMPS+h0 xzBtLvobWfxqyqB145seXSgInHq7JfaAhxpz60WZ5lKbCUJBFK2B2CitPmxSLFr9A/Rq 8liA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=bZkxF4Gl7HNi0Mqc4gHedXGK3/+SxeeOcfWRC406sbo=; b=AyVocncq3rgmmHOiEN1gJzaWudmw7EaBr5PiI7n+vI9M6V9WAmfi30MUIqQiOidmOu QNEH3+aSSvreXZU1Sj+3gQspSxM3SfMIX2suXXYs3a0rkD1PRC0mYjxqkYgegCClCHtW X0weIYzpeGUs2zDQ5mnGOdBD/P7NngAcR+KAMbCDg3hjqWr7b7XGG53cn7Uj2N6mbls0 X/Ifs8/ErM6hltGaQpfJrr1Ai6SYKh7NW8fbpNYrj2CSdkOPa/X/LW7WEB7cGP8I9HNu JG0AWK/JVuHXlD3G0+WbYubDvXx3Z8IUoDuu53Q+txhBITTT12do6tjT+y0V3tdFeVpT qL3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=A+n1vyg3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e20-20020a63d954000000b0042b804ca112si4742129pgj.785.2022.08.31.06.18.44; Wed, 31 Aug 2022 06:18:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=A+n1vyg3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231233AbiHaMge (ORCPT + 99 others); Wed, 31 Aug 2022 08:36:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229888AbiHaMgS (ORCPT ); Wed, 31 Aug 2022 08:36:18 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 40308B876 for ; Wed, 31 Aug 2022 05:36:16 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id cu2so28145219ejb.0 for ; Wed, 31 Aug 2022 05:36:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=bZkxF4Gl7HNi0Mqc4gHedXGK3/+SxeeOcfWRC406sbo=; b=A+n1vyg3eprzIxpMneJW5BYxflkNBNYo8THCJvZ9xyjLASpNyYAvf3xetDBETyNrIr xlw3mz9xAN7ex8K69lyg5lPXsZJhjzKt0sGgN38hM6h23j0q5X1IaTbjYnu3oXYcG4hc PznUX+kEVc080tf3qliOWyp0iwtEqFZIpzZq+2lembFvM5HxRhuprGcIvr6QwJ7nKLdr s+JJufinCTUpn6aH9iK8sGd8czF5O9Wz7BkJ/ZrDJRUi6Zf5NvfWcRttgPGt66IGywNr UxwxpoAjcwP6y63qQjM0I6xk/9/+9NtsUt1SXbmkLel5BhXLrcSUzHr9sfmVJGCqS5RX XDRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=bZkxF4Gl7HNi0Mqc4gHedXGK3/+SxeeOcfWRC406sbo=; b=sB4Ivgbpuogg/fpSQMS0C/SNF/KDPKqajifAbeAn33nnLdZL0LKFhMKbalhG3sTHAc LaH1CzQQ2BH7MBxaHIRVEzUiEApoWafkE3zK6Di6+cwrX40S3pUgNOO/+im20ENvaXyu iIm0hrUvmHQo0j0Peix3oLV/+n4GFTrwjt+WbnRX7NDiPPYCYxe8xr0WPEgmi5u1wUTT 8JVWn/iqqcDD7l0K/raUH5wqQnJZvgOTKLcg3grODEoRfCl3oWU1yHu1exioPScwNRL7 IdO4Lj4YfSMbJQAFRBrC6uk8WCQxfUubPxST3omFDeaqDbtwCQ4pLoTrXi1vvA2h7d8I nD3g== X-Gm-Message-State: ACgBeo35d2wFe7A3VmvZsVnKyli+r/GYu/+H8k6uxB3ptk73qy6OkKKn uYEnsSNQJNsSqCPMqoVs39V9iZkEAZUeSwxhkcXC/w== X-Received: by 2002:a17:906:8a4e:b0:730:9fcd:d988 with SMTP id gx14-20020a1709068a4e00b007309fcdd988mr20162081ejc.636.1661949362413; Wed, 31 Aug 2022 05:36:02 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bartosz Golaszewski Date: Wed, 31 Aug 2022 14:35:51 +0200 Message-ID: Subject: Re: [PATCH 0/6] isa: Ensure number of irq matches number of base To: William Breathitt Gray Cc: linux-iio , "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linus Walleij Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,SUSPICIOUS_RECIPS, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 19, 2022 at 1:11 AM William Breathitt Gray wrote: > > Several ISA drivers support IRQ and call devm_request_irq() in their > device probe callbacks. These drivers typically provide an "irq" array > module parameter, which matches with the respective "base" array module > parameter, to specify what IRQ lines are used for each device. To reduce > code repetition, a module_isa_driver_with_irq helper macro is introduced > providing a check ensuring that the number of "irq" passed to the module > matches with the respective number of "base". The relevant ISA drivers > are updated accordingly to utilize the new module_isa_driver_with_irq > macro. > > William Breathitt Gray (6): > isa: Introduce the module_isa_driver_with_irq helper macro > counter: 104-quad-8: Ensure number of irq matches number of base > gpio: 104-dio-48e: Ensure number of irq matches number of base > gpio: 104-idi-48: Ensure number of irq matches number of base > gpio: 104-idio-16: Ensure number of irq matches number of base > gpio: ws16c48: Ensure number of irq matches number of base > > drivers/counter/104-quad-8.c | 5 ++-- > drivers/gpio/gpio-104-dio-48e.c | 5 ++-- > drivers/gpio/gpio-104-idi-48.c | 5 ++-- > drivers/gpio/gpio-104-idio-16.c | 5 ++-- > drivers/gpio/gpio-ws16c48.c | 5 ++-- > include/linux/isa.h | 52 ++++++++++++++++++++++++++------- > 6 files changed, 57 insertions(+), 20 deletions(-) > > > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 > -- > 2.37.2 > Looks good to me, do you send your PRs directly to Linus? Do you want me to take this through the GPIO tree? Bart