Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp568723rwe; Wed, 31 Aug 2022 07:27:25 -0700 (PDT) X-Google-Smtp-Source: AA6agR6zHdXEM/3/zdXGtsIKly8pq1prBAQp6LfdSNXwHAQa/t1JMDvdnV+vq5RKHXTtxm4LZeUN X-Received: by 2002:a65:6b95:0:b0:420:2cb1:68e5 with SMTP id d21-20020a656b95000000b004202cb168e5mr22141468pgw.220.1661956045319; Wed, 31 Aug 2022 07:27:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661956045; cv=none; d=google.com; s=arc-20160816; b=xFE0nRXdqVra9NK93p1pcGwo6uAoZq+hAE5A6Pa6gu3+SgEeTPeVgusUuGqQtx0+UH ovqz6Ui+FwpuN1PCBit3AClSiRoe0Q9pOiCGrPCcXNAnh8uufn81MoDvfQYeFNFYQZ0z FgVLemmc6MH/1tdm1romZLCOQAGMVAYWpBbxBPF+9hh4PUAAwjK2KgEMhWOCLQlrnYBG iryKnixn0fXYAu91sde53zo0jBaPmXOmecAv4/7O7WTlGYfWrMAZUPmZBxHge8Ge+4jU YTPvkC2vyUvtQn1OOzL6TFzBZzMzu2HerqjLavBdlEnP7gkmK8/TQ+XJVqiuaC6b12aJ 0pqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=6P2lNRWGpZ/wwTsS6VCxsNms7FDaVc457DP8/wjf4sI=; b=bKqQtDfKjryWNWcP9RLbAd8ifxly8KvEsWhZBWZvGGMVJL1obw4nNxRo+jx4IYg8kz 1+AXBRijNc7FbHgN/FN/RiOxdKiENAx7NHY8LD/9nqc1ZkTQ+c273i9uK+psFIRes+8S 65ymCkZi9jICU/mjpyocrkQ94JnYIkRZxdpDvqtjdSs0YPqeOMarl9evHWLVzVR2y83/ nFhNbxPOQxFqiwszyYqdJh9vhT8FmC2/UbJsVqdx4h/U6dP8vmCTKzo/Zsz4goprarp0 /SnjlUt6Its0m3S569ny28/JyvGruyNb4I6JYtezVjlCl1lO9rhdaf3Gz5L2/YHMxjJS 2f8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=52a+2IX0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 20-20020a630214000000b0041a4f4a2afdsi4883778pgc.766.2022.08.31.07.27.13; Wed, 31 Aug 2022 07:27:25 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=52a+2IX0; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230451AbiHaOAm (ORCPT + 99 others); Wed, 31 Aug 2022 10:00:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230043AbiHaOAl (ORCPT ); Wed, 31 Aug 2022 10:00:41 -0400 Received: from mail-ed1-x52b.google.com (mail-ed1-x52b.google.com [IPv6:2a00:1450:4864:20::52b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 38C186E887 for ; Wed, 31 Aug 2022 07:00:39 -0700 (PDT) Received: by mail-ed1-x52b.google.com with SMTP id t5so18498868edc.11 for ; Wed, 31 Aug 2022 07:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=6P2lNRWGpZ/wwTsS6VCxsNms7FDaVc457DP8/wjf4sI=; b=52a+2IX0YGfnqz28f3UmFbBleYRk6kTKTLXnAGyUYgRMmVD1G3B2whwY8hGfSNj9tZ 4S96eLI7xh/bOk7Q2Sf3XdlDb4MhpYUPI04ZuvDxLZrWrCRDtQbWkc1cXvZ3aL1juPcM 6aBk499GW2+fpjSMJU4+uTjmx+9k9Le7RjgiPe3d4AeIGbZHzyyrTesZx4c1ZFgXML9F yFYXWyJYY5+m3bRUFY5fW9ZHTmOoNiLRjoX3H3UaNfrFfxWYxsMf/4Qi/rCO5zYxVvXq bFVzKPPxTNSQudB4bZBISfM4VLwMTTZ5AWFl321KoAsNhJADDmNTG15hFH3U63eab4/l JR7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=6P2lNRWGpZ/wwTsS6VCxsNms7FDaVc457DP8/wjf4sI=; b=rhTdJIq0aLHtikAhcPExF8/kBm2KjSdlIfy79VYooKr9Z8akeVnR6g/mdTuZYg42wj VpFNbYtCR7MkFgpF3iU10Qve6l8hAsJ7noCm8XfkcPR7ZUr8N6p00tR/UCioZDSbhZcB 4V2nSzEpLJE7nYF/JCsAEDUKWGYHxGq0unSaFGacHK+VPOHggXgEBsB7UE4WqWtEi5Px U8KuKjNjA20HxQpEQ0dLpPQwnAwHvy+hyAgMGJDqdJIdNNE1vUW3p5xgKFm2s8Mylo2I f2CkXNDW9FC23lOg7cXf3KLNBM19P55vNWsp7NptDjPoEIusKxI26wdZbcfZFYcyfgWv JiNg== X-Gm-Message-State: ACgBeo3yGDs+IkJAf/PpRi7Yxn9+Wf2onqupduwcxT+E8yUAYMvych9r RDdMoCtVV3D6MBNuZ8RacBuJ+y8xqG3I6vofMPHcnaK8HiU= X-Received: by 2002:a05:6402:51c6:b0:43d:dd3a:196e with SMTP id r6-20020a05640251c600b0043ddd3a196emr24908383edd.213.1661954437747; Wed, 31 Aug 2022 07:00:37 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Bartosz Golaszewski Date: Wed, 31 Aug 2022 16:00:27 +0200 Message-ID: Subject: Re: [PATCH 0/6] isa: Ensure number of irq matches number of base To: William Breathitt Gray Cc: "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List , Linus Walleij Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2022 at 3:54 PM William Breathitt Gray wrote: > > On Wed, Aug 31, 2022 at 02:35:51PM +0200, Bartosz Golaszewski wrote: > > On Fri, Aug 19, 2022 at 1:11 AM William Breathitt Gray > > wrote: > > > > > > Several ISA drivers support IRQ and call devm_request_irq() in their > > > device probe callbacks. These drivers typically provide an "irq" array > > > module parameter, which matches with the respective "base" array module > > > parameter, to specify what IRQ lines are used for each device. To reduce > > > code repetition, a module_isa_driver_with_irq helper macro is introduced > > > providing a check ensuring that the number of "irq" passed to the module > > > matches with the respective number of "base". The relevant ISA drivers > > > are updated accordingly to utilize the new module_isa_driver_with_irq > > > macro. > > > > > > William Breathitt Gray (6): > > > isa: Introduce the module_isa_driver_with_irq helper macro > > > counter: 104-quad-8: Ensure number of irq matches number of base > > > gpio: 104-dio-48e: Ensure number of irq matches number of base > > > gpio: 104-idi-48: Ensure number of irq matches number of base > > > gpio: 104-idio-16: Ensure number of irq matches number of base > > > gpio: ws16c48: Ensure number of irq matches number of base > > > > > > drivers/counter/104-quad-8.c | 5 ++-- > > > drivers/gpio/gpio-104-dio-48e.c | 5 ++-- > > > drivers/gpio/gpio-104-idi-48.c | 5 ++-- > > > drivers/gpio/gpio-104-idio-16.c | 5 ++-- > > > drivers/gpio/gpio-ws16c48.c | 5 ++-- > > > include/linux/isa.h | 52 ++++++++++++++++++++++++++------- > > > 6 files changed, 57 insertions(+), 20 deletions(-) > > > > > > > > > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868 > > > -- > > > 2.37.2 > > > > > > > Looks good to me, do you send your PRs directly to Linus? Do you want > > me to take this through the GPIO tree? > > > > Bart > > Hi Bart, > > Would you take this through the GPIO tree? I'm planning on submitting > some more patches later for these GPIO drivers so it will be convenient > to keep all these changes within the same tree. > > Thanks, > > William Breathitt Gray Sure, just leave your Acks on the first two patches. Bart