Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <cover.1660839809.git.william.gray@linaro.org> <CAMRc=Md5Et-T++mZVw+jXnOWQS23o5hUOATYqs6b+pR1zr57Yw@mail.gmail.com>
 <Yw9n+m26FhEyxbNs@ishi>
In-Reply-To: <Yw9n+m26FhEyxbNs@ishi>
From:   Bartosz Golaszewski <brgl@bgdev.pl>
Date:   Wed, 31 Aug 2022 16:00:27 +0200
Message-ID: <CAMRc=MeDZz9uK6o4dzL8YqvquepCeM6ZeL+2K0PLZYp50x-Wgg@mail.gmail.com>
Subject: Re: [PATCH 0/6] isa: Ensure number of irq matches number of base
To:     William Breathitt Gray <william.gray@linaro.org>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Aug 31, 2022 at 3:54 PM William Breathitt Gray
<william.gray@linaro.org> wrote:
>
> On Wed, Aug 31, 2022 at 02:35:51PM +0200, Bartosz Golaszewski wrote:
> > On Fri, Aug 19, 2022 at 1:11 AM William Breathitt Gray
> > <william.gray@linaro.org> wrote:
> > >
> > > Several ISA drivers support IRQ and call devm_request_irq() in their
> > > device probe callbacks. These drivers typically provide an "irq" array
> > > module parameter, which matches with the respective "base" array module
> > > parameter, to specify what IRQ lines are used for each device. To reduce
> > > code repetition, a module_isa_driver_with_irq helper macro is introduced
> > > providing a check ensuring that the number of "irq" passed to the module
> > > matches with the respective number of "base". The relevant ISA drivers
> > > are updated accordingly to utilize the new module_isa_driver_with_irq
> > > macro.
> > >
> > > William Breathitt Gray (6):
> > >   isa: Introduce the module_isa_driver_with_irq helper macro
> > >   counter: 104-quad-8: Ensure number of irq matches number of base
> > >   gpio: 104-dio-48e: Ensure number of irq matches number of base
> > >   gpio: 104-idi-48: Ensure number of irq matches number of base
> > >   gpio: 104-idio-16: Ensure number of irq matches number of base
> > >   gpio: ws16c48: Ensure number of irq matches number of base
> > >
> > >  drivers/counter/104-quad-8.c    |  5 ++--
> > >  drivers/gpio/gpio-104-dio-48e.c |  5 ++--
> > >  drivers/gpio/gpio-104-idi-48.c  |  5 ++--
> > >  drivers/gpio/gpio-104-idio-16.c |  5 ++--
> > >  drivers/gpio/gpio-ws16c48.c     |  5 ++--
> > >  include/linux/isa.h             | 52 ++++++++++++++++++++++++++-------
> > >  6 files changed, 57 insertions(+), 20 deletions(-)
> > >
> > >
> > > base-commit: 568035b01cfb107af8d2e4bd2fb9aea22cf5b868
> > > --
> > > 2.37.2
> > >
> >
> > Looks good to me, do you send your PRs directly to Linus? Do you want
> > me to take this through the GPIO tree?
> >
> > Bart
>
> Hi Bart,
>
> Would you take this through the GPIO tree? I'm planning on submitting
> some more patches later for these GPIO drivers so it will be convenient
> to keep all these changes within the same tree.
>
> Thanks,
>
> William Breathitt Gray

Sure, just leave your Acks on the first two patches.

Bart