Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp569951rwe; Wed, 31 Aug 2022 07:28:38 -0700 (PDT) X-Google-Smtp-Source: AA6agR7C/SEUy7GiZVbQahPWnM18ZApOCCXaVYUjhLE9UVCfai0U0ksLjihYwvNyF7SjQecvQBh0 X-Received: by 2002:aa7:9982:0:b0:538:5451:c05d with SMTP id k2-20020aa79982000000b005385451c05dmr12895451pfh.63.1661956118242; Wed, 31 Aug 2022 07:28:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661956118; cv=none; d=google.com; s=arc-20160816; b=kc427hR+ZrB87uYcxdCSzDqp5ZWDROd9NvYR7ESoPmNmV5mT4Bn5rOUSfXBf9ko8Nq qBx1+jVUOElrlAqZch59nBDEUV/+n/f1GmFUI+o5ayg/gZHXh+Af70xOEi3xdwZDSeYH A34D3qlh1iEdnWfIInLib34jPokkA/65qvKtEkodnGXrx2DK8wf5Ly9UukiSqyeEo2lE XrrLQXxPazTmfcFHDo85/4ZQ+EBtdORCtT82CYqauJehvAXGELlKcG/juMfQgBYyXIYk NyTZgnggc5F9yZPhtA6vZ1ksgU4plSnBbtlax2kSzGZuFtjFlcOHLtGRfLLx2zNvjhR9 7JCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7Y64+ITKD3t7WxyXsYjghMjwDYMJbKCBeS7pYX8P4GQ=; b=DjiWRg0NfeIbMyrWUYBhCNfYEQG8HUyl3kzJWVZeQP9RXZlJoUxr8oR/H6KV4StKEX HV9hyyABi1ReAwfykK8nu46M165/2VYzgmWXGhpjTX3dK22X+W54Msg5blEoefcB7uX+ BjzxJbUcj5afDXAFKI20XTOo0YzWWq6TiUfkxvl1hB5SR8WxcAeFvT5J/G27dEbVE6pq xl0Z5bACaogBd7Ms/ec7xEQqkeOw8nwYosKor4FLCNZarVUB08cR9ZaN6DeS0rU+GerP dlDkN24XQKeJrV+y9opnwbd5qnOZG96uJlgLL0FSa0Xw39gNBq0rYyQWS1uQKaWvFuKu zlDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b=nlv6dP76; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v3-20020a63bf03000000b0041d7381f7f7si4730440pgf.673.2022.08.31.07.28.24; Wed, 31 Aug 2022 07:28:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@axis.com header.s=axis-central1 header.b=nlv6dP76; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=axis.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232016AbiHaOTY (ORCPT + 99 others); Wed, 31 Aug 2022 10:19:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231786AbiHaOTW (ORCPT ); Wed, 31 Aug 2022 10:19:22 -0400 Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 24F1F5F84; Wed, 31 Aug 2022 07:19:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; q=dns/txt; s=axis-central1; t=1661955561; x=1693491561; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7Y64+ITKD3t7WxyXsYjghMjwDYMJbKCBeS7pYX8P4GQ=; b=nlv6dP767aV2n/y08ZV5WUrqMvidwVB2x+LqhgfsNUG73C95qZ3irOqT Gp7S7SAKhsh21yvV4oLfh8X0pVsGZD3jwbuxPCyMfIDPawzK7YrkJUkbq KlE1obt+PfGuwzGDGomKLAd0dWxzmVUIMgEQ/Lvk05+Pzs9bojNeqQ9jG hL/aBqcLq6+uNJl1MV6Lwu6oAEb2r1/xcnahUfcwa/l1d9z/mnLSsCyUC UiyFIqXhFRfP12ZTavcO/6uovXPqWvihzuK1A2YS2rb6IWDl+JptY3ldD 1e8dXchcPvsIvBDnDo4UuoPhFzkO6wJp048hgCp9GS1JzBxx9+EztFrhY g==; Date: Wed, 31 Aug 2022 16:19:19 +0200 From: Vincent Whitchurch To: Andy Shevchenko CC: Jonathan Cameron , kernel , Lars-Peter Clausen , linux-iio , Linux Kernel Mailing List Subject: Re: [PATCH v2 1/5] iio: adc: mcp320x: use callbacks for RX conversion Message-ID: References: <20220831100506.3368103-1-vincent.whitchurch@axis.com> <20220831100506.3368103-2-vincent.whitchurch@axis.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2022 at 02:40:49PM +0200, Andy Shevchenko wrote: > On Wed, Aug 31, 2022 at 1:05 PM Vincent Whitchurch > wrote: > > Replace the device_index switch with callbacks from the chip_info > > structure, so that the latter has all the information needed to handle > > the variants. > > Below are for the further patches, as I see the original code has the > same disadvantages. Right, these comments are in the original code that is either being just being moved or that even just happens to be in the context of the diff. Just to clarify, do you mean by "further patches" that you expect patches to fix these comments to be added to this series which adds triggered buffer support?