Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 Aug 2022 11:10:10 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Baolu Lu <baolu.lu@linux.intel.com>
Cc:     Joerg Roedel <joro@8bytes.org>,
        Christoph Hellwig <hch@infradead.org>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Kevin Tian <kevin.tian@intel.com>,
        Ashok Raj <ashok.raj@intel.com>, Will Deacon <will@kernel.org>,
        Robin Murphy <robin.murphy@arm.com>,
        Jean-Philippe Brucker <jean-philippe@linaro.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Fenghua Yu <fenghua.yu@intel.com>,
        Vinod Koul <vkoul@kernel.org>,
        Eric Auger <eric.auger@redhat.com>,
        Liu Yi L <yi.l.liu@intel.com>,
        Jacob jun Pan <jacob.jun.pan@intel.com>,
        Zhangfei Gao <zhangfei.gao@linaro.org>,
        Zhu Tony <tony.zhu@intel.com>, iommu@lists.linux.dev,
        linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v12 07/17] iommu: Try to allocate blocking domain when
 probing device
Message-ID: <Yw9rwktDY9Uca/cv@nvidia.com>
References: <20220826121141.50743-1-baolu.lu@linux.intel.com>
 <20220826121141.50743-8-baolu.lu@linux.intel.com>
 <YwjeL2SVmdRpoWb6@nvidia.com>
 <316f6575-59ea-08e3-aaaf-bc1e4f42a574@linux.intel.com>
 <Ywz3A3tHEzY+Sf7b@nvidia.com>
 <c7d71936-ea06-3a71-d13a-cedd108413b5@linux.intel.com>
 <Yw4Qzif8W53ykR6K@nvidia.com>
 <c46ec383-bd51-1d78-ff81-0bee064ce1cb@linux.intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c46ec383-bd51-1d78-ff81-0bee064ce1cb@linux.intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?EmAxjWegNWsZ+LR6yNfs74sNkVLrKo4XLK8+le154RPcI+uNOMqqAkQ75Ekv?=
 =?us-ascii?Q?CRDN2ih+ef5bRYQWb+3VobW9guBJYU8peYXp7/cYhI0qtm+yQTAmYnGH+eSf?=
 =?us-ascii?Q?UGy3gAi07f2Zfh89Iqif58K07Zkx0xKlKns+oFexUeQbFRahbMfi1Xed0ICJ?=
 =?us-ascii?Q?AzIBZKbd+OENSnXAfzZuqjQZHXDaHCJ1pLrVc7rS1dZfpMP73RWEJ1qCLEnl?=
 =?us-ascii?Q?RIJn4tynyBQ2hBmCjtiIs6DohHbE4C+62a5L0Zw2/IT0Wbc2EbgujyCZKCpm?=
 =?us-ascii?Q?/RVKTUOp7GOj0JMZ+/7Yc1Q+fVO8AUJzPviwULccoobkXEHFz6ItBm8SD2Xi?=
 =?us-ascii?Q?6b+AfQEckGuG7HjkJiE1VF9Y1vkbgpMWgGaDrco+agJ29cp4FO6X6NGA3/Qx?=
 =?us-ascii?Q?ZDf6E5079iKixskF4pyn5b5M+1xpFRrWIwU08t9t+pYBm7FJ0l6EvtPqFyAw?=
 =?us-ascii?Q?oeEcTS8qK9K10PGs/OUYVKIDJrTh0M4UKiE2oUEcsr9tifOaBsNKlgaT6mx8?=
 =?us-ascii?Q?udmZLfwLqMlTayEu/i/VLKrAIhea4TIN+V9mQdw/QZxMm/+rOI6ZltA7o5F3?=
 =?us-ascii?Q?NqIcEoD0bu5qalVrcRobWzIUjetqQMR6yIK8BWTMjpe/dKg0F2jnFspFRr1w?=
 =?us-ascii?Q?p4jOwtzxactVTXyYyPR/k46Krgbm/DSqZIA4tLrNjJfdcfsy90KKYb69Os0f?=
 =?us-ascii?Q?n/3uLa8gKUSeROyiY4NA5XDGhIZ2EX86b9+MEjNzr26Ag/dSc+GiOIc0wyvB?=
 =?us-ascii?Q?nYDfUaJPFpF8FXmcP9LH7ZloP+EOxwVIndtSTHxHRHIbT9Cy28W4bIAnYNSj?=
 =?us-ascii?Q?tXYWalAaU1pyV/0Ipi6nMlW7oXvY8OWrr/j8Ezp63wyVA/yHXMtbpoROEzH7?=
 =?us-ascii?Q?o7G0WkRno2pTZoEJlsf4wyVsV4RdqVuREQKV6iKEdpo3zXg/Mj3kd5GzpYlz?=
 =?us-ascii?Q?jYIRx6Y8AgX5mqgzM7hL2hp27gJvnxg2BPSHO5uNgBQUQIMqabgUZYkORyZb?=
 =?us-ascii?Q?dZSkYzZDaQkgwqo/fRfpP0Wf2G7lgq8haCQOz6lKpUPgFw75i3PnUOlSUDNe?=
 =?us-ascii?Q?Z0DuSLmbTc43SKBiJ3Z66mURtRvGBeScQTrGZQbfgxTrsYL/7IdNhD2Je9bQ?=
 =?us-ascii?Q?MWXPlDgcmWBphsMN1OSRz9/XVrqfRDiM+z/SJTKMPF7zx8zsXPn6ySE6IIBd?=
 =?us-ascii?Q?fkX4OGv6QfpNuaBa6wyTZHwrn0DPWqD9I0YgT0QWJZgdsIAwP7zlVEee7uuH?=
 =?us-ascii?Q?jm940ycEjYtnZMynzlktQkPtsanbWncZBt3oyHDpLctU+RnBv+EbmGj/pH/9?=
 =?us-ascii?Q?m01NNa1Lu30tfRcBehJBudfQW4LZBDlOHtv/mVJWHADTs7st3Ob1ID1rQ37H?=
 =?us-ascii?Q?4vz3NuZpJcpuziA8qeLeWDXKmMGirvYvSZ45m4Z1u+gvo7xLHn3o8ezR+lQD?=
 =?us-ascii?Q?wG4GdmP9u4R6JNpasWsBXjrMvtJ2zAlUBRJwCoQ+1g3xL9wOe/5uj2dlIKi/?=
 =?us-ascii?Q?nIQPCwUm/mnxbyGv1lRtuUt//0bOrT8N75frx17Jn9LVPIGKcBYlHUaqbwmN?=
 =?us-ascii?Q?rIWpQCm81YKFtozYaP2JfqlpddUUUa6tlsHWXTEy?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 928fd401-4bab-4b21-be83-08da8b5a8473
X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4181.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 14:10:11.3247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: OCaXlfeQkgZNlA7F1WCSCeEkfWaI2UHpwMCVQUHIIbjCkNjQ9kd556N6Qj2guqLg
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5956
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Aug 31, 2022 at 09:49:44AM +0800, Baolu Lu wrote:
> > Maybe all of this is just the good reason to go to a simple
> > device->ops->remove_dev_pasid() callback and forget about blocking
> > domain here.
> 
> Do you mean rolling back to what we did in v10?

Yeah, but it shouldn't be a domain_op, removing a pasid is a device op

Just 

remove_dev_pasid(struct device *dev, ioasid_t pasid)

Jason