Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp570450rwe; Wed, 31 Aug 2022 07:29:11 -0700 (PDT) X-Google-Smtp-Source: AA6agR57M4v7N7osrDjEPsh2J0kB3uNmqZMly6eDO8cK1uWWX4fzYs6rxRElrNOJFRPaQmyKuOdV X-Received: by 2002:a63:cc42:0:b0:41d:c915:ffd with SMTP id q2-20020a63cc42000000b0041dc9150ffdmr21829030pgi.161.1661956151534; Wed, 31 Aug 2022 07:29:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661956151; cv=none; d=google.com; s=arc-20160816; b=f5KSWUkeBznZLr1idF+Jpxm3snbxwznJQSCxzQkutZFAkUM8np5arriP+uux2T9ty8 7vvbYCAEATp8pRQaOJ/D7Aai4o5zb9cSbs6/X5Fszb6A4m1DxgeXhtdmdzE/ES1SEWXV Sh4DLzyWvT77F3J00S88q6aZSgReuLdAZABqARGWixr04fqunw2fhYMY94UkpigKRO/q KAC8+AArGyKf6vSQVZEbG0xZyen+qXpQoUEPh7/7xHlOfi/Ygen2E8/tVKqeV9qPgelL diQ7jfUoPDKK/a1aiLTZeHV041nrAOOJ9Ov6h2XJzOFIzaCN/nj7zJoWaDEXiUSO3rfe MkNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wikAF/ChufF81N+VGucCJPfq5A9fc4dHilwLemyS3Go=; b=S8FJgAGhmRWrvoq8IPSvab/rjryRMZrCjloHV1xXARwY0M+Aj+Mr7FNpFCC9dODwb+ jlYoPvhUQvFXvQRptNBq7bMZ/d1kSZM5eo4eUdrZxosFkc6LZQpxWB3b8e6FZq84A/zS Vfuw3bgCLLSJnFNm1e7esx81qAPJ8zT5ZqPBiKU84/tOlTwOJU12E/XruZOonuYUFbTj tX1cUYYC/6twxEhkP9XdszWpBIL9qMsaMXjy3bCQdZnHMjzJLb3i70VAQXpFFC+gH9Rz 4+9b1ATcVF2qIBiVu5ARmG2/z/u73EFONYnhQkzsiitqX/fO0YlYyWqGrDIi97d3WO+V X1fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c3Wqs090; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nl18-20020a17090b385200b001fac2623306si2297576pjb.95.2022.08.31.07.29.00; Wed, 31 Aug 2022 07:29:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=c3Wqs090; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231290AbiHaOCX (ORCPT + 99 others); Wed, 31 Aug 2022 10:02:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41732 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231124AbiHaOCS (ORCPT ); Wed, 31 Aug 2022 10:02:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6E01ED344C for ; Wed, 31 Aug 2022 07:02:17 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D89F1B820CD for ; Wed, 31 Aug 2022 14:02:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1A993C433D6; Wed, 31 Aug 2022 14:02:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1661954534; bh=+CiahQqp0QDkyoEIGkSIDAtd7RUWC0BU9wfR/DtbyCI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=c3Wqs090h8DCP1J6INaE6ZQehdNFJdKBKUBOuGtnpHWfgQFg2i4Yzxt/Bl83CynWH Kk4dhKwZQPW8K8emNRMiU7uBnJRHleWUjMaVaCqSv3dzOSFnddz5+8+ns1Rw1czO9L GDCMklg7hfJAVxM9DelM16W89CRFUOy6td/9a2l0= Date: Wed, 31 Aug 2022 16:02:11 +0200 From: Greg KH To: Xuezhi Zhang Cc: abbotti@mev.co.uk, hsweeten@visionengravers.com, zhangxuezhi1@coolpad.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] comedi: sysfs: convert sysfs snprintf to sysfs_emit Message-ID: References: <20220831125520.239055-1-zhangxuezhi3@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220831125520.239055-1-zhangxuezhi3@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2022 at 08:55:20PM +0800, Xuezhi Zhang wrote: > From: zhangxuezhi1 > > Fix up all sysfs show entries to use sysfs_emit This says "what", but not "why". Please read the kernel documentation for how to write a good changelog text. > > Signed-off-by: Xuezhi Zhang > --- > v2: use a proper name for the Signed-off-by line. Does not match the From: line :( thanks, greg k-h