Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp574344rwe; Wed, 31 Aug 2022 07:32:50 -0700 (PDT) X-Google-Smtp-Source: AA6agR5r5pwhv6lZR4/Mq9A3JvdHMsFtqZQM2ReDogEkTdYwx3d6QdZLovi8yHDmnlAEGa7IfszW X-Received: by 2002:a63:3509:0:b0:42b:15a6:8267 with SMTP id c9-20020a633509000000b0042b15a68267mr22407501pga.570.1661956370184; Wed, 31 Aug 2022 07:32:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661956370; cv=none; d=google.com; s=arc-20160816; b=TDhK5UQkVFxwUdAqF2n/trYabkx+iD++nD1oYy1/nzqDmhlTnsaciamDdWjLnPX/0M mrqzPPttIFqVT7gh1Qszaaslp7N8gDgjw6etqlbBii82SJzrnedEB21Y5Cj13alBLV1s Xy7j5jelUa/X6XC5h1Fy6yasNAyiV4pyg24mUw/um5M1s4XdOSi5/N68d656RMQGSQRg Okm/rGIkrMSazlPsEO7gDdlTbnZfBb5NPBo7tEAS6pKU7nwmyclP4Td/jnHzTm+YutHc ESFgIUT0lrsF6XIhzBBdTurDmU1llOi4D19CVBUAvSFIaOUAmppOXeqPxgRFfZ2w1Cu9 C/mA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:date:content-id:mime-version:subject :cc:to:references:in-reply-to:from:organization:dkim-signature; bh=Xm51xcub1wuRQLMM4F6btrUxwFJHZ9ruPTJ/iTp6tbc=; b=W9JPr53bvKmpxHuw5/fYORKatWpiJs0eUixpxZrjuGUyCCgfS0L7MBfOCZkriGzsiB Znlc5AdJ89xbQSlM+ePR9d3YMnzaefviMyUETxx3FKU/eoCe1OpaS/jqeJ9vea8kWyt0 kdNftwsCqRUzJycmsWwq8Ytp4s4jOjUj848/0YBiXWRAjaT0GLmbFkTSybWJzJ9EQ7KZ 3fCUbbzCJxE3QFx4Dbm4wpxCodQkrr4aEurJdpt6ed3r3eH1Y/c7aHtpPi7H5mLcuhww Y1RvDh+DBP6/616uce6pMfL7bwVWnwqbTYW9Om5hM2+1qCOP4QU9vlDYAC/ESL/sewmT 8Rrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=J5MOJR2g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nl18-20020a17090b385200b001fac2623306si2297576pjb.95.2022.08.31.07.32.32; Wed, 31 Aug 2022 07:32:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=J5MOJR2g; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231939AbiHaNwb (ORCPT + 99 others); Wed, 31 Aug 2022 09:52:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231739AbiHaNw1 (ORCPT ); Wed, 31 Aug 2022 09:52:27 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 766C7D4F75 for ; Wed, 31 Aug 2022 06:52:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1661953944; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Xm51xcub1wuRQLMM4F6btrUxwFJHZ9ruPTJ/iTp6tbc=; b=J5MOJR2gUFqHZfsH9qpjVj4FKsHaa7lIos3ike7BZRBxnNHS2jNQiZQ9Eju9aKUIa1ILQx SHXAfUMDMA9XOJAA8oAlCjqudY5vphe7DXdGuFpBDRlKCkAWqboYNqEfLBo1c+ZjiIYCiR kL7pcjiI6i2WllQvr4j07APxcXM/y3s= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-496-vb5iahavMR6409xh4Jft7w-1; Wed, 31 Aug 2022 09:52:21 -0400 X-MC-Unique: vb5iahavMR6409xh4Jft7w-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C20561C20AEC; Wed, 31 Aug 2022 13:52:20 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.72]) by smtp.corp.redhat.com (Postfix) with ESMTP id B31BA2026D4C; Wed, 31 Aug 2022 13:52:19 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20220826043706.GC2071@kadam> References: <20220826043706.GC2071@kadam> <20220826023515.3437469-1-sunke32@huawei.com> To: Dan Carpenter Cc: dhowells@redhat.com, Sun Ke , linux-cachefs@redhat.com, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-fsdevel@vger.kernel.org, jefflexu@linux.alibaba.com, hsiangkao@linux.alibaba.com Subject: Re: [PATCH v4] cachefiles: fix error return code in cachefiles_ondemand_copen() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1544478.1661953939.1@warthog.procyon.org.uk> Date: Wed, 31 Aug 2022 14:52:19 +0100 Message-ID: <1544479.1661953939@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dan Carpenter wrote: > Thanks! Can I put that down as a Reviewed-by? David