Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1c27b6b3-2d3c-d750-58ad-bd35ede421f6@intel.com>
Date:   Wed, 31 Aug 2022 18:15:32 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH v2 1/2] libfs: Introduce tokenize_user_input()
To:     Matthew Wilcox <willy@infradead.org>
CC:     <alsa-devel@alsa-project.org>, <broonie@kernel.org>,
        <tiwai@suse.com>, <perex@perex.cz>,
        <amadeuszx.slawinski@linux.intel.com>,
        <pierre-louis.bossart@linux.intel.com>, <hdegoede@redhat.com>,
        <lgirdwood@gmail.com>, <kai.vehmanen@linux.intel.com>,
        <peter.ujfalusi@linux.intel.com>,
        <ranjani.sridharan@linux.intel.com>,
        <yung-chuan.liao@linux.intel.com>, <viro@zeniv.linux.org.uk>,
        <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <andy.shevchenko@gmail.com>
References: <20220825164833.3923454-1-cezary.rojewski@intel.com>
 <20220825164833.3923454-2-cezary.rojewski@intel.com>
 <Yw5X379ct1PK6wZO@casper.infradead.org>
Content-Language: en-US
From:   Cezary Rojewski <cezary.rojewski@intel.com>
In-Reply-To: <Yw5X379ct1PK6wZO@casper.infradead.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WU9IeEhqT2hNTGdtOVVBOW44SDhBR1FmRlFoUXltQWpOdVBrV1EzTG45NWxy?=
 =?utf-8?B?NUNGTzF0NktETmluZEErcytBZUREeVFRODVWMFRTNEVxMHExN0k1MFdjRy9I?=
 =?utf-8?B?Z0hFNWc2NmZ3NWs3QWJ6YVp3V1ozN3ZZQk93N2pwNDJWSXFESkFpUEN2OEgx?=
 =?utf-8?B?ODkydlc0b21UcE9yZWczaCtiMU5hdS9IZVBmbXhUYVVueVl4aFhITFEwcmRF?=
 =?utf-8?B?Z3VWSmVOYStNUWNLMmZWS3EvUjdMMDB3UmloY0orVkloS3Vkc2hOdlFkWVkr?=
 =?utf-8?B?SzQ3ZmlGOWJsejRITFB6K2MvbDI1TzdwTUhUU1Q5MHFFWmE5YjlITVczLy9W?=
 =?utf-8?B?MWc0SHpWSmN4RDJVSnUzekRlcFVTazZxR21jTnErelFSdWsyMXFlUWh6N1Jm?=
 =?utf-8?B?R1A1Y3VFeDdoQktISHVyK1hJRWd5WTJ4MmVMdE9rZVJiT1VnQVhRVVFabnBU?=
 =?utf-8?B?WmRsRjB2RllrMGtOUnlzZEVUTll2V3N4YzMxS054UDZ4TTJkT0RuSyt4eGJV?=
 =?utf-8?B?bUpUR2FvTWxuWS80dEMremM4VGdiWG04blJ4eUw5SFRIUi9BcGJDSTlIbW1z?=
 =?utf-8?B?dHJvcy9abkZvUFd1eFRUYkpUVndjaUo4WFVmWHFtSXlGSkkxYjYzNVhLbTZ6?=
 =?utf-8?B?ZWJUUUk0Y045bkFIZEh5QzlFTFU0Vi9Zakp3LzFhLzhjekVyaUx5ZGU4UDN6?=
 =?utf-8?B?ZTh5cytuWXo5UWY2QVhwWHBXUTJrRWgvWmtCMHpLQmt2VGFIMGpOaW53eVpR?=
 =?utf-8?B?R1IyU3JPRFV3VFVVYXdRVHBaZ3REM2hydGoyYmlZMTQvOGJ3amtIWlA5c2Fr?=
 =?utf-8?B?dFFUTjJXWGNCMmxWcFowYVFKWFJBakFpRVlpTnFiekptbEN2eUZOT0NpMHdV?=
 =?utf-8?B?MU9GdlUrZU1WU1VjVTZ0M041dTE2Y0pBdnZMU25JSnk4bUJnN3Njck9WTm00?=
 =?utf-8?B?SUQ5d3p5MlJ6YzVqaHhRQkd3WThpOHUwMjdicG5Va0QzM2E1cm0zNitveXJu?=
 =?utf-8?B?R3dkMjlmY3ZaK0p4VTdTQlhvSW1uRGd6K0FnUGhza3Q2Nk54cWZXSll6RGxT?=
 =?utf-8?B?Smd2M3NWcUF4KzlFdlYvTEZ1bXUvU2RaZ0hqOENKZ1k3cW9JWU40aXVXS3I5?=
 =?utf-8?B?VHc4RkJoY2xobFFyZXRDT2ZpZXZERTZvaERwTDVuVmUvQjJiV2FhUjM5SUVF?=
 =?utf-8?B?VjBRODJGcStMOU1qS1QwVDd4R21KWXhaZWhON2loSnFzQ3BQYVlIS1Bsd0h0?=
 =?utf-8?B?Z2dNY0g5TEZQNWREVmlxYlJrNFU1NmczbmdERk9jTzVvVEZYTjVkNGpHR05V?=
 =?utf-8?B?eStwb2hFdUpxODVOM0E4U1dweFpZNnhUTGNvenF3Vi9FS0IwOC80YjhUYUV4?=
 =?utf-8?B?cW5wZFBndEFzbWQyRHJEUHhwR2hiZEgrMDVXcDRpR3B4c2syckNMVnNtc3lW?=
 =?utf-8?B?RlBiYTBqWHZvb0d0dVV5RnNYbXU3NGsrRDBtVlBScnZpc0pTODRPT29YcFlP?=
 =?utf-8?B?V3BkbjRoQVgwSzhsREtHWUFoclpjZDk5N3c5M1czbkdnMHlwbldEYXJhT1Zw?=
 =?utf-8?B?dHhLWEk4ZVNKcjdmenVsd2pja1VlamZzaUFVTkJkY0pwc0s3RElEa3d6Wmd2?=
 =?utf-8?B?UXk1bUxqODY4aDVYMFBXS1l4aUpHeHFCRmtiZmIvMFo2YldEUWxkU1RVaTcx?=
 =?utf-8?B?eXVzUmJ3ZDVQcWhNL0xsQWdoU0ZweHVhNGlGQ0g4bTNmVDV1UVBSc0hZbmoy?=
 =?utf-8?B?cjNRZnBhWEZXSEw2WTRFT3lLbG9JeURLYmtLT2dNbkxqOEN5YUhsbnlXTzhq?=
 =?utf-8?B?NUQ4RXVieGd2NXlaRVJJalpjR2FDUkZkT01MMmR6MlNKVlFma2hESHdHSXFH?=
 =?utf-8?B?UThBWXR3N0NFU1RUSWNpS21oTDU2M3hGVnhGRWhmOHg3Q1dBenQzM0JkUTZw?=
 =?utf-8?B?MUhLSUxKbzh4MTk2VGRjVTlzeXAxREpMVGh6OHRJcXZSTEhkN2JsbWgzcjgv?=
 =?utf-8?B?dFd3Vnk4ajhnSkJmbHF1bnJqcHdQN284M1pJUWladDBRQnhHZjQ2dFNJUk5j?=
 =?utf-8?B?b1NUUjJYbVN0TGEzc2Y0MXlIRVJxSkRaV3N4UHYrK1B4VTZielg5Y2FHb09r?=
 =?utf-8?B?SEZacUkvcFRva0RPZmNlVHFZVlFwVHlhajlDY1VKQmNFYnhicGpKY3A1dE9y?=
 =?utf-8?B?TkE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: dd0e44cf-7908-444f-c5aa-08da8b6c0dff
X-MS-Exchange-CrossTenant-AuthSource: DS0PR11MB6375.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 16:15:43.6283
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BNTJekdiYWyGgdGV+sfELV5LbWszbMt/yszTORW8qLJdCwbDnIS4EDU41Z6Vh0mwuJxful4mC9HljtJ8MfBK/XLvL3vRCWNE4Anf17KJ1Sk=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3212
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2022-08-30 8:33 PM, Matthew Wilcox wrote:
> On Thu, Aug 25, 2022 at 06:48:32PM +0200, Cezary Rojewski wrote:
>> Add new helper function to allow for splitting specified user string
>> into a sequence of integers. Internally it makes use of get_options() so
>> the returned sequence contains the integers extracted plus an additional
>> element that begins the sequence and specifies the integers count.
>>
>> Suggested-by: Andy Shevchenko <andy.shevchenko@gmail.com>
>> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
>> ---
>>   fs/libfs.c         | 45 +++++++++++++++++++++++++++++++++++++++++++++
>>   include/linux/fs.h |  1 +
> 
> This really has nothing to do with filesystems.  Surely
> string_helpers.[ch] is the appropriate place for this code?
> Also get_options() should probably move its prototype from kernel.h to
> string_helpers.h.


Hello Matthew,

Thanks for your input. The initial version of the change was located in 
the string_helpers.[ch] just like you propose and I have no problem 
moving it back again. string_helpers are devoid of __user content though 
and that's why in v2 it's part of libfs instead.

I'll give a day or two to see if there are other suggestions and then 
send v3 relocating the implementation.


Regards,
Czarek