Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756766AbXFONdJ (ORCPT ); Fri, 15 Jun 2007 09:33:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754848AbXFONcq (ORCPT ); Fri, 15 Jun 2007 09:32:46 -0400 Received: from vervifontaine.sonytel.be ([80.88.33.193]:50528 "EHLO vervifontaine.sonycom.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1754566AbXFONcn (ORCPT ); Fri, 15 Jun 2007 09:32:43 -0400 Date: Fri, 15 Jun 2007 15:32:41 +0200 (CEST) From: Geert Uytterhoeven To: Benjamin Herrenschmidt cc: Paul Mackerras , linuxppc-dev@ozlabs.org, Jens Axboe , "James E.J. Bottomley" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [patch 1/6] ps3: Preallocate bootmem memory for the PS3 FLASH ROM storage driver In-Reply-To: <1181914039.26853.80.camel@localhost.localdomain> Message-ID: References: <20070615113919.142332000@pademelon.sonytel.be> <20070615120848.002575000@pademelon.sonytel.be> <1181914039.26853.80.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-584337861-1031989590-1181914361=:14899" Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1868 Lines: 47 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---584337861-1031989590-1181914361=:14899 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: 8BIT On Fri, 15 Jun 2007, Benjamin Herrenschmidt wrote: > On Fri, 2007-06-15 at 13:39 +0200, Geert Uytterhoeven wrote: > > plain text document attachment (ps3-stable) > > Preallocate 256 KiB of bootmem memory for the PS3 FLASH ROM storage driver. > > I still very much dislike the #ifdef xxx_MODULE in main kernel code. Me too, but there's no other reliable way to allocate it after boot up... > At the end of the day, is it realistic to ever use a PS3 without the > storage driver ? I would suggest just allocating those unconditionally. If you don't plan to (a) boot into GameOS or (b) update the kboot kernel, then the answer is: yes, you can live without the FLASH ROM driver, and save one promille of RAM. With kind regards, Geert Uytterhoeven Software Architect Sony Network and Software Technology Center Europe The Corporate Village · Da Vincilaan 7-D1 · B-1935 Zaventem · Belgium Phone: +32 (0)2 700 8453 Fax: +32 (0)2 700 8622 E-mail: Geert.Uytterhoeven@sonycom.com Internet: http://www.sony-europe.com/ Sony Network and Software Technology Center Europe A division of Sony Service Centre (Europe) N.V. Registered office: Technologielaan 7 · B-1840 Londerzeel · Belgium VAT BE 0413.825.160 · RPR Brussels Fortis Bank Zaventem · Swift GEBABEBB08A · IBAN BE39001382358619 ---584337861-1031989590-1181914361=:14899-- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/