Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220831124041.219925-1-jolsa@kernel.org>
In-Reply-To: <20220831124041.219925-1-jolsa@kernel.org>
From:   Ian Rogers <irogers@google.com>
Date:   Wed, 31 Aug 2022 09:02:46 -0700
Message-ID: <CAP-5=fX-=ph8g3VKbQXSRT8SiOZ3XqQLd3T9-ZTNZ5L+ye5L-A@mail.gmail.com>
Subject: Re: [PATCH] perf script: Skip dummy event attr check
To:     Jiri Olsa <jolsa@kernel.org>
Cc:     Arnaldo Carvalho de Melo <acme@kernel.org>,
        Hongtao Yu <hoy@fb.com>, Namhyung Kim <namhyung@kernel.org>,
        lkml <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        linux-perf-users@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Aug 31, 2022 at 5:40 AM Jiri Olsa <jolsa@kernel.org> wrote:
>
> Hongtao Yu reported problem when displaying uregs in perf script
> for system wide perf.data:
>
>   # perf script -F uregs | head -10
>   Samples for 'dummy:HG' event do not have UREGS attribute set. Cannot print 'uregs' field.
>
> The problem is the extra dummy event added for system wide,
> which does not have proper sample_type setup.
>
> Skipping attr check completely for dummy event as suggested
> by Namhyung, because it does not have any samples anyway.
>
> Reported-by: Hongtao Yu <hoy@fb.com>
> Suggested-by: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>

Acked-by: Ian Rogers <irogers@google.com>

Thanks,
Ian

> ---
>  tools/perf/builtin-script.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 13580a9c50b8..304d234d8e84 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -566,6 +566,8 @@ static struct evsel *find_first_output_type(struct evlist *evlist,
>         struct evsel *evsel;
>
>         evlist__for_each_entry(evlist, evsel) {
> +               if (evsel__is_dummy_event(evsel))
> +                       continue;
>                 if (output_type(evsel->core.attr.type) == (int)type)
>                         return evsel;
>         }
> --
> 2.37.2
>