Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 Aug 2022 17:36:26 +0100
From:   Mark Brown <broonie@kernel.org>
To:     Steve Lee <steve.lee.analog@gmail.com>
Cc:     lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        krzk@kernel.org, ryans.lee@analog.com
Subject: Re: [PATCH] ASoC: max98390: Remove unnecessary amp on/off conrtol
Message-ID: <Yw+OCnOgYUOWdIEx@sirena.org.uk>
References: <20220826023504.6183-1-steve.lee.analog@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="52dw3Ph+pKqVOnNd"
Content-Disposition: inline
In-Reply-To: <20220826023504.6183-1-steve.lee.analog@gmail.com>
Precedence: bulk


--52dw3Ph+pKqVOnNd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Aug 26, 2022 at 11:35:04AM +0900, Steve Lee wrote:

>  The Amp is already control in userspace before trigger calibrate function.
> Remove unnecessary control in calibrate function.

I can't see anything which ensures that this is the case?  Should there
be a check which returns an error if the output is not enabled, or
should the function check the current state and preserve it at the end?
I can see that this would fix problems with it being disabled when
callibrating.

--52dw3Ph+pKqVOnNd
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmMPjgoACgkQJNaLcl1U
h9C4ZAgAhg2+SIaK5IfZY+hTm2eRhD88hpYBfBw5lrXth3VHn8iRgUorzGgiqSle
VbE+t7hq4C4q11alwzR+ZdtZgfuHBb7Y3w8Xx+Dk0SxJQ9bptDT4/nb6+Y9Uogwn
Fd07GAC8YzMUZnIjOK4VzL70N/iTLSXroGUb3MoMYWwFWnN5VeaR5eZSHa8ntyt/
S62LthzfBXoNaqrrpx+jeXqzEYzOPfQKfNDAXVW2Imj+D00hp5W4zSvDYGofI4qR
zfLUl6afqUqTCp/MHUncBPafhQJ1QBJVRYRTDRyvxdgFSIcBQvsZSJ4wRZhk86ot
90friYxGNtUu2Q/VBaInZN//VEIeLQ==
=yjS4
-----END PGP SIGNATURE-----

--52dw3Ph+pKqVOnNd--