Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 Aug 2022 13:36:39 -0400
From:   Kent Overstreet <kent.overstreet@linux.dev>
To:     Coly Li <colyli@suse.de>
Cc:     linux-kernel@vger.kernel.org, linux-bcache@vger.kernel.org
Subject: Re: [PATCH 2/3] bcache: Convert to lib/time_stats
Message-ID: <20220831173639.sb6bhg5xvn4gbkiu@moria.home.lan>
References: <20220829165344.2958640-1-kent.overstreet@linux.dev>
 <20220829165344.2958640-3-kent.overstreet@linux.dev>
 <14ACCED7-D24D-4AC4-8677-F7F4630A840A@suse.de>
 <20220831165437.l27raas6k5nlqsdg@moria.home.lan>
 <1F91055C-4253-42CD-8A4A-8B8EA2CF1D6E@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1F91055C-4253-42CD-8A4A-8B8EA2CF1D6E@suse.de>
Precedence: bulk

On Thu, Sep 01, 2022 at 01:02:37AM +0800, Coly Li wrote:
> Can I understand that rate = 1/frequency ?  Then frequency 4 is around to rate 0.

Correct, rate = 1/frequency.

> > The quantiles are for the duration, they give you an idea of the statistical
> > distribution, see https://en.wikipedia.org/wiki/Quantile
> 
> I wanted to ask how to read the quantiles line. Does it mean that 1 ns is
> equally divided by 15 segments, and the counter values are for the divided
> 1/15 ns segments?

It is the 15 boundaries between 16 equal segments, yes.

> Quantiles are much humane, standard deviation is scared… Just FYI LOL.

That's valuable feedback then, maybe we'll keep both. The more expensive part of
time stats is just ingesting data points, but we've got a percpu buffer frontend
for that - just doing a bit more moth doesn't cost much.