Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp779581rwe; Wed, 31 Aug 2022 10:49:32 -0700 (PDT) X-Google-Smtp-Source: AA6agR5wV50XWfiJjciXNKZ0w5IzaEQ708+FzEjOzVNW8//MXusFANkrpmVTb9RRLBOZmtxMIpph X-Received: by 2002:aa7:88c8:0:b0:536:926:700f with SMTP id k8-20020aa788c8000000b005360926700fmr27784797pff.72.1661968172189; Wed, 31 Aug 2022 10:49:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661968172; cv=none; d=google.com; s=arc-20160816; b=JByhuIuvfB8QLwBi6mzD+p0J137BXifcChnQvrpiiaq+1tPYoPqUzg3vprzFHDhraL 00AONiovYXsWUe+exMhsMKMM2/gRVwDiuO8C5jVKfXHv8W3CjsqMM1M8i54u+saIV8FR Man1khPkBbXFykTe3zBEiJnRh1+1TwwG8EZvrkntmML5CnXy8wuN4XThIa9cnqMuM0be lazqWxmn+46Ih6/2fNQRqL48u0cPMSn7Eeh2h8igqThK1gQmraweMurM0WLcB+s85VS0 XdBLw+BlSPBCNwuwUx1aYkx4ky/8dtQYaw9wQel0I+gsPr+IZktXlkwVQI8Mc2/Cc8Vr mlKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=6pZREqMeUHCiqYoXfuo6JDSmGSr6yhRev/WHve7gW+U=; b=HMaVnn79/sd0I0z/7Qpvt3F0ndRSA25DeoPfnlHKSnU6k5hRs+iq1e8L9JJr82NmNN G7qLkaXPFiqVNfLYaO/NmzeD9SUm6Z4vl+J7CfYkAyXtq39MDMAsFbUdTxFW4Yfj9Gzf vQxfeWxP7knKKbNsrHPNMvDad3engmwWccoVDunV5oLsxby8gkDnEa3u7Q13XNmDlfpx 0677xflUR459+CQhBNH0v4hvF5ICLm4h+rAd1fiYGuzZx7KLs9nj8ZKB8OIZ/tVYWEql nbji3IQJHvR0/HseMP8UE0op2wazHlqVa5x6pqOHhb50xaSb/DtwI9qdpaWQkCbIt4E7 iAyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aGsnA5+Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x8-20020a17090a164800b001fe300ae60asi1926018pje.54.2022.08.31.10.49.21; Wed, 31 Aug 2022 10:49:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=aGsnA5+Q; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232114AbiHaRmL (ORCPT + 99 others); Wed, 31 Aug 2022 13:42:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231531AbiHaRld (ORCPT ); Wed, 31 Aug 2022 13:41:33 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CF6E81EAE4; Wed, 31 Aug 2022 10:40:50 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A734561B4E; Wed, 31 Aug 2022 17:40:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 079EEC433C1; Wed, 31 Aug 2022 17:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661967649; bh=jzTCmjZs6oRV5vAtJdRT/DcBLCSdXLMxCOdEalCI1qI=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=aGsnA5+QkIomOr8vlRBARUc1AF8099TTw/GMr5zXmULF9QAeKNmPrcQ5AjUMeCjgM 2W/tj9UehXBp6b3lnHgB8VS1bq8THaMSNwyO5ZgxowPW847AR7uZEKHvr+1iPBVP6n hpVoK+VYmSc9CuaI1Uepp0iHoF9tzOeJBIO4EzTzFvTVQcviizrYyKl2nBb4LsjbfR J84KDbXe+CBvcgXt4cB/XvO+MLgZqCNRIaKPW9dsnvWHW4ggNyBHA1rIqQh+54p9c5 SGZ9GhhpnktNgOKWUNqIdr3QlQApH6U+ICyA3XgxZOPBgQsAhWhCGTbKo9T6bsCSaA XBLu4o4+jQiHQ== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <1655004286-11493-8-git-send-email-quic_fenglinw@quicinc.com> References: <1655004286-11493-1-git-send-email-quic_fenglinw@quicinc.com> <1655004286-11493-8-git-send-email-quic_fenglinw@quicinc.com> Subject: Re: [RESEND PATCH v6 07/10] spmi: pmic-arb: block access for invalid PMIC arbiter v5 SPMI writes From: Stephen Boyd Cc: quic_collinsd@quicinc.com, quic_subbaram@quicinc.com, quic_fenglinw@quicinc.com, tglx@linutronix.de, maz@kernel.org, David Collins To: Fenglin Wu , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 31 Aug 2022 10:40:47 -0700 User-Agent: alot/0.10 Message-Id: <20220831174049.079EEC433C1@smtp.kernel.org> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Fenglin Wu (2022-06-11 20:24:43) > From: David Collins >=20 > The system crashes due to an access permission violation when > writing to a PMIC peripheral which is not owned by the current > ee. Add a check for PMIC arbiter version 5 for such invalid > write requests and return an error instead of crashing the > system. >=20 > Signed-off-by: David Collins > Signed-off-by: Fenglin Wu > --- Applied to spmi-next