Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <7c85f675-db1a-eb5c-2575-759d662a0ecd@intel.com>
Date:   Wed, 31 Aug 2022 11:09:02 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH 4/6] selftests/sgx: Add SGX selftest
 augment_via_eaccept_long
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     <linux-sgx@vger.kernel.org>,
        Haitao Huang <haitao.huang@linux.intel.com>,
        Vijay Dhanraj <vijay.dhanraj@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Shuah Khan <shuah@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220830031206.13449-1-jarkko@kernel.org>
 <20220830031206.13449-5-jarkko@kernel.org>
 <bd5285dd-d6dd-8a46-fca9-728db5e2f369@intel.com>
 <Yw7HOIfnaO0IcDiX@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <Yw7HOIfnaO0IcDiX@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?YUFRUWVNSStod3JsMk42dVhiVGQ4S2owbityWE1pVzJWejBmbGpTS3hmU2Nr?=
 =?utf-8?B?K2dxZ3BIWjZ6NjBSVU53WlpBVjhBNFZWNzQ3LzJuUnRWb2pBck45ZnM2blZR?=
 =?utf-8?B?Yk9yMVRZS3JPM1BRb2FDazFMQkE2eFgvemU2Q0EzOHdnU2FXL0IrN2JIcW9t?=
 =?utf-8?B?LzFYZ2Z5blY1NTJXMjJ6M09HN2ZhVjg1aDM2MmxsMm91SmRhMHAwUTkxZC9w?=
 =?utf-8?B?QUVxM2I0TS9jb01oNTE2eUZtbmRLVEgwNUwwZ1d0ZytzcmZWUEZwUC9vZzU5?=
 =?utf-8?B?QlEvYWtiWTVvaDkweE9rUG5vd2ZRcnlmMGJDandlRmt1SGt1RHNwZk9PdEV5?=
 =?utf-8?B?OGhwS0wvQ2lSa0l1bUZRcnI3c0oxaUtwcHhwbTQrYVptaXY3YkxRamVTVU1j?=
 =?utf-8?B?TEhYMXMvM05TYVlsTDFTanUzWTFvMXB6Q3AzQllVMGw3cjkrN3pPeU9zdFBW?=
 =?utf-8?B?R3pzNFhqUk5JOEpxZDk4RUZvcENSRGE2bzQreHdjcEcwengrRkNRNWx0QUJU?=
 =?utf-8?B?dTY3S21PTHRQNDFUeDVwOTMxSUNxR21DenRkWkl1TDV5Uk9YTUt2OGhKM21y?=
 =?utf-8?B?ODFsN0M4Y3VwWWl1WFZmOE1kanVSKzlnendmOWJTdUl0MkhoWUg5Y2NqTUtH?=
 =?utf-8?B?S3pqaFlXUThSVXpyQXZzd3NGVHlFV3JVaW9ZUlJSK3lSbFRiQnpqeVF3TTZu?=
 =?utf-8?B?cWJRSk1OMyt3WWJZUzN0N1Fkd1plRnlLcGEvd01QeGpXMThQQ3A4TXprTXJZ?=
 =?utf-8?B?cWxhMWFYZy9GSzNCK1I0Q1ZvNWNXT3ZmaXk3SkExQTdKd3JIc0ZKallLRkp3?=
 =?utf-8?B?ZTZGdHZ3alljWXhrdFQyZW9NWUF4cC9HMWI2am5pVk5kV20xUHBLWG1RSENm?=
 =?utf-8?B?ZjEzUTROazhVMEZIVW04dlZLYWZCQlZraExhUDFKSy9pQXRuMUMrNTZWQ3ln?=
 =?utf-8?B?QmM0aU02MW9aMFpQUVBYS2REVXVUZ0JIRTFXNHY0TEY0U2hheVhOUXcvYzU1?=
 =?utf-8?B?MWs1NVZieGVUdmN2MU9BR0hYdm5pUTFZVjZvZHFNbEdlNlhYK3NwKzJKdUlY?=
 =?utf-8?B?d3U0UWNreFVzWWlWemU1S0IxaWxPbzdRNlFqbkFYOWdvdDIxSGpvdWVvbGkw?=
 =?utf-8?B?b29JZnF4MXBrZHJHbEd3QjNxMm9MR25ZUy9RdFA5M3hCSzArQ0Vhanl0MWV5?=
 =?utf-8?B?TkE0alkvZER3ZldER2JPSUQzS01mTmRONUw3Q25hb3V1QWZ2UTBUemxGVnZ3?=
 =?utf-8?B?dStNZU50aEF6RUNCYVlqK1lqdmpVVFJRMk0wRit5d1FSWklBaWNlQU9zSlNt?=
 =?utf-8?B?MVpTMTMybXRiTXRBb3Q3Umh3Q25lUUpETmdBeWt4L3BqRWVreEZlUXV0Q0hp?=
 =?utf-8?B?L1VRekFhTVpRb2NEdU9UWXRXZkd6emM5UWEyaXdKbzRqSndDMFpWaCtORVNu?=
 =?utf-8?B?OTA3SnEwVVZVT3BSL3RVcDdyNnU2QjM4TnNFOCtDQWRwZVlOS3QzdEdKcEVu?=
 =?utf-8?B?cURHUm1MNUlkekc0RjcwWXZkWEkrTStNVEZrWmhkWi9rTHJGaDgxMVA3RE9M?=
 =?utf-8?B?SWFXbmcwYTAvNi9EcnZITTJMcTNDaXJRUStJU3duWUgrSGlzM0U3YjBpUUtE?=
 =?utf-8?B?QUMvNGlsOC8vb3NmS1hBMGNnQklXREdWdXdvdG1ldTFJdElSb21POFIrekZi?=
 =?utf-8?B?VGJJQmVTUzBwc09nVGkvRllQbzhKZDdKMU8zL2JzeG5XazhBYitmVFlhSTNn?=
 =?utf-8?B?TlVsekJsSDE5TW5ISXZEMXgxTGJISWhEL2hHb1kwSFN4YlJ5TTJ2NFl6ejBa?=
 =?utf-8?B?UDZlTk5GWUxsRmlGZEwrNnZ3SjRoWnc3Y0VackRXR3BvYkFkODkxSVpzVjAx?=
 =?utf-8?B?VUFRcmRpeDhpNW44Y2YyMFFFM21IR0NXMCtYY2ZMNm9DNGxWVnpja3REMzUy?=
 =?utf-8?B?ci8xdmN2djh2ZFhZblk4U091YnFRSUdpbmIweXVRK2RqdS9NOXVPbG0rU0lM?=
 =?utf-8?B?OEpRNWRIUSt6SkhycU5LRnJKY0lZamJoRTUySEkvbVVjR3ljdHBucGFkTzRF?=
 =?utf-8?B?OWY3UTMxVEFuVzIxb1c5YnNtZVZlQmQydGNERlEyVTM5a0NYS21FRHNsN3FD?=
 =?utf-8?B?REhkczdjMW5IRERIdHp2bkFNeUZuSW5WOG9GbXRxc3hrSFdpUThCTG9HL2Q5?=
 =?utf-8?B?K0E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: d6f8099c-bc7d-492e-6d8c-08da8b7be3c7
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 18:09:04.6332
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ShMc2TqLCQCSJqEW65wjvtj5BgjQ509VXUXssb0LWDpBS38QHVXXaYjsRHNYMrIV7GhAdKObYqkv+d+xdtjcI9KNyRbDP9ebvUiS7fbiv9I=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3146
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 8/30/2022 7:28 PM, Jarkko Sakkinen wrote:
> On Tue, Aug 30, 2022 at 03:55:47PM -0700, Reinette Chatre wrote:
>> On 8/29/2022 8:12 PM, Jarkko Sakkinen wrote:
>>> From: Vijay Dhanraj <vijay.dhanraj@intel.com>
>>>
>>> Add a new test case which is same as augment_via_eaccept but adds a
>>> larger number of EPC pages to stress test EAUG via EACCEPT.
>>>
>>> Signed-off-by: Vijay Dhanraj <vijay.dhanraj@intel.com>
>>> Co-developed-by: Jarkko Sakkinen <jarkko@kernel.org>
>>> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
>>> ---
>>> v2:
>>> - Addressed Reinette's feedback:
>>>   https://lore.kernel.org/linux-sgx/24bd8e42-ff4e-0090-d9e1-cd81e4807f21@intel.com/
>>> ---
>>>  tools/testing/selftests/sgx/load.c      |   5 +-
>>>  tools/testing/selftests/sgx/main.c      | 141 +++++++++++++++++++++---
>>>  tools/testing/selftests/sgx/main.h      |   3 +-
>>>  tools/testing/selftests/sgx/sigstruct.c |   2 +-
>>>  4 files changed, 129 insertions(+), 22 deletions(-)
>>
>> There seems to be at least three patches merged into one here:
>> 1) Update SGX selftests to create enclaves with provided size dedicated
>>    to EDMM (this change causes a lot of noise and distracts from the test
>>    addition).
>> 2) The mrenclave_ecreate() fix (which is still incomplete).
>> 3) The actual test addition.
> 
> I would agree on this on a kernel patch but not for kselftest patch. It
> does not really give useful value here. This adds a test and that is a
> good enough granularity in my opinion, unless some major architecture
> work is required as precursory. It is not the case here.

I must say that for many good reasons this goes against one of the
fundamental rules of kernel patches: separate logical changes into
separate patches. This is your domain though so of course the work
within it follows your guidance and I will not pursue it further.

> 
>>> diff --git a/tools/testing/selftests/sgx/load.c b/tools/testing/selftests/sgx/load.c
>>> index 94bdeac1cf04..7de1b15c90b1 100644
>>> --- a/tools/testing/selftests/sgx/load.c
>>> +++ b/tools/testing/selftests/sgx/load.c
>>> @@ -171,7 +171,8 @@ uint64_t encl_get_entry(struct encl *encl, const char *symbol)
>>>  	return 0;
>>>  }
>>>  
>>> -bool encl_load(const char *path, struct encl *encl, unsigned long heap_size)
>>> +bool encl_load(const char *path, struct encl *encl, unsigned long heap_size,
>>> +			   unsigned long edmm_size)
>>>  {
>>
>> checkpatch.pl informs about alignment issues above and also a few other places.
> 
> Weird. I did run checkpatch through these. Will revisit.

I usually run checkpatch.pl with "--strict".

Reinette