Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp846308rwe; Wed, 31 Aug 2022 12:05:59 -0700 (PDT) X-Google-Smtp-Source: AA6agR4apjoQfSNOjNlb9gmwraLt9TwrSb0NibfnUCzLguhHq6j0IiQ/nWr2NsBBwUdE6qcIGDNI X-Received: by 2002:a63:dd51:0:b0:430:18d9:edf8 with SMTP id g17-20020a63dd51000000b0043018d9edf8mr4590939pgj.163.1661972759053; Wed, 31 Aug 2022 12:05:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661972759; cv=none; d=google.com; s=arc-20160816; b=F/8jk2MkMnoE6JB3kXdiK2GWeKP1sMZ1k7Hul6SOmkM885KZEhl9XLGDxfS4A4vNe2 /WXTaQKtuPfw0hA7OuX6NjFLhiR4TH2CIh7pQcjWncasV6HW7qsiIVsxOxO7xDogJokm vvDnPAn85EZsFtmTmJvrPvIrVTkSzQDdsfBhqkmAeuje3GcMfrEm25zi8kImwhKuIJ+f dIaXjjKv/FZ+oqd+ZMBAmqT7NnR3IQnzKI4/9XjYMeK1KQBSozZUFEvW+R6LGF3YFsVV Si3e55KIvvUQztgs9aeD5ZGpY+Btk73DkNGx6zVLKSmBY9TRW79OtPEiqNN9eQiCUa+A TbuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=QOzTr0839E3H9tR0wkETuj4b9U9VUvaitz4KI9/r73I=; b=wYuTOdm2MJcpluh8QyK/LD2aszVuQrDkGZHEiAadp2zmeqDQr4/5Px35+0KaNaWxMd KEu/PjfLjkx4QIGSLEp7XuozO2Z/FOOl+VpwBIzLCF9qLiJrpIUKoh57IC2NEsJeJXUs PiW3sb6p8jLVs1eF7Wha8qwaMxifI3oAUAYGnG+Qcla5VlVlrRmVPSbuwNg4fim15zi5 /ggr7wPHdn+IWUrYBmJvbXwv/nfsAPeFi0N8gcsbyTcKkHjilST8yHEc1/GA+rpYXPAw /iwIDmuvcJ6xmwJStn/R1yYMavkyk9oqXMzNKH+NTVuf9wO8dqsDcwiBvyTBXlbun7VR HN3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=EWOrlKJU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 4-20020a17090a034400b001fb82756b9esi2208816pjf.97.2022.08.31.12.05.47; Wed, 31 Aug 2022 12:05:59 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=EWOrlKJU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232562AbiHaS3I (ORCPT + 99 others); Wed, 31 Aug 2022 14:29:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57180 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232619AbiHaS2Q (ORCPT ); Wed, 31 Aug 2022 14:28:16 -0400 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A7707DF3B for ; Wed, 31 Aug 2022 11:24:01 -0700 (PDT) Received: by mail-pj1-x1030.google.com with SMTP id u9-20020a17090a1f0900b001fde6477464so71443pja.4 for ; Wed, 31 Aug 2022 11:24:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc; bh=QOzTr0839E3H9tR0wkETuj4b9U9VUvaitz4KI9/r73I=; b=EWOrlKJU+LjqRQ/uV9Xua9LvEAnJThp75klKQawBXR3MM0Z+lCfQZzsPiCp50MfMKn RrB3LHxP6lWHR8RQlk9SL2/wueb5grQcMqwigHiPfW8os7zYwv5SeTLb6G+whxDTtkF/ RiTcqxJYXg7XbnnSYwkrDgauuEFFak+11Xl2A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc; bh=QOzTr0839E3H9tR0wkETuj4b9U9VUvaitz4KI9/r73I=; b=yAGogi3lJQ7EnMpSWTLjYAWl2y8TRlz55VB91GTyLyl+GKOnO2amV2tnYQbJIGHTAr OyzYq+Y0i4htCcTMJudC/J1rvMczkNu1ndFX3a9UwtTpQTG6XIp7+ioojVmei/i3EgVX 1L3oPiNFaKqwDlzslmeFKLqN4scAER58elyQNsopfiNGqdnuQpVyQTVWwcXe/fH9WaNi w8Qv+RphOYrJ/3ZrprIOb0WaqnMl5jFF1Py3CNOsLcU2fmauMjMt7RW+PUWugxynaBhL GZ7SUIneh+0PtszGnGrtgUzRB/GLArIHKQNf/fzs4+OXvKjdfyUGvhNFqHfv+QUT7XEM OYrg== X-Gm-Message-State: ACgBeo2Ik2AsQsVYJL4lGmDg5JnMZluG3cI0RG4r+CsvfLjfC6IQ5AO2 JQLXQ53OvxydLUZhKOci1+l53Q== X-Received: by 2002:a17:902:b68d:b0:172:e973:82b9 with SMTP id c13-20020a170902b68d00b00172e97382b9mr27132898pls.120.1661970241179; Wed, 31 Aug 2022 11:24:01 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id z24-20020aa79f98000000b00537f9e32b00sm9156524pfr.37.2022.08.31.11.24.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 31 Aug 2022 11:24:00 -0700 (PDT) Date: Wed, 31 Aug 2022 11:23:59 -0700 From: Kees Cook To: Sami Tolvanen Cc: linux-kernel@vger.kernel.org, Josh Poimboeuf , Peter Zijlstra , x86@kernel.org, Catalin Marinas , Will Deacon , Mark Rutland , Nathan Chancellor , Nick Desaulniers , Joao Moreira , Sedat Dilek , Steven Rostedt , linux-hardening@vger.kernel.org, linux-arm-kernel@lists.infradead.org, llvm@lists.linux.dev Subject: Re: [PATCH v4 17/21] kallsyms: Drop CONFIG_CFI_CLANG workarounds Message-ID: <202208311123.B3B651E@keescook> References: <20220830233129.30610-1-samitolvanen@google.com> <20220830233129.30610-18-samitolvanen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220830233129.30610-18-samitolvanen@google.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 30, 2022 at 04:31:25PM -0700, Sami Tolvanen wrote: > With -fsanitize=kcfi, the compiler no longer renames static > functions with CONFIG_CFI_CLANG + ThinLTO. Drop the code that cleans > up the ThinLTO hash from the function names. > > Signed-off-by: Sami Tolvanen Reviewed-by: Kees Cook -- Kees Cook