Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <218a5ae1-f74e-36e3-1137-c001d49126bb@intel.com>
Date:   Wed, 31 Aug 2022 11:10:20 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH 6/6] selftests/sgx: Add a bpftrace script for tracking
 allocation errors
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>
CC:     <linux-sgx@vger.kernel.org>,
        Haitao Huang <haitao.huang@linux.intel.com>,
        Vijay Dhanraj <vijay.dhanraj@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        Shuah Khan <shuah@kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>
References: <20220830031206.13449-1-jarkko@kernel.org>
 <20220830031206.13449-7-jarkko@kernel.org>
 <64498c9f-a6e1-6379-ca8e-d751fb239bec@intel.com>
 <Yw7IZWHbHjdjMa/Y@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <Yw7IZWHbHjdjMa/Y@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MXRETlhlbm9NOUYxS2w4Ny8vTExMZm4xc0tzUExsM3FCOWZVZC9GUnZ4czVP?=
 =?utf-8?B?YldSY3d4dERwN1d1UnQ3Z0MvckVXWWZ5OS9xQUJueVZxd3RGY05xTU1ETU01?=
 =?utf-8?B?dHNQaUE5S2p6WWRya0dSY2ZMRjNadFB6c0t6N1czL1FKYmtjQVpiY3MxQ0FH?=
 =?utf-8?B?Ni9SVFc1OXo5K3FVa1NZZy8yWUJTWkd2R0I1ckVjVEtxMkFnWnpiU3luejd5?=
 =?utf-8?B?N1MwbzVuWlFvOU5ScVlBVGVaVGdGR09XVm1JeEwweE9PUTRKQitPRU05OFJ4?=
 =?utf-8?B?Sjc4cjZSMHNHVFVtc09SMEgvdk5DTmp4RDlIelNML3lLcXA4dGVtUE1VYzBj?=
 =?utf-8?B?UkkzVnRVQkRWdllsRkpHUm1YZUc1UWJpbUdDR1BBOTJlN3F2WE90MEVSMXo3?=
 =?utf-8?B?d245SHJYQzF4N3V3NWo4eW15dnJubnpqR0g3OVlBbDdQdTlnUU9uNk80NVpJ?=
 =?utf-8?B?SUgrTjA1bzdGQ2NacXN4Y1gyY0UrYjh2L0NtUGg2VnRWSG1GdzVKRGoza0hC?=
 =?utf-8?B?RHEyNTBvSXFhTFVuRU9iVjRoUEZHOUQ0dFJ1TVB5NytQMy9GVXR6bEtTZkRY?=
 =?utf-8?B?Zm9CRWJNeXNPeEsxZjAzNFVrSm5EajJoTEY5T2U1ZVNPUzFOTnZWWXMwSFdK?=
 =?utf-8?B?U2NGaHFEWWdVYmh2RTdrb2xObERGRDVkRWI3RWdWYm9iMFBSckVCQXFkZjdh?=
 =?utf-8?B?WW5WUkZidkt6clp0K1ZHZS9HVVB5MEUzdzZMamdvK0ZIejZTc09iUUg1UmVB?=
 =?utf-8?B?cFZTLzFCOGxVMkFoZkM3Y2JzUDBsZmdESHp4b0Q0a3FycWZPOE1hRHhMQTN0?=
 =?utf-8?B?WTF2MXpZQUN3czRPdmFySzVpWi9iMVp3SnYxaWhmNDg5SUpSTlRYOC9GNmFv?=
 =?utf-8?B?NXFtVVhPaE9aNlF4K1d5UHVLTXlBYkZLL3I4cUxVY3Q2OXZkZ0lHZ2tYZmIx?=
 =?utf-8?B?ZDNnNWdad2xocytBNlBTTjRFQkVEV3o0bVhFMThMdlVySnZneW5nYnFkRFl0?=
 =?utf-8?B?R2Ixd3h4dnNlSzhUcmw4VXJoczhzUEkwTDhoS2EvWWxFSS95QXhDVmwzcDJK?=
 =?utf-8?B?K01QakRhNk85cFFwTTczUTM0dzVYNWF0bXc4QmpNd0VzV25kN01ZanA1aUxZ?=
 =?utf-8?B?UjNwVzBrb05kb3pSNTVWMFN3ZHY1ditSY0s3clBpU05BdW15VlZYbm4ySy8x?=
 =?utf-8?B?dDZkVE9YSEREejI4OXlRVUJGZ1pyQnpSd01HNkE3c05WTmdwdCtTQytqTXZE?=
 =?utf-8?B?Y1RkTis4Y3hIcWFGR2NTQmlGRTlkR2JEZnA0SU9Vak9TZXFzOTBvOE44NlJr?=
 =?utf-8?B?YURxdTRqNWp5aVowZGJ0QTNOc1U4aHVwVFpXVkpDdW0zUzRacjVGaEV3RW5X?=
 =?utf-8?B?L3poMjRtN3VZL0tLUlpFSlpMQXBUbW4xcXNvZG1Db0wwQU0vV3c2dXE4R1VD?=
 =?utf-8?B?V2gvcFFyL3NMc3ZvS3JvL3JRSVFOUGVFSXhTeXVONUdSc0pJSSs3OUVpNjVK?=
 =?utf-8?B?cVlYZ1hhMmV0d0pEZEttS2Fmakg3UUlNSlZiR2IzMEdlVGtkM0k1bWFsbU83?=
 =?utf-8?B?Tkl2RVpYeVBGYTlGYkxxL2lqWlZpaVBnUFRuMzhaVmhPNVVRWUFwcWhBVytT?=
 =?utf-8?B?VWVZSHlOTkFrdWRWVDg3Q2t4NnlFdm15R0EwR3d2eWNZM0djUlQ4SmtGa3li?=
 =?utf-8?B?dFlweFd3UjhBQ3EyQkRQTDJ4cEFoR3VRNVQ1SFZ2Ny9mdEU5M0VQRWUvelNO?=
 =?utf-8?B?Vkg0bTJuVXBsWFhwY3NRZ2dLQjdlNmtNaGJMaGZ1RzloSmJXb0QwOUpzTTdR?=
 =?utf-8?B?SFBraERYL2R0R0NVUFkrTWtGdnlDVU1adEkyYUhYb1BwTWRzSm9YQmUrZGt4?=
 =?utf-8?B?SFkyQkxTNG45TFcyaEIxLzZhZEl3R1VzeDJxeVFQTFBjcUpNSERwL0QrdGtk?=
 =?utf-8?B?cTZiRUs1R1dzT2NxNnU2YzFvQWpCQzg5U1o0L084Z2xVKzVrb0VPbDJXMCt3?=
 =?utf-8?B?YkpBb0J6V0diWVBTUG1XTGtKWXpWaHkxMzNyZ3ZtSHU4Qmx4clNGZTVTVlFO?=
 =?utf-8?B?ZDlyckN6dXhqRVR3QWNHRGIyRlBscVZ2Rk1ReUdJbE5OcC9OZ2VpdndVR0NI?=
 =?utf-8?B?MGY2VHpFRVF0U3hTMFg5RmJEelNvSzZEZ0VKZjZhbythTUhRYjVRVzBQVmVm?=
 =?utf-8?B?dGc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: f3c2bcab-35bc-414b-5741-08da8b7c1276
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 18:10:22.9703
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: sA2/bmdWog/sgLafuGBal+84bdyYyn6UkDBGVNzGILa8b/TYhHnnURf+CX491TD8mrfZYA8pMZblZgByZbLbXmwqum8pJma+VklaLdiBE5A=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3146
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 8/30/2022 7:33 PM, Jarkko Sakkinen wrote:
> On Tue, Aug 30, 2022 at 03:57:24PM -0700, Reinette Chatre wrote:
>> Hi Jarkko,
>>
>> On 8/29/2022 8:12 PM, Jarkko Sakkinen wrote:
>>> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
>>> ---
>>>  tools/testing/selftests/sgx/alloc-error.bt | 7 +++++++
>>>  1 file changed, 7 insertions(+)
>>>  create mode 100644 tools/testing/selftests/sgx/alloc-error.bt
>>>
>>> diff --git a/tools/testing/selftests/sgx/alloc-error.bt b/tools/testing/selftests/sgx/alloc-error.bt
>>> new file mode 100644
>>> index 000000000000..9268d50dea29
>>> --- /dev/null
>>> +++ b/tools/testing/selftests/sgx/alloc-error.bt
>>> @@ -0,0 +1,7 @@
>>> +kr:sgx_alloc_epc_page /(uint64)retval >= (uint64)(-4095)/ {
>>> +		 printf("sgx_alloc_epc_page: retval=%d\n", (int64)retval);
>>> +}
>>> +
>>> +kr:sgx_encl_page_alloc /(uint64)retval >= (uint64)(-4095)/ {
>>> +		 printf("sgx_encl_page_alloc: retval=%d\n", (int64)retval);
>>> +}
>>
>>
>> Could there be a snippet of comments in this new file to guide users
>> on how to use this script?
> 
> Do not mean to be rude but I'm not sure what there is to guide but
> I'm open for ideas.

How about something like below in comments as part of the script:

"bpftrace script using kretprobe to trace returns of some key functions
 in support of tracking allocation errors."

This is essentially in the subject line of the patch but that information
will be lost when somebody looks at the script and tries to figure
out what it is.

Reinette