Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp890236rwe; Wed, 31 Aug 2022 12:58:39 -0700 (PDT) X-Google-Smtp-Source: AA6agR76g5h3Nhypcc4emi8OVf3s5q4E9vGaqBr7g+kghR25FdpNU0IUmsPCMYHtD5K8l6EiCFKf X-Received: by 2002:a17:907:7215:b0:741:416f:fb59 with SMTP id dr21-20020a170907721500b00741416ffb59mr15774399ejc.150.1661975918789; Wed, 31 Aug 2022 12:58:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661975918; cv=none; d=google.com; s=arc-20160816; b=CX18TZorRY56WYrdYZEs6oZLht2Ra6JycSBNedEJHBUPo3/pfrQKINpgiWo1vue0Bg nRBy4xdQPUxvMX0rrXJD9DFjHfMI1f9AHTyeTelfEvvbvzXTan0Lrd7uGf3wySJaELQu iKiGEWZLSjWfbrxDP6/FLv0S1yjBuAew3D8dUH1+n6VTZpWb6RC/BNfzmoIiarVu0qRy 99QfbxomLzuQw7UWwqa0E6snEnguNIDoY6UZLJfUBfnKvoAN8urGkYI6TL13G0nmn7qc 8Q8eGgBFmA+iQyTg+XY+tuW7NJBrKHClYjibYOq8IrICRmj1Z9EbP9ukXRDYLagVHLgn OplA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=VkN9kjUhyzdT4oetnRVdj6WFy3Q+ODyLNUTLMRrWCOU=; b=NUvtAxDLu4r0X4gPHWYwTKukBDFiNtr5eO+L6nH/+NW1q2w9fbmvDk4min5r/JR+QC K/MLyUKly77iy/E8fVFxoCeqgmvDEIAHlKCUiZusvv7tnB3l+ntILbj7slInwuQhvi/n Ymwo2JT1Ti4xakkOrVNnHwl1WwnQ2hDBujwAm2H8Fvazc4YF/mQhAdFeJwsNzrDYw7qN 7VYChTL2Lnd9fk4v27SYg8h5BTmNrTmD911EFTyNAiilKgG2FdtwA/BEqOk+SU+JyIGU 5DRYM1JF4uFz4anB1tCvjkzS2rAenuMEox7G7J81fVtU7b688ti4lM6nMI/CQ3Seoe38 yUyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=jnoZz37A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id cm8-20020a0564020c8800b0043b644f0175si121795edb.88.2022.08.31.12.58.12; Wed, 31 Aug 2022 12:58:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20210112.gappssmtp.com header.s=20210112 header.b=jnoZz37A; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231994AbiHaTof (ORCPT + 99 others); Wed, 31 Aug 2022 15:44:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57368 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231645AbiHaTod (ORCPT ); Wed, 31 Aug 2022 15:44:33 -0400 Received: from mail-ej1-x62b.google.com (mail-ej1-x62b.google.com [IPv6:2a00:1450:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7A6F95E6C for ; Wed, 31 Aug 2022 12:44:31 -0700 (PDT) Received: by mail-ej1-x62b.google.com with SMTP id nc14so25538617ejc.4 for ; Wed, 31 Aug 2022 12:44:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc; bh=VkN9kjUhyzdT4oetnRVdj6WFy3Q+ODyLNUTLMRrWCOU=; b=jnoZz37Afx7vOS3iOdri3YbmU0nJL11sAICLa1IjRRdteBOcSQ5fX36C+GB7uY3uGu too9RUznebC7dzqDpYIK3uXi/9G08AmaqAcLs8pe3WN9b6IJuUlgenI+VyBrjJjdEZVX 0ddZzfaG8Xzeeg2bfYcoEZM2lbICLrUl7G5ire3Y9SQkv/wu9j+i/FzJpJ0VY9rTKl3L /7Rigmgjj5uv0du2sNg5piTTMDSAR76wW31GEitWfq39WHqqeYgH2F1YnJIg74MKvFIS VQCL0nl5uNkT7xX1XLvTaCypGIvDgP98djxfCWKA9lSPQXDau+Z/4cXWwu0yxY25kybe 3Wdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc; bh=VkN9kjUhyzdT4oetnRVdj6WFy3Q+ODyLNUTLMRrWCOU=; b=wyn0NXjQacmfaqGVkT0NmBu+v2wVRs7kkzgxijBIiJCOOp3QhGdbVzIuebSbcOGElh dP3U08s+/pdlS2mHbVl29m8cY+qP83o58VzjGWTAw9E5C5tc0TmCUNHtRrz333iFMpEA rlXL5aumUibFpMVY1iOGQbA8/XilDbILiL/NYFRegCtp1Wft6Ck5ZB10nmvLJCp3prEw aP6VTmV6eFrKwIZq4w8uIbyS1ioo13EvVdcHlrl1S+kVLaBpSUQc9yGCSG7tNO8+t4Qe qm97svBmun9lw8Hk4f5eTX5PiIRzsmAUt13XmPn+a3kXZQ3Od4INoEpg8THxRJ7v1HIo fR4g== X-Gm-Message-State: ACgBeo3hYBvh2dWwBijhh2NftRFXJbesnpoEBDEkN2MVeDzmeTFRD9Bw teaIy3uzisjCR2iae4mLRIS5BNSXsvrhONWvYaNjdkJkgEg= X-Received: by 2002:a17:907:7254:b0:731:61c6:ecf9 with SMTP id ds20-20020a170907725400b0073161c6ecf9mr21837260ejc.101.1661975070397; Wed, 31 Aug 2022 12:44:30 -0700 (PDT) MIME-Version: 1.0 References: <20220829133923.1114555-1-martyn.welch@collabora.com> <20220829133923.1114555-5-martyn.welch@collabora.com> In-Reply-To: From: Bartosz Golaszewski Date: Wed, 31 Aug 2022 21:44:19 +0200 Message-ID: Subject: Re: [PATCH 5/5] gpio: pca953x: Add support for PCAL6534 and compatible To: Martyn Welch Cc: Linus Walleij , kernel@collabora.com, "open list:GPIO SUBSYSTEM" , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 31, 2022 at 6:30 PM Martyn Welch wrote: > > On Wed, 2022-08-31 at 13:57 +0200, Bartosz Golaszewski wrote: > > On Mon, Aug 29, 2022 at 3:39 PM Martyn Welch > > wrote: > > > > > > Add support for the NXP PCAL6534 and Diodes Inc. PI4IOE5V6534Q. > > > These > > > devices, which have identical register layouts and features, are > > > broadly a > > > 34-bit version of the PCAL6524. > > > > > > However, whilst the registers are broadly what you'd expect for a > > > 34-bit > > > version of the PCAL6524, the spacing of the registers has been > > > compacted. This has the unfortunate effect of breaking the bit > > > shift > > > based mechanism that is employed to work out register locations > > > used by > > > the other chips supported by this driver, resulting in special > > > handling > > > needing to be introduced in pca953x_recalc_addr() and > > > pca953x_check_register(). > > > > > > Datasheet: https://www.nxp.com/docs/en/data-sheet/PCAL6534.pdf > > > Datasheet: > > > https://www.diodes.com/assets/Datasheets/PI4IOE5V6534Q.pdf > > > Signed-off-by: Martyn Welch > > > --- > > > > Is this series complete? I don't have patch 1/5 in my inbox and > > neither does patchwork. > > > > I used get_maintainers to generate the recipients, it's a patch for the > binding documentation relating to the driver so didn't get sent to the > same lists: > > https://lore.kernel.org/lkml/20220829133923.1114555-3-martyn.welch@collabora.com/T/ > > Martyn > > > Bart > Ah, ok. Just for completeness, please send the entire series to everyone unless it's lots of patches. Bart