Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp891466rwe; Wed, 31 Aug 2022 13:00:14 -0700 (PDT) X-Google-Smtp-Source: AA6agR4XL/HAIP1d9j54VkjdsxLe2TRcDeCDCeaJGBy/ivaf9rdAIwzL8+ndNqk+nXoNX6tzDMwF X-Received: by 2002:a17:906:5a44:b0:741:7925:d42a with SMTP id my4-20020a1709065a4400b007417925d42amr11939289ejc.611.1661976014084; Wed, 31 Aug 2022 13:00:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661976014; cv=none; d=google.com; s=arc-20160816; b=kRLHZFjgi1U1hOnMGxm+CJa+0iTmBjkIzB3oYdtnK9tqzRidmGaVH65d+uoyeDFB1/ 61ispEV0/R5zGp9kN8VTlGqTArfdbX/wy63duRXnef2hPZ5Fx1VMStzbiFGH6PaqS4yV YRE8sZ1mmwD6tKT+ga04N9uNcWk9Lxa34ju9LvVkhW3ZHz/QERFr5KUibB8gnvdYyLn4 WLbD15nwbXOhfTyxugFq/yc6hy/80QQ3WrfhpbDyarar3bK5qoi8CxpjqBgsid8fsOrC wvXIOTN30Siqhg/wQ43xZxYfBIshSG4fiqfN7bOcyzGceQm0U03GdlB9ATTJQEE0bFZp J4Dw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=nrZIM9VLfdVCeWJuNlthJ1kCG9MNpM9G6ZQarZH+TaE=; b=FnbdPbEm5NkjODDQhsyH91vklS8oBgZ8dHeboH9NZiN/xYoExGs7PdLovW7OWTowBq oTwiMWt97eTBOcPmFV+nVFKYyQOfSUcM3fkC2iOuMFG0R1syLtZ3mRbvxAcoIPhjvR/F bsco+ch8UH+9RLMAoJ7jxqIFxaAezKhgBkEUR5Vx6KeP9ePhIJkfpwxLY7bBQe4ADkkJ 884Z/YoFnalnbhzhCpE/88vpNnaQVFkP96+nvSRHjyMADYKp79jyGAAmZX9FCZG8AzUs WCx2GR44vUEsnBsDx+1BE8R5/0Asb5km0gSN9zJeU40oK25nPxjYaf7TSYAotOjRolls UEEw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J5UIVBbK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id hb12-20020a170907160c00b0073d847631d2si12421746ejc.158.2022.08.31.12.59.48; Wed, 31 Aug 2022 13:00:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=J5UIVBbK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230497AbiHaTXy (ORCPT + 99 others); Wed, 31 Aug 2022 15:23:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56294 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230148AbiHaTXx (ORCPT ); Wed, 31 Aug 2022 15:23:53 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30B13DFB7D; Wed, 31 Aug 2022 12:23:52 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id DFDFEB822AD; Wed, 31 Aug 2022 19:23:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E428C43148; Wed, 31 Aug 2022 19:23:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661973829; bh=c3t0chfRFPX1swN2ncrFYQRhf9ygUK44TaxGI66WcKs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=J5UIVBbKlaozc1C+KyB1lnqAPV/SYp2x7iInF+h2cyMlS+lFpi1iC0ylrtO8d4BBz htdUXly2QyoGg6vjcCZBDIdVEICLAEGkKI1uB6JmAp0ybqK6Xxr+jr+AiLhBFDuC6c 2doiQbfOwZt1niUMiyzCJNpjvcqDIHUpnGnH/JArUgeIT6lYVew2LTx4qB0q66169B I+GOU4jKHVjZOT+aQ1kC+J0ouQnsN0XG86oELVSmxfhF3XX7qIDZLfXzAY+VKOupB6 eek18+WhgZN6cP6zPGgKm7AXPL7EuKLGpUiKKe0VoatNdWbSpQ+O1W5Rj2ajM2+0Oz YqIjVHS8S2wAA== Date: Wed, 31 Aug 2022 12:23:47 -0700 From: Jakub Kicinski To: Aleksander Jan Bajkowski Cc: hauke@hauke-m.de, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next v2 1/1] net: lantiq_xrx200: use skb cache Message-ID: <20220831122347.5c5dcb56@kernel.org> In-Reply-To: <20220828191931.4923-2-olek2@wp.pl> References: <20220828191931.4923-1-olek2@wp.pl> <20220828191931.4923-2-olek2@wp.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 28 Aug 2022 21:19:31 +0200 Aleksander Jan Bajkowski wrote: > @@ -239,7 +239,7 @@ static int xrx200_hw_receive(struct xrx200_chan *ch) > return ret; > } > > - skb = build_skb(buf, priv->rx_skb_size); > + skb = napi_build_skb(buf, priv->rx_skb_size); This gets called on MTU change, outside of softirq context, no?