Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <97f1d259-4fc9-4b9e-7769-3a646ffd0423@infradead.org>
Date:   Wed, 31 Aug 2022 12:37:22 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH v2] hugetlb: use mm.h instead of mm_types.h
Content-Language: en-US
To:     Matthew Wilcox <willy@infradead.org>
Cc:     linux-kernel@vger.kernel.org, Peter Xu <peterx@redhat.com>,
        Mike Kravetz <mike.kravetz@oracle.com>, linux-mm@kvack.org,
        Andrew Morton <akpm@linux-foundation.org>
References: <20220831185739.21400-1-rdunlap@infradead.org>
 <Yw+2PrIzebUbVYQR@casper.infradead.org>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <Yw+2PrIzebUbVYQR@casper.infradead.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk


On 8/31/22 12:27, Matthew Wilcox wrote:
> On Wed, Aug 31, 2022 at 11:57:39AM -0700, Randy Dunlap wrote:
>> mm_types.h does not have zap_flags_t in it so use mm.h instead
>> in hugetlb.h.
> 
> ... my copy of mm_types.h has zap_flags_t in it.  Was it recently moved?
> Perhaps moving it back is a better solution to this problem?

Ah, I see. This patch was originally to mmotm, but then for merging
(commit 05e90bd05eea), Peter Xu moved the typedef so that this patch
is not needed. Sorry for the noise.

and Thanks.

>> Fixes this build error:
>>
>> In file included from ../drivers/virt/nitro_enclaves/ne_misc_dev.c:16:0:
>> ../include/linux/hugetlb.h:414:4: error: unknown type name ‘zap_flags_t’; did you mean ‘vm_flags_t’?
>>     zap_flags_t zap_flags)
>>
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Peter Xu <peterx@redhat.com>
>> Cc: Mike Kravetz <mike.kravetz@oracle.com>
>> Cc: linux-mm@kvack.org
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Reviewed-by: Peter Xu <peterx@redhat.com>
>> ---
>> Fixes: mm-hugetlb-only-drop-uffd-wp-special-pte-if-required-fix.patch
>> v2: add Rev-by: Peter
>>     drop the bogus S-o-b: in Cc: Peter Xu
>>
>>  include/linux/hugetlb.h |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/include/linux/hugetlb.h
>> +++ b/include/linux/hugetlb.h
>> @@ -2,7 +2,7 @@
>>  #ifndef _LINUX_HUGETLB_H
>>  #define _LINUX_HUGETLB_H
>>  
>> -#include <linux/mm_types.h>
>> +#include <linux/mm.h>
>>  #include <linux/mmdebug.h>
>>  #include <linux/fs.h>
>>  #include <linux/hugetlb_inline.h>
>>

-- 
~Randy