Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d2b76530-82a2-6ac1-32ea-696e653d767d@intel.com>
Date:   Wed, 31 Aug 2022 13:07:35 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH v2 4/6] selftests/sgx: Add SGX selftest
 augment_via_eaccept_long
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>, <linux-sgx@vger.kernel.org>
CC:     Haitao Huang <haitao.huang@linux.intel.com>,
        Vijay Dhanraj <vijay.dhanraj@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Paul Menzel" <pmenzel@molgen.mpg.de>,
        Shuah Khan <shuah@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220831173829.126661-1-jarkko@kernel.org>
 <20220831173829.126661-5-jarkko@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220831173829.126661-5-jarkko@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q1FLSTYyTEs0ZnJDM1FEN29ZQURrazg0SkZkRW4zYkI1clI1SUc3clljVmU5?=
 =?utf-8?B?SnNXQ0pWaW5ZSnRra1h0ZDU0YmZQMmx6RWQ5WEgxVmhXK241U3lWYW1SdHhF?=
 =?utf-8?B?SEFQeDJmTzQycUpsNlpXK0hNWW9DWmJtUzF2cjIxYVZrYXZJWVZ4TU41QmpR?=
 =?utf-8?B?dnBOS1VkL1gyR2F5THJSbWE3MlJGMEladFN6a3BuSEhFNUkrY3p5dTZQcDM1?=
 =?utf-8?B?Vy9sdkVQeEd5bUxHalM5RmNBekpMa2tlZXV3bFRvOG5FMnoyZ3VzMWJZWU93?=
 =?utf-8?B?QVNlQnNmNHAzOFE5UFlONnhpWjlnWmQrRGc0WFZJZGpjb2ZOQnBOQ21vd3NI?=
 =?utf-8?B?YWY4RjlsS1J5NkJDSFhQR0d0R1VRaGVDTGFkNkI2MFltcUd4aXR5bDRmNEZ0?=
 =?utf-8?B?UnRUVGhQNXZhSVkvVU52UFZMZXA2Q25ocDJRSitWRFd2Zit4cWVQYlZUQnV5?=
 =?utf-8?B?MTNWREU4bG5URmhiZkVTd2hKYmJrNHp2b0JyVzNhdFd0UU1BK0pSZllZaEx4?=
 =?utf-8?B?VCswSDFuckVwekVPUUc1cTNpRVBtLzE0ZW1vVzBwaEZSQ2I5RGFzUklvczlh?=
 =?utf-8?B?cXl1SGY2T2hvRloxZTQ4S1NjNkpEV041TjNRcDM5QVJOcjlOSjhRSkh4SDEr?=
 =?utf-8?B?QWFRZ1h4b3BXa0JEMUpUL0JqUkVSdm13bmJGT3cvblVzMmFKOHZYT3RKb2Jr?=
 =?utf-8?B?OHB0U0xXQW9qZnhUcldSRlBMeExocW1wUmwrWWM4RnNzQlhyL3dZQ2kyNDZO?=
 =?utf-8?B?a2YwZ05sbXNDZ1VmOUJjdEI0Nk5COGgxOGFnUFZ5ZmZjRlMxTUgyOUJkSHNs?=
 =?utf-8?B?U2xJZzl5Q0NZS0RnUUMzTDAwTlU0ZVphbjVKYUh1dDBxa0ZFSlY3c2ZGTkdz?=
 =?utf-8?B?eC9Lc1M2UHh0SHNwV0Y3TmdUdDJsK0d3Q0pvd0F3emFhb0pVWEF0ME1lNjVo?=
 =?utf-8?B?dEN0UnNDdUFud1ZGNXJEWnI4NzhadFNyYm1pZ2R6Q2cwRGF4N0dJMjl1NWMv?=
 =?utf-8?B?YkFiamNRaW1nVkJxRCtyQWFKTTJLeit2T2VPemJEQ1YvRWRZamVTcm05Nkp5?=
 =?utf-8?B?SVdLUFlKcCs1VnlMM08yWkRoa0tMMEVPVzU5SFkrZFdSajlqQmUyaVhwSEto?=
 =?utf-8?B?Q1FMWmNoT1lYMU1ZMFFtbVRKK1JjUjJnYVV0M2pwUllNUEdrcGNYcFFyQzRm?=
 =?utf-8?B?ZEdjRkxmSUF6R0F0OGJ3UHhGQnhjc3ZuajVBZUtXWUV2VGhyUnhEZnM1VDJ0?=
 =?utf-8?B?dXpKbFNzaHp4RFUrNXZwUGttWmEzV3BwKzdYbUZSQWVhTW4xUTdzcE5UTU1Z?=
 =?utf-8?B?YTVsNi95c0ZhR3QxY1BWNUJKTG1rSnFLR0ZOZkxkVE1TTkdFeDl1ZnJWampr?=
 =?utf-8?B?dEFaLzFaMHQ3eEw0UlNVeGFzNU1Kdzk4VkFKZEp1bmdBNDBGR0ZUUEFrVEtS?=
 =?utf-8?B?TUhxV1BLVy9KT3M5WklON3dFYzZOQnVWU1RzRUpaeU0yUW1mWmhSQ2JPQW5w?=
 =?utf-8?B?NHlVL2ZWazhuZ3NsekNOcDFBRTY0WFN1dTFjdTdTQ1Z0WDNyZzhuTU0rV3RB?=
 =?utf-8?B?Tkk4SmtKbVBXTElsUXlxZTlldmpkU1JVNkNOMzcwdUhqTGtBUVdERkc4eGRY?=
 =?utf-8?B?akZkT052VTZrMldLMTM5dkR6RlloNW9hYlN1QnBNTkd1MnRlN2R5K0lySU14?=
 =?utf-8?B?RHh3bzJLR25NeGxzcTU3b1FRS0Q4UXJ1S0M2L3NZU0dGcGhLSU5hMWFOVm52?=
 =?utf-8?B?LzN0WEoxQWZaeWFWZEV1RkdGcVl6eW5GZmdOa1dvaEJ1U0lEWS9xWUduc2pa?=
 =?utf-8?B?UEZ0VmxFeEhReXdpTG4xZzFWbDZtbmNMdTZ2ZVprTnRPUVZYWnR6RENlYTdH?=
 =?utf-8?B?SW1OREIyeTNmUXNXSXUyOUgzdmx4OTZzM0xDajJONnlTWnBQSDd5YzZWNWd4?=
 =?utf-8?B?OUJya2lSejd4WnVaZkxDS3FuZXdVa2VaUUNFanE1RTVtWGVrWFNKUE5HRE9j?=
 =?utf-8?B?aXlGRnJkOTlDaUwyeEViVGgxZ1c3emdRMkdLSi9udG9XcGNxT3lpY3RZVldF?=
 =?utf-8?B?S0lJUXN6ZG9rTTZPV3RvVytrdXdtWk9kRGlZUzNzMmdXNmVJY3JEM1hudjVo?=
 =?utf-8?B?OXVpVXhoRkFncGZIc3ZXMGJQUUY0VFZLQU8wb0ZoM1R2SEU5WHhKaXBHNzlo?=
 =?utf-8?B?MUE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 984be8f6-5cc6-4323-52bd-08da8b8c7382
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 20:07:37.7980
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: GpA8/+8sJojTEYPb8bPLTBmKAif8LlbsggDWBZUd9IV79ys/ybxIFDObYZucbjjMvmIyd7PwGdfXXq/OUXoK/mXhvbREymnjdID82icPPGE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3116
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 8/31/2022 10:38 AM, Jarkko Sakkinen wrote:
> From: Vijay Dhanraj <vijay.dhanraj@intel.com>
> 
> Add a new test case which is same as augment_via_eaccept but adds a
> larger number of EPC pages to stress test EAUG via EACCEPT.
> 
> Signed-off-by: Vijay Dhanraj <vijay.dhanraj@intel.com>
> Co-developed-by: Jarkko Sakkinen <jarkko@kernel.org>
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> ---
> v3:
> - Addressed Reinette's feedback:
>   https://lore.kernel.org/linux-sgx/bd5285dd-d6dd-8a46-fca9-728db5e2f369@intel.com/
> v2:
> - Addressed Reinette's feedback:
>   https://lore.kernel.org/linux-sgx/24bd8e42-ff4e-0090-d9e1-cd81e4807f21@intel.com/
> ---
>  tools/testing/selftests/sgx/load.c |   5 +-
>  tools/testing/selftests/sgx/main.c | 143 +++++++++++++++++++++++++----
>  tools/testing/selftests/sgx/main.h |   3 +-

Is this test passing on your system? This version is missing the change to
mrenclave_ecreate() that causes SGX_IOC_ENCLAVE_INIT to fail when I try it out.

>  3 files changed, 130 insertions(+), 21 deletions(-)
> 
> diff --git a/tools/testing/selftests/sgx/load.c b/tools/testing/selftests/sgx/load.c
> index 94bdeac1cf04..47b2786d6a77 100644
> --- a/tools/testing/selftests/sgx/load.c
> +++ b/tools/testing/selftests/sgx/load.c
> @@ -171,7 +171,8 @@ uint64_t encl_get_entry(struct encl *encl, const char *symbol)
>  	return 0;
>  }
>  
> -bool encl_load(const char *path, struct encl *encl, unsigned long heap_size)
> +bool encl_load(const char *path, struct encl *encl, unsigned long heap_size,
> +	       unsigned long edmm_size)
>  {
>  	const char device_path[] = "/dev/sgx_enclave";
>  	struct encl_segment *seg;
> @@ -300,7 +301,7 @@ bool encl_load(const char *path, struct encl *encl, unsigned long heap_size)
>  
>  	encl->src_size = encl->segment_tbl[j].offset + encl->segment_tbl[j].size;
>  
> -	for (encl->encl_size = 4096; encl->encl_size < encl->src_size; )
> +	for (encl->encl_size = 4096; encl->encl_size < encl->src_size + edmm_size;)
>  		encl->encl_size <<= 1;
>  
>  	return true;
> diff --git a/tools/testing/selftests/sgx/main.c b/tools/testing/selftests/sgx/main.c
> index 9820b3809c69..c5aa9f323745 100644
> --- a/tools/testing/selftests/sgx/main.c
> +++ b/tools/testing/selftests/sgx/main.c
> @@ -23,6 +23,10 @@
>  
>  static const uint64_t MAGIC = 0x1122334455667788ULL;
>  static const uint64_t MAGIC2 = 0x8877665544332211ULL;
> +/* Message-ID: <DM8PR11MB55912A7F47A84EC9913A6352F6999@DM8PR11MB5591.namprd11.prod.outlook.com> */
> +static const uint64_t EDMM_SIZE_LONG = 8L * 1024L * 1024L * 1024L;
> +static const uint64_t TIMEOUT_LONG = 900; /* seconds */
> +

Apologies if my feedback was vague - I actually think that the comments in V1 added
valuable information, it was just the variation in formatting that was distracting.


Reinette