Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <048cdd4c-0454-1fb2-ebac-3bdb4cde792b@intel.com>
Date:   Wed, 31 Aug 2022 13:09:21 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH v2 6/6] selftests/sgx: Add a bpftrace script for tracking
 allocation errors
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>, <linux-sgx@vger.kernel.org>
CC:     Haitao Huang <haitao.huang@linux.intel.com>,
        Vijay Dhanraj <vijay.dhanraj@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Paul Menzel" <pmenzel@molgen.mpg.de>,
        Shuah Khan <shuah@kernel.org>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>
References: <20220831173829.126661-1-jarkko@kernel.org>
 <20220831173829.126661-7-jarkko@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220831173829.126661-7-jarkko@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUpwak42bkpMa216VHZRbkQ5ZWlwQU9aUnNXeUxXeFpCVVNnYmZsOFp1c0VB?=
 =?utf-8?B?d1JVYnhyamp2ODVlNyt6dUhuR1pHMTBTMDNlMXBvMVpSNUFGMCtCK0pUT1dU?=
 =?utf-8?B?WXdKQWhPU1pnbVdnMFE3Q2hZQUxCMmNHTVZtUFZwYk8yT29ZcUpadEhSNW5L?=
 =?utf-8?B?U0s3Tnk3TkZsRkhSRkJrbEtScEFpWEx0bkY0Ti9RL1BVbmQ1OGpYLzhZcXBS?=
 =?utf-8?B?a2hDaFUzVktlVUFDamR6VCtWNzU4aG5NYklwa0JnQW10Z0hwTTM4RlJKM2p3?=
 =?utf-8?B?czFwZHlmdkQ4Wm5HekRqYnFUSWtXS0hkQ0Qrc3l6Zmc2V2U5MjU2VkFaRTdn?=
 =?utf-8?B?Mkc4aHZwZHFMd1RFZmljeVE5T2c2ZS9NWE5NRVQ5VExPYnZ6cndmeTM0MEFM?=
 =?utf-8?B?TGdLNHBQSi90bURpRGc3Skg2aWlmUEUrdHl4bW1xM1pTVGZkTmZsRE5OQmx3?=
 =?utf-8?B?ODFKTnR1U0VBbGhWRGM4OTVVbWE1NTU0Nk4zdzI0TktlTTluTlFrR09qSzM4?=
 =?utf-8?B?V2l4eUt4SjJ4aDMyK1JKSWZWQUI5UjROQXdURjVxTEJPdE5HSzhLaXc0K3Mw?=
 =?utf-8?B?Zmt5dnVudWFmQ1IvK1JpQ0RoUkgzemVzemFNMFBpbGUzblM4alhDaXRFRzY5?=
 =?utf-8?B?NWQrSXVDNUJka1ZqV1dQY1lpZEN1TUllZFpRSGluSWdZU1dWeWtMZWJER2RS?=
 =?utf-8?B?bWtLVE8wWHJBWGI1U2NTSUd2aWVBMWY5NnVReCt3THFod1RDSkZVRXkyR1d1?=
 =?utf-8?B?NHFUVGpkQ2NLcE96enV1Q1pXcWphL1o1b1ZVd0ZFVjIxem9ZTHJnZEs0Qi9v?=
 =?utf-8?B?NC9TZldMYVB5UWpMUm5TcUEraHlSdnF6MnNQVnhrSWY1TkxKNDRHeWZiaHhV?=
 =?utf-8?B?VC9hMEtNMjQwQlF0ZVNTckY5QXRvT1FNVDlGQ1YxSzhXbHc3TE5qVnFPcE9n?=
 =?utf-8?B?cE42cmRBY0FjWWdHZnc0akdCZXBRSzlSb29ORDIyQnZBVFNrMGQ5cHVhU0pI?=
 =?utf-8?B?QzREK1hKMXF0UGlEbDFmTElFTFloWU90RDV1YTVLMGdZdjNOVU11NzMwTlM5?=
 =?utf-8?B?RGdSdGprbVNuQUtVdEh0a2pubE45U1JIZEpLYkp0LzNBOFcxNkthWmF2Wlp0?=
 =?utf-8?B?TGdHSTdId3pNU2tQVzhqbFlqZlhZa0JRc3FWSW5TMW15c1gzV0tQL05GY1R3?=
 =?utf-8?B?N2wxaXplTGhYNWtpYU85VHdaY09VVEZWaENtR0poeTlUVnhjQkwxdGNXOXh4?=
 =?utf-8?B?Z2tXayt1VGpnRE5TMHhGazNEa2dLN2FXdTBBUzFLQmNHNmdTOVpBYWswR1JQ?=
 =?utf-8?B?Y1RlS3JocE5McFhEUkxMSzhkOHlsTGVDYzA4cXdkbkl4Y1FOd1U0ei9WMzJy?=
 =?utf-8?B?Z01QSFRZc1lYU1dsZk5iUStEWUlJTFhnV0g1enQwRUd2REZkYzZkeHN3QVZ0?=
 =?utf-8?B?dG5sUDJJdzZ4eVAzdzhWL0JCUjJEUkhlYmlad2VsWWJQbjNtM2R0MVRYeXJE?=
 =?utf-8?B?eFhvVDJmOVRMbWdSTGc3TU9Ja0FiNFpDQnlvajBjcW1SRE53Yzh4OWt3elY5?=
 =?utf-8?B?enNVQ1ZaZnlyWkN3aS84TWxSTXg4OVJLZWRIazRhV0VjTm1hRlIreXM2R05i?=
 =?utf-8?B?M1BkL0FlMExTekpZQVNtMmg0U2VLZW9ocytnb0EwYnJsT0FSdlloaStEdllL?=
 =?utf-8?B?VFhHY2dJSWI1aE5XUHFrT2RRSko1dDNzK3RoNGJodHdlVFhWbnBPVTgvWURI?=
 =?utf-8?B?Mm9JUjJHKzUvUkFFaDB2Y0VlSFZXdHBES1ZnWi9WVEFoeGlaMEFtajZ1Q1pF?=
 =?utf-8?B?Z0lHWk0yYVhpaC9YMjdvaWRlb1U2TUpxam1Gek5BSzVMWVJRNjloYzVUUzdX?=
 =?utf-8?B?aHE5MGx1bmZwTWg3MmZFTEkvYzRkR2t6c3BSL010eThDODBrUEpoN3ROVGs1?=
 =?utf-8?B?dHNybWkybUh2T1p4eVhVUGQ5M2kzMkJYY0FrT0JMdWVVTkdQQm1JRlYyV1RE?=
 =?utf-8?B?cHg2RFJjTDlxc3B2VzFPdTE4QjkxRHNDZVNtRnpLc3RzOTgrMTA3UzJGSDV1?=
 =?utf-8?B?MzZjQktHcGE3MEViQzJGUEZCemhNYmZZZVRMdFIwU3UyWm5IRDg0V1ZGSVpM?=
 =?utf-8?B?cXJDWDg4Qys5V2lCTCtZeUp4ZzdIYU9RVzh4eDNVUTg2Y3Zod2xONTFJck9N?=
 =?utf-8?B?QWc9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6b02a5ab-0498-4363-8eb2-08da8b8cb31a
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 20:09:24.4297
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: SSjSg5AXL7S4qC60mJ43Yom+ku0WXHRcmB1DI8LGL8Y0rRaElo2ythwbainZ22OS6r5biPJIZKe78etRvRgL69aDcx41Imkd1kTpsl33cXU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3116
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 8/31/2022 10:38 AM, Jarkko Sakkinen wrote:
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> ---
> v2:
> * Added comments.
> ---
>  tools/testing/selftests/sgx/alloc-error.bt | 9 +++++++++
>  1 file changed, 9 insertions(+)
>  create mode 100644 tools/testing/selftests/sgx/alloc-error.bt
> 
> diff --git a/tools/testing/selftests/sgx/alloc-error.bt b/tools/testing/selftests/sgx/alloc-error.bt
> new file mode 100644
> index 000000000000..0cc8b2e41852
> --- /dev/null
> +++ b/tools/testing/selftests/sgx/alloc-error.bt
> @@ -0,0 +1,9 @@
> +/* EPC allocation */
> +kr:sgx_alloc_epc_page /(uint64)retval >= (uint64)(-4095)/ {
> +		 printf("sgx_alloc_epc_page: retval=%d\n", (int64)retval);
> +}
> +
> +/* kzalloc for struct sgx_encl_page */
> +kr:sgx_encl_page_alloc /(uint64)retval >= (uint64)(-4095)/ {
> +		 printf("sgx_encl_page_alloc: retval=%d\n", (int64)retval);
> +}

I did see you response in [1]. I continue to find this
addition very cryptic in that it assumes global familiarity
with BPF scripting which I do not think can be assumed. I
still think this script can benefit from a comment to describe
what the script does and how to use it.


Reinette


[1] https://lore.kernel.org/linux-sgx/Yw+nCBVYfueEXVZK@kernel.org/