Received: by 2002:a05:6358:45e:b0:b5:b6eb:e1f9 with SMTP id 30csp934107rwe; Wed, 31 Aug 2022 13:50:56 -0700 (PDT) X-Google-Smtp-Source: AA6agR62Pwou4snuyx+fet3V1fIo1fRyxPLipPcHCxc3UxLXnO+EQuSq77LeoPx6YfOGctKs06dj X-Received: by 2002:a05:6402:c45:b0:442:c549:8e6b with SMTP id cs5-20020a0564020c4500b00442c5498e6bmr26213610edb.123.1661979056092; Wed, 31 Aug 2022 13:50:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1661979056; cv=none; d=google.com; s=arc-20160816; b=R9C6lt3KwyoFxTLNXPBuAv5iGnchQHwojRx4g4lDZVYZAX1USvn2LlCCHioYwyP/eF 9JJRmAj+jlAI0b6DitGp2k7XfMdmjDNQQvkmBwyCRSNI93hm1d55e7GI6ioguUge4Tga GFzQmTDJ6eFurSXG+ZlOkIGox9e3mTrHlNP6rZG2IJP1A72cpytvd2X8NrKgUgIXcIbF FDoYT3NrAPiATJqikQiX0GrRkk8m9+yJ7h/DatdLrl5XLtJT74oiUnLC+IJfjc98YvpM erQYE/qgJ9nPKj4HWF6wBym735A810hdrYz8YHSdBYPqduZ7Y812ZPwWIcoTTRRb/EiC iLeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=9zplvOIxsHmBr8MHxvPOogkzEQZgUT+IadiX1atSaQk=; b=nPuv/vJ+oP+6CW45i38AoinOv0RWIWPZmm/y4E7Xh1rH8HuxwQyRDOivWnhXyT792W L3RIpkzVojQaErtJ3F3BIRwpJpJh1DPtY3JW0/2AnvizYNGqfgDBcDYwEcJmMNasSWsM 0tXyZz9CPsS8ctZ+c79w/Bqd2C6qPUfUMAiV6ErOCwl81GymvCMuogMnvzJEKEPZpK/i sRbYpsp8fEW1N+sWFHzGhut0xjG52g9kIMdN4YdQxz0aKuINySdWGIoMOXdLv5IE8CoZ Dyhe9ncqT1FArtbiV9c9WZxFRT/ccMyUQs0QCPachGq/H9dRG0il/SC+ioxpoddjZ6Kv hfwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Vej9rMn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d20-20020a1709061f5400b0073c1e339952si10775834ejk.339.2022.08.31.13.50.29; Wed, 31 Aug 2022 13:50:56 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Vej9rMn3; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231800AbiHaT6x (ORCPT + 99 others); Wed, 31 Aug 2022 15:58:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229531AbiHaT6v (ORCPT ); Wed, 31 Aug 2022 15:58:51 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2740DEEF0E; Wed, 31 Aug 2022 12:58:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6A42CB822DC; Wed, 31 Aug 2022 19:58:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DADFAC433D6; Wed, 31 Aug 2022 19:58:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1661975927; bh=sm71GH8RVOSxlkmJw9DILKfIbjQQHhnDtzuUCa7a+A0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Vej9rMn33tgVQT64mL5+CPKnapndlNftAjpvlda+Pz3I9N+p+I/q14iTsqJx976q4 eevdCgu1CrjQ0B5kqPbvsmoXek9099Vn80KOK2HUGQ4+kb65ogp22XWZ9fHURNmGdN Ekch00ehgnJ85hzsTFx92en+IX6gh/JWuwXekQblocAfMAi9M9EdLcjyOl8EKnKgxC vYwIELkJ/aVmfPd4lmrICTdPLU9Ez7XQTLAoaVIrxSWHy4C1a05XgSeeMG3uX93L/B 0ZpoA+++LJGJnUep8F/+u403I2aqcb3/zT/lnk0kSrNUql9cuG6Me59pPeePL59v1M ag+Onf8Noz9gQ== Date: Wed, 31 Aug 2022 12:58:46 -0700 From: Jakub Kicinski To: cgel.zte@gmail.com Cc: davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, xu.xin16@zte.com.cn Subject: Re: [PATCH v3 0/3] Namespaceify two sysctls related with route Message-ID: <20220831125846.6bb2983a@kernel.org> In-Reply-To: <20220830091453.286285-1-xu.xin16@zte.com.cn> References: <20220830091453.286285-1-xu.xin16@zte.com.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 30 Aug 2022 09:14:53 +0000 cgel.zte@gmail.com wrote: > With the rise of cloud native, more and more container applications are > deployed. The network namespace is one of the foundations of the container. > The sysctls of error_cost and error_burst are important knobs to control > the sending frequency of ICMP_DEST_UNREACH packet for ipv4. When different > containers has requirements on the tuning of error_cost and error_burst, > for host's security, the sysctls should exist per network namespace. > > Different netns has different requirements on the setting of error_cost > and error_burst, which are related with limiting the frequency of sending > ICMP_DEST_UNREACH packets. Enable them to be configured per netns. One last time, if v6 doesn't need it, neither should v4. Seems like you're just trying to check a box. I'm dropping these patches from patchwork, please don't repost them again, unless someone from the community voices support for merging them.