Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Keller, Jacob E" <jacob.e.keller@intel.com>
To:     ivecera <ivecera@redhat.com>,
        "Laba, SlawomirX" <slawomirx.laba@intel.com>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "Piotrowski, Patryk" <patryk.piotrowski@intel.com>,
        Vitaly Grinberg <vgrinber@redhat.com>,
        "Brandeburg, Jesse" <jesse.brandeburg@intel.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
        "David S. Miller" <davem@davemloft.net>,
        "Eric Dumazet" <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Paolo Abeni <pabeni@redhat.com>,
        Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
        "moderated list:INTEL ETHERNET DRIVERS" 
        <intel-wired-lan@lists.osuosl.org>,
        open list <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net v2] iavf: Detach device during reset task
Thread-Topic: [PATCH net v2] iavf: Detach device during reset task
Thread-Index: AQHYvEjk1CGq6TaBGUCRbbEbTVSolK3H64sAgACsCwCAANrVMA==
Date:   Wed, 31 Aug 2022 20:09:11 +0000
Message-ID: <CO1PR11MB508906BBD9F721E08C79CA8DD6789@CO1PR11MB5089.namprd11.prod.outlook.com>
References: <20220830081627.1205872-1-ivecera@redhat.com>
        <DM6PR11MB31134AD7D5D1CB5382A5052887799@DM6PR11MB3113.namprd11.prod.outlook.com>
 <20220831090540.53e324af@p1.luc.cera.cz>
In-Reply-To: <20220831090540.53e324af@p1.luc.cera.cz>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bi7kPp1N/Wtkj5NJjMfYcVWWfn6U/+orimyJaz4U/faq+0GCk2f9LylSh5Ye?=
 =?us-ascii?Q?u6EX0xwziR+nDDVhhMF6997BeLi8jY1TEpL0JYf1ur3Qe1+7FcTa5EfqlFlo?=
 =?us-ascii?Q?J0SmpcgbpaAc4n8Fl1AtaxfBan0ukyN8+PzhSINizD6kPjnB0F/8bSG4eWxr?=
 =?us-ascii?Q?+Fce6xw9cBKKlkmUnc7tyLa7ewoNOZ+ntfcTnStuGlx+p/4Sux3R5t0zFpRO?=
 =?us-ascii?Q?8N/59eOCQEuKmfi+gPUhjUcR8TqTVappbeBJQmPBbHTEi0xgV5I+xg2HlJ6B?=
 =?us-ascii?Q?zYLjvlqIEJ+FlEZCkfNCZhmwT9NOm2NPeMk81l3YTsB1IvSCeynglhqgmLNZ?=
 =?us-ascii?Q?lwQhrrWCCam5ArrT2VZJ8Mdtem7vutTdqBP92N36sCWIeUPY1eUfF6FyXgS5?=
 =?us-ascii?Q?IDGX9sAaTOfnTETSa8fhc9oAGEUaN3UJZLWOPO4uRqRo5K+PFXrPqfv6ulzt?=
 =?us-ascii?Q?pzT4kvdUtuveqhDKChbHN8R3zadUpK95X0BPydFIfyVD0izj23v7btSyAwEt?=
 =?us-ascii?Q?hu5vCDqu8/d8Fih7xTGRU/cOQSK+Zp/nP3kmgVw7/LuBX0OL9beDiMJs5OZm?=
 =?us-ascii?Q?Sjb8/jcWRqgfgZVJI7bbJ72kD2Qm/QlFNV5JEjwQQmzhnwSi5mgJsqDTBonC?=
 =?us-ascii?Q?zqv7FoK4+JXBjUTuHlSBxG2oVp649L9cyu5ni74EGNxdzA2eRuh3SoSgJFK0?=
 =?us-ascii?Q?HdRMRKCzkdfsVofutPBwFYHlqnm74qKmTsbbv6OokFNlS3DM/N0DPOgElsLy?=
 =?us-ascii?Q?h7FrjssmH3HhDE1vU3l1mnBpxYCym1FmUf7DKdy2uTvrK+JpIFxuV01YZwnE?=
 =?us-ascii?Q?XCUW14YmROJLS/RheiUHPjwuHhEKJRU9LYPM+e2ZQ1zZpcP+n8zKPLc2kqnH?=
 =?us-ascii?Q?zn9wuRKVdDCE71jOGRsvRAlJwuGRNLie17nxYZtDltkmYcFK/qHYO/OHcySH?=
 =?us-ascii?Q?jPGGqmJqlSGVbuFWEyH1Eh41f0GnW4wLa7LO+ZAWgjwGgWfV4IjB/GSinYLX?=
 =?us-ascii?Q?6gYsYldapwtQWtzRBn/fRedLy857icREgMtMHVpYsMAYysJ7snwi6WNWhD40?=
 =?us-ascii?Q?PZrWjJ0P7upa9fozcXB9JhcA55n52iNFuqaapMsT/JPLFtyfSYEU5ngTv+Ff?=
 =?us-ascii?Q?QLE3+M2WMLoi51Q7Q/Q1zac6JE75qRVGX4sqpsjCAdsUG4FI+GYbM/uKolci?=
 =?us-ascii?Q?zwkIfksd2iKaHWRXYL09m2grHR1waBi9a9TW/gLzZeBEuEwXF0Hamm4RgH9T?=
 =?us-ascii?Q?qbFq7R91m0A96Xa86lyyJLl+vdz1LRylDngX04N6y7/lwy1x+IxBhPQSebQN?=
 =?us-ascii?Q?0/6ay3dlgrhPBHXp62lPLOEQQmpTX3TZiZbRY/57oGz2R/wSTQI0Xw1gxw+O?=
 =?us-ascii?Q?t9U4F7X5NGAOeDxzqkvGMXSv+/ua57DPygi4wv7OeCd5AzafUvfJ1gsRQ+5e?=
 =?us-ascii?Q?mExsQ7kBpaFtPtUdk4Z38Gyr9feFgWj2LrTrtDc5mbo6ERQOcNoc5dBpckjO?=
 =?us-ascii?Q?Dvs1DpJl+ciRUBwklGeeEBEgBcxoqVa74c42x/0ffdBLtGNU5dcy1HYsliVc?=
 =?us-ascii?Q?ssoM8f8u9ugwfrBH+SB90N09qOccbsOhMIcvLykM?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: CO1PR11MB5089.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ac5e1f9a-c76b-481c-5972-08da8b8cab72
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Aug 2022 20:09:11.4113
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: e433GESpcDQwEeRMdzAcLGkI64xFsjblIb78VMUjrkRJz8jHUaqOoUtZn24M9LBS8DHVSambCCOtybbDlRXVq/laacvqmSY0MMLs729fFiA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6951
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Ivan Vecera <ivecera@redhat.com>
> Sent: Wednesday, August 31, 2022 12:06 AM
> To: Laba, SlawomirX <slawomirx.laba@intel.com>
> Cc: netdev@vger.kernel.org; Keller, Jacob E <jacob.e.keller@intel.com>;
> Piotrowski, Patryk <patryk.piotrowski@intel.com>; Vitaly Grinberg
> <vgrinber@redhat.com>; Brandeburg, Jesse <jesse.brandeburg@intel.com>;
> Nguyen, Anthony L <anthony.l.nguyen@intel.com>; David S. Miller
> <davem@davemloft.net>; Eric Dumazet <edumazet@google.com>; Jakub Kicinski
> <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; Jeff Kirsher
> <jeffrey.t.kirsher@intel.com>; moderated list:INTEL ETHERNET DRIVERS <int=
el-
> wired-lan@lists.osuosl.org>; open list <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH net v2] iavf: Detach device during reset task
>=20
> On Tue, 30 Aug 2022 20:49:54 +0000
> "Laba, SlawomirX" <slawomirx.laba@intel.com> wrote:
>=20
> > Ivan, what do you think about this flow [1]? Shouldn't it also goto res=
et_finish
> label?
> >
> > 	if (i =3D=3D IAVF_RESET_WAIT_COMPLETE_COUNT) {
> > 		dev_err(&adapter->pdev->dev, "Reset never finished (%x)\n",
> > 			reg_val);
> > 		iavf_disable_vf(adapter);
> > 		mutex_unlock(&adapter->client_lock);
> > 		mutex_unlock(&adapter->crit_lock);
> > 		return; /* Do not attempt to reinit. It's dead, Jim. */
> > 	}
> >
> > I am concerned that if the reset never finishes and iavf goes into disa=
bled state,
> and then for example if driver reload operation is performed, bad things =
can
> happen.
>=20
> I think we should not re-attach device back as the VF is disabled. Detach=
ed device
> causes that userspace (user) won't be able to configure associated interf=
ace
> that is correct. Driver reload won't cause anything special in this situa=
tion
> because during module removal the interface is unregistered.
>=20
> Thanks,
> Ivan

I agree. It's safe to remove a detached device.

Thanks,
Jake