Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <75e0121d-2d24-4e72-8514-412d1fd0d23b@intel.com>
Date:   Wed, 31 Aug 2022 13:08:25 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Firefox/102.0 Thunderbird/102.2.0
Subject: Re: [PATCH v2 5/6] selftests/sgx: retry the ioctls returned with
 EAGAIN
Content-Language: en-US
To:     Jarkko Sakkinen <jarkko@kernel.org>, <linux-sgx@vger.kernel.org>
CC:     Haitao Huang <haitao.huang@linux.intel.com>,
        Vijay Dhanraj <vijay.dhanraj@intel.com>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "Paul Menzel" <pmenzel@molgen.mpg.de>,
        Shuah Khan <shuah@kernel.org>,
        "open list:KERNEL SELFTEST FRAMEWORK" 
        <linux-kselftest@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
References: <20220831173829.126661-1-jarkko@kernel.org>
 <20220831173829.126661-6-jarkko@kernel.org>
From:   Reinette Chatre <reinette.chatre@intel.com>
In-Reply-To: <20220831173829.126661-6-jarkko@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFk1cWk5d1lVSTFSSlVXWkE0elhYU0lmbFJwNTRBYmZLb0M1U0ZuYU1zYmJT?=
 =?utf-8?B?bzFVUFF4N1F6TGEvOGYxUmhpdmRkZTl6Q3lZREFLdjdMNTVJSkhRRUlrbFIr?=
 =?utf-8?B?VWpiaDdmNlVoOHZZVStLY0FwZ2ZzdlhYTjgvSk1Jd1k5SVlDNHUwdmo0bnEy?=
 =?utf-8?B?Q3F4eUZLTmxpMmlHMDh0N1ZGNytlWlF2N2NZZHdUNnlXWDNkbjkxeERmcFVG?=
 =?utf-8?B?TGJhN3ZPeFVicFN6RzNKcndPbzI5YUNvQXZGbWhDNXRFSHF2dU5ZeDJVa2RT?=
 =?utf-8?B?UThSbEtIUUFON3laY2F0aEp3N1g2N1g2Sng3YVo5bGxPdHg1UlZiVU5ON3hR?=
 =?utf-8?B?akttejJ0elJJR3p4M1pnQWwzbkFyanZTZy9Fby9tSFl0T2MzNFVLVEVLSUx0?=
 =?utf-8?B?a1U3NUV0OU4yai96MzAvbnRabWJsV21nbnlzZlZCd1kzajUyU3FDU1ZTM2Zo?=
 =?utf-8?B?clBOSE12VlFOakJpRFJYTzVxUG1JYnVLRG1XbWVwZWpNZUt4UFBqS2NKclM4?=
 =?utf-8?B?M0Npdi9BNWlXb0ZKbTB5OHdMcFJzeGZqZ3hDaEhtQTNRdzNFMWpWMlVIVHpm?=
 =?utf-8?B?dlpKWTNVTnNNK1FYMG1qMGRmczFkS0tpVUxtQnlHR3JETmtXRWZYR3lpME9s?=
 =?utf-8?B?NThWNEl5K0E1LzRTYWlzZC9mK0Z6N1NGNnFPdUsxQ21kOWZPeVV4YmthM1F1?=
 =?utf-8?B?OGovUzhyRlhYQVp3SnVBLzJTOWZqTmd1ZkswT25xQnJzczVUWUNabHlTdDFv?=
 =?utf-8?B?TVFRNHpBVnNHa0lKYmhTSVNPNkpqMytsN0lIckg2cEFSSGEvSlUyZlJ4OFRT?=
 =?utf-8?B?eHJGVFhnODBvOHdxODMvUnZzWlZWeWU3aHBUcnA2TzdEQlk3SHgzV3F2N2Yx?=
 =?utf-8?B?RHBUQUZPZ2pFQWhpWWpHK2ZJd1U5cVFNQ1gzck5WOVd3MlBmRk5mWUlyczlm?=
 =?utf-8?B?NHFOaEtqNDlIMjJ6T1R6L3JpNk91NGpuSVVYV0U4ZElkbUw0WklOQlQ3Wm0x?=
 =?utf-8?B?azFybVI3ZXRuR09McEFWRURNcC8zUXM4RUd1ZGNYMjVnSHRTa25LY252UE5v?=
 =?utf-8?B?eVJjbTZvU2FJZlZ3NTI3R2d2aTE3RjZvcThsVExWcmZBaUFDY25DR1NjVXpT?=
 =?utf-8?B?a2tVbHhsaFFZY0VrWkZ6VmpIMkR0MldIOFpTcTFyQ0JqOG9mUnIrYkt6SGpO?=
 =?utf-8?B?S3lqOHV6KzBabEd6RExxR3cvQ3R1VHU0OUl6Z1FSeC9CK0dLWm5vcmVodW5M?=
 =?utf-8?B?MEtKenBzcDRoSmxKNUdyUGI5YmVFV01pMjZ6Syt1SjZzZWhOd3ZaMXY0QTlm?=
 =?utf-8?B?RGxRczJZQ1JVZzhPWG1aZEN2U09PSjBEZ3oxSE5Sam5mZStVOFhaTGdvYnZB?=
 =?utf-8?B?WEdOVkhHd2VqS2YyZ1BYOHgxNytuaG8ydjh3SWpQWkFERldjNWFvNVptR3Nn?=
 =?utf-8?B?eXBXbUsxNk9ZVlliSDRJYlliMEdMSkRIRUpRQWZPOUM5eGVGZ0g4Zlhrbitm?=
 =?utf-8?B?ZFpiSzlwWDVzY0E3ZTlIWmZ5YXZhaW45YjFibEorQml3OHRLNjI4RHpuZUIx?=
 =?utf-8?B?T1g4MVRlWE9jVVNTcytZOE1HMC9iNWdOUzIwalNXY1lHL0JlS0lYN1RIWnJh?=
 =?utf-8?B?emhmY05SUXp2cndWcVFFcXkwT0RnWlRKRHp0VEZBV05RbUszTVlzOWVaZlQy?=
 =?utf-8?B?M2dDY0hQQ1luc2xQOWlpVGhEMUJIQXgyWUpHR1IwQVlGUkIyZ08rMUpsTHFN?=
 =?utf-8?B?Yzh6NUFnOGdwbGJxdHdqd2t5dUlESkVMTklUWERWZEpVM3BQZFExd0M0ck1M?=
 =?utf-8?B?bFBDS2xsZzQ5YzFwUDF4YzArOVRXVEN3d2xRSWRZbzRZOHJrbndGcUpvdXpn?=
 =?utf-8?B?TFg0dFlwRXp4RTBFRjE5dWpvWXJJai9GRmNYMmR6MHhlZy83a1dCODlOQlFN?=
 =?utf-8?B?bXZLSXhEbk9tbnNwaStONE5GRU9LamViZmZPS003K3BBSXBMeXQrMkZ1QU85?=
 =?utf-8?B?b0czTjRqVjVHNmtNbERBZGxIWFBOKzZjdU9lMnMyTVNveU5HMlhqRE1SWlp3?=
 =?utf-8?B?WVdQR3pTNFdKWmVSN0dIQUNvTDljeWc4M1NRbmRLUzFTeUsrOFdxK3h0eXkw?=
 =?utf-8?B?MTEwYmhzZ0UzSUFObTJKM2ppVU5VVDlwcHgzNnE3d0M3Ymxod1FFTDhVWjVB?=
 =?utf-8?B?ckE9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 6fc76224-8ec7-4354-8ac8-08da8b8c9145
X-MS-Exchange-CrossTenant-AuthSource: CY4PR11MB1862.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2022 20:08:27.6532
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: DjCNbGqiQIUZNUBZm5Trm3X0IPCGqb1c0s9MpTYPrO1MS0LYWY1GFr4xfK6g24X0t556sPJidNpqCH1BnXN1bVKk8aVCCAw5XD3f1zsHzu4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3116
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,
        RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jarkko,

On 8/31/2022 10:38 AM, Jarkko Sakkinen wrote:
> @@ -458,16 +459,30 @@ TEST_F_TIMEOUT(enclave, unclobbered_vdso_oversubscribed_remove, 900)
>  	modt_ioc.offset = heap->offset;
>  	modt_ioc.length = heap->size;
>  	modt_ioc.page_type = SGX_PAGE_TYPE_TRIM;
> -
> +	count = 0;
>  	TH_LOG("Changing type of %zd bytes to trimmed may take a while ...",
>  	       heap->size);
> -	ret = ioctl(self->encl.fd, SGX_IOC_ENCLAVE_MODIFY_TYPES, &modt_ioc);
> -	errno_save = ret == -1 ? errno : 0;
> +	do {
> +		ret = ioctl(self->encl.fd, SGX_IOC_ENCLAVE_MODIFY_TYPES, &modt_ioc);
> +
> +		errno_save = ret == -1 ? errno : 0;
> +		if (errno_save != EAGAIN)
> +			break;
> +
> +		EXPECT_EQ(modt_ioc.result, 0);
> +
> +		count += modt_ioc.count;
> +		modt_ioc.offset += modt_ioc.count;
> +		modt_ioc.length -= modt_ioc.count;
> +		modt_ioc.result = 0;

From the discussion in V1 it seemed that you were planning to add a check
on the result value instead of just overwriting it. Are you still planning to
do this?

Reinette