Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <1d5510f7-7c2d-6e30-f5d9-e45c470c380a@gmail.com>
Date:   Wed, 31 Aug 2022 14:50:51 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH] libbpf: Initialize err in probe_map_create
Content-Language: en-US
To:     patchwork-bot+netdevbpf@kernel.org
Cc:     bpf@vger.kernel.org, andrii@kernel.org, ast@kernel.org,
        daniel@iogearbox.net, martin.lau@linux.dev, song@kernel.org,
        yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org,
        sdf@google.com, haoluo@google.com, jolsa@kernel.org,
        davemarchevsky@fb.com, linux-kernel@vger.kernel.org
References: <20220801025109.1206633-1-f.fainelli@gmail.com>
 <165964981402.20332.403823292048774488.git-patchwork-notify@kernel.org>
From:   Florian Fainelli <f.fainelli@gmail.com>
In-Reply-To: <165964981402.20332.403823292048774488.git-patchwork-notify@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 8/4/2022 2:50 PM, patchwork-bot+netdevbpf@kernel.org wrote:
> Hello:
> 
> This patch was applied to bpf/bpf-next.git (master)
> by Andrii Nakryiko <andrii@kernel.org>:
> 
> On Sun, 31 Jul 2022 19:51:09 -0700 you wrote:
>> GCC-11 warns about the possibly unitialized err variable in
>> probe_map_create:
>>
>> libbpf_probes.c: In function 'probe_map_create':
>> libbpf_probes.c:361:38: error: 'err' may be used uninitialized in this function [-Werror=maybe-uninitialized]
>>    361 |                 return fd < 0 && err == exp_err ? 1 : 0;
>>        |                                  ~~~~^~~~~~~~~~
>>
>> [...]
> 
> Here is the summary with links:
>    - libbpf: Initialize err in probe_map_create
>      https://git.kernel.org/bpf/bpf-next/c/3045f42a6432
> 
> You are awesome, thank you!

Thanks for applying, I was sort of expecting this patch to land to Linus 
a bit quicker, as far as I can see it is still only in linux-next yet it 
does fix a build warning turned error. Any chance of fast tracking it?

Thanks!
-- 
Florian