Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: bWfHGvBUtIsRhu2gW4wI1sQb+16uY48gizIIfO0SRv0TELyW0NZfuBam7xaFBqZaUiAFYutGyG
 AXqoS2bcQ2B8bjR5T9itRAxLDky/vDaNtQbJPYoKV1q1BUV2m2wbr/qDlZS9VvOcd+LzN8Xp/m
 Qk3zoe1JcyLkmvprsEyl9gUWqnQOKxJ5IRfIXyZk7W6+giR+KxmEkfLGl1CNPwPFymhrFbvePv
 w2fiIL0QSJQMjPBXqX3RzW8qV+ytPP9PuCN2FX2w4mrdFS7Rs/rIqeVPBBDUvgG98IaWN4RE8g
 AW5chsyrq7XAT11H0YhEb/Z9
IronPort-SDR: v/9UOPcnz8Ems1wGGgYsjW22qvNwOzpwP3kgodGQsFvvcLSwTJUnycSZKyBr+Pqg7FzrXFw7hY
 Vn8IHZoID5WFaEzEQZl2RcejBUx6CuXxLjWAiGf1wPvJjSpSaZcJQcgsCPmGcCTBsgP1hVlNqw
 0zOoUno28Sgt2MFAs875mdWhVdJdqCWklD+DR4suai5vKiCwYMYAdc1ZHyouk7w9poPFh5RTBo
 PewKLnGf/liUCGz2tMF4vbEjKimYo5NI2SThqRQrKi+0gdJa1h6N8uJzzg1yKTeYbCgTZYGC7w
 9IE=
WDCIronportException: Internal
Message-ID: <b2a4ba8c-c67b-3041-9b81-783611de0763@opensource.wdc.com>
Date:   Thu, 1 Sep 2022 09:23:58 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.0
Subject: Re: [PATCH] scsi: csiostor: convert sysfs snprintf to sysfs_emit
To:     Xuezhi Zhang <zhangxuezhi3@gmail.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, bvanassche@acm.org,
        johannes.thumshirn@wdc.com, himanshu.madhani@oracle.com,
        zhangxuezhi1@coolpad.com
Cc:     linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220831141046.406837-1-zhangxuezhi3@gmail.com>
Content-Language: en-US
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220831141046.406837-1-zhangxuezhi3@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 8/31/22 23:10, Xuezhi Zhang wrote:
> From: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
> 
> Fix up all sysfs show entries to use sysfs_emit
> 
> Signed-off-by: Xuezhi Zhang <zhangxuezhi1@coolpad.com>
> ---
>  drivers/scsi/csiostor/csio_scsi.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/scsi/csiostor/csio_scsi.c b/drivers/scsi/csiostor/csio_scsi.c
> index 9aafe0002ab1..39e8c3c26a19 100644
> --- a/drivers/scsi/csiostor/csio_scsi.c
> +++ b/drivers/scsi/csiostor/csio_scsi.c
> @@ -1366,9 +1366,9 @@ csio_show_hw_state(struct device *dev,
>  	struct csio_hw *hw = csio_lnode_to_hw(ln);
>  
>  	if (csio_is_hw_ready(hw))
> -		return snprintf(buf, PAGE_SIZE, "ready\n");
> +		return sysfs_emit(buf, "ready\n");
>  	else

While at it, you could remove this useless else here.

> -		return snprintf(buf, PAGE_SIZE, "not ready\n");
> +		return sysfs_emit(buf,  "not ready\n");

Extra space after the ",".

>  }
>  
>  /* Device reset */
> @@ -1430,7 +1430,7 @@ csio_show_dbg_level(struct device *dev,
>  {
>  	struct csio_lnode *ln = shost_priv(class_to_shost(dev));
>  
> -	return snprintf(buf, PAGE_SIZE, "%x\n", ln->params.log_level);
> +	return sysfs_emit(buf, "%x\n", ln->params.log_level);
>  }
>  
>  /* Store debug level */
> @@ -1476,7 +1476,7 @@ csio_show_num_reg_rnodes(struct device *dev,
>  {
>  	struct csio_lnode *ln = shost_priv(class_to_shost(dev));
>  
> -	return snprintf(buf, PAGE_SIZE, "%d\n", ln->num_reg_rnodes);
> +	return sysfs_emit(buf, "%d\n", ln->num_reg_rnodes);
>  }
>  
>  static DEVICE_ATTR(num_reg_rnodes, S_IRUGO, csio_show_num_reg_rnodes, NULL);

-- 
Damien Le Moal
Western Digital Research