Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 31 Aug 2022 19:12:18 -0700
From:   Dmitry Torokhov <dmitry.torokhov@gmail.com>
To:     ChiYuan Huang <u0084500@gmail.com>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Lee Jones <lee@kernel.org>, cy_huang <cy_huang@richtek.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        linux-input@vger.kernel.org
Subject: Re: [PATCH v4 3/3] input: misc: rt5120: Add power key support
Message-ID: <YxAVAt2eWB3NFlrk@google.com>
References: <1660100142-32493-1-git-send-email-u0084500@gmail.com>
 <1660100142-32493-4-git-send-email-u0084500@gmail.com>
 <Yw/lC9rjnbFW3ORC@google.com>
 <CADiBU38AuVW9yeFisKvK=_080tQzn-1PUxsDXH4p0QrA2AUSww@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CADiBU38AuVW9yeFisKvK=_080tQzn-1PUxsDXH4p0QrA2AUSww@mail.gmail.com>
Precedence: bulk

On Thu, Sep 01, 2022 at 08:39:05AM +0800, ChiYuan Huang wrote:
> Dmitry Torokhov <dmitry.torokhov@gmail.com> 於 2022年9月1日 週四 清晨6:47寫道：
> >
> > Hi ChiYuan,
> >
> > On Wed, Aug 10, 2022 at 10:55:42AM +0800, cy_huang wrote:
> > > +MODULE_AUTHOR("ChiYuan Huang <cy_huang@richtek.com>");
> > > +MODULE_DESCRIPTION("Richtek RT5120 power key driver");
> > > +MODULE_LICENSE("GPL v2");
> >
> > I changed this to be simply "GPL" (per checkpatch.pl, see commit
> > 'bf7fbeeae6db module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2"
> > bogosity' for details) + did a couple of minor edits, and applied, thank
> > you.
> >
> Ok, got it.
> Old "GPL" text as GPL v2 or "later", and  the "later" keyword is the problem.
> This patch is to fix it.
> 
> How about the SPDX license string? The same definition?

No, MODULE_LICENSE() is sorely for symbol resolution during module
loading, so GPL vs GPLv2 or later, etc is all the same. SPDX denotes
the actual license for the source code that governs derivative works,
etc. and I did not change it - it is left exactly as you sent it:

// SPDX-License-Identifier: GPL-2.0-only

Thanks.

-- 
Dmitry