Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 13:29:41 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     <isaku.yamahata@intel.com>
CC:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
        "Sean Christopherson" <seanjc@google.com>,
        Kai Huang <kai.huang@intel.com>,
        "Will Deacon" <will@kernel.org>
Subject: Re: [PATCH v2 01/19] KVM: x86: Drop kvm_user_return_msr_cpu_online()
Message-ID: <YxBDRaAyRpyz/5Q+@gao-cwp>
References: <cover.1661860550.git.isaku.yamahata@intel.com>
 <f63a395ead4204d44cab3b734c99b07f54c38463.1661860550.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <f63a395ead4204d44cab3b734c99b07f54c38463.1661860550.git.isaku.yamahata@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?qwF9jb4SoFTj9DP+/Gfuci14XJiau0QoNkGp43ywt3ZnhVPN8NhMNHzdddVH?=
 =?us-ascii?Q?cLqY+m9ks/lQ/T8xKoZctouKB81NzTMZsx6+dVudkOSsn+YUmChM7V4VlWmW?=
 =?us-ascii?Q?K2lGdAO9j5w6yaajr7LZxcbZiVKPjJHQ1kZJbHF7AV5Eap3Un4YX+w2LeDOI?=
 =?us-ascii?Q?XGmhzy+PCZpx2NvKT3/CiKLA/T9us9FCmVRoDGOy4abAJYjTC37ztXAhmNtM?=
 =?us-ascii?Q?k5sjSCnVgsTYXclCvoQtoSu8TBc5i6nzZHOwkyQG7pMLS0R5kdmar+mHCqGo?=
 =?us-ascii?Q?I/+HxDF9wxGrzlgOYHZKtkc7ShUfxGt/FzidABGWxHRc5cs0qV4ddqIilSpy?=
 =?us-ascii?Q?jrjpqPzpfoBgfsiJYrEfBTRbWbydPhD0XICarYem35290bv0bgoQTHLQmRyS?=
 =?us-ascii?Q?UKYltzhLxyFSELEknIHcPyJjywm1DhETaHmL1um8Pz7F8d2X+K3iRIMHPj/R?=
 =?us-ascii?Q?NTwyTAFdJ2Cp60wpywT6Yq56vJMNFaKAIKO5ADI/cx5tl6jJmGR9wN9lMCK3?=
 =?us-ascii?Q?PgfnH1YaOV0fhzn8mm2OjzvgWyvRughEZuM7ZW/25k/+VhgIBE7L+rDe013b?=
 =?us-ascii?Q?tUVJdX5wXAuVdBOP8A33IEQ7YSx2QfdZNAhdBsB2Y2T2iomLZeKzDTcwTpk1?=
 =?us-ascii?Q?fk0lH04LxPCf7uOWS+46Q0KKlqwIPRy1Q8ReCNwgnLGpLu6b0JPQlUldmAqN?=
 =?us-ascii?Q?uVojW1WU8DxHLgXaez0qLCv6ZfNAdCBJPo6bfOX6aeoLK2isirLW0WG9gzrA?=
 =?us-ascii?Q?/yNHaajAAeziS6HEJzHGibj3TGZbP4WsdrOCa+PQHN6uMEEMXO3wgpZi9myp?=
 =?us-ascii?Q?MWFSrglYJ8i7Jm4xZnTw+P4fBFDDCzwmo4Q6Du9VKK9WDGONWcGS5aVW7169?=
 =?us-ascii?Q?PjLr9b5FTZppCkBMEYYJiwHO84fZKelkGnC7YqTFvVb8NEOFgjfDtNlHKeBP?=
 =?us-ascii?Q?vdcvWF3dedtA3VVICfE9kM1fdN3/EYM+M0fCaOjtiyWXvfLH8xx18bz5NqTJ?=
 =?us-ascii?Q?1Qv4ASYcRg3z5jxZZ+XlbMpqYomdLFC6X9RaYy+5e9UnSgtzBOS38LRSoiNM?=
 =?us-ascii?Q?MX96U76b+2E8pk5nWBq1nM9hurTwLHRFgEk/mtokKvVJniO2O1rOzoH+flrQ?=
 =?us-ascii?Q?LIBbQCFu5cmuKN0KN3ACz2iNsM8xKaRIxUTwrm/rzosL/gadPCF3R1n3g/X5?=
 =?us-ascii?Q?6ltp0t1D9JpYNZ8+P58b/RR0shHjYC7p3kYBmdMAf0kc3qEKdx25pd00xutb?=
 =?us-ascii?Q?FAgRxXlVbHtTtlRjkeO47o2RRfJpxHCN+D/lwfgI15+7/CoXJ82ievBXmN+s?=
 =?us-ascii?Q?AMKTPFF7ftjx0XsWpGy0tToBraMZ1SOxqyIQsNYIxXBWmos+W/L+zDhTaeH4?=
 =?us-ascii?Q?UsqzXxOmeL6+LxezDmzHkXipdiWnhoS2Br3UBtm+s21I0amlfDax+vAowvlq?=
 =?us-ascii?Q?HCZqGZJEszrQ8w7Ac3KMlVD0smKAKnd+3sznppzqPG2u/ZCw6P0eauEtGkJI?=
 =?us-ascii?Q?BaTBzuYw4/tJqjkY9pj1uC/n/ve76XydUX6oelfn78ntkvPOzbi2BB61MaE7?=
 =?us-ascii?Q?CZFBxlzTCloM+1KKT+agFRZ9zpLJJrwhpIxg7/9Z?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9ed42109-8858-4597-4378-08da8bdafb21
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2221.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 05:29:45.9832
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: TpMg7wps7Rs3Hz0I4z5ePgrgqEJa+Ke97SC07J0lQs+rpAWduGqZ4OBSHbTeHy9SK2tM1Ad3uNcOvc86f/rCTQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR11MB5785
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 30, 2022 at 05:01:16AM -0700, isaku.yamahata@intel.com wrote:
>From: Isaku Yamahata <isaku.yamahata@intel.com>
>
>KVM/X86 uses user return notifier to switch MSR for guest or user space.
>Snapshot host values on CPU online, change MSR values for guest, and
>restore them on returning to user space.  The current code abuses
>kvm_arch_hardware_enable() which is called on kvm module initialization or
>CPU online.
>
>Remove such the abuse of kvm_arch_hardware_enable by capturing the host
>value on the first change of the MSR value to guest VM instead of CPU
>online.
>
>Suggested-by: Sean Christopherson <seanjc@google.com>
>Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>
>---
> arch/x86/kvm/x86.c | 43 ++++++++++++++++++++++++-------------------
> 1 file changed, 24 insertions(+), 19 deletions(-)
>
>diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>index 205ebdc2b11b..16104a2f7d8e 100644
>--- a/arch/x86/kvm/x86.c
>+++ b/arch/x86/kvm/x86.c
>@@ -200,6 +200,7 @@ struct kvm_user_return_msrs {
> 	struct kvm_user_return_msr_values {
> 		u64 host;
> 		u64 curr;
>+		bool initialized;
> 	} values[KVM_MAX_NR_USER_RETURN_MSRS];

The benefit of having an "initialized" state for each user return MSR on
each CPU is small. A per-cpu state looks suffice. With it, you can keep
kvm_user_return_msr_cpu_online() and simply call the function from
kvm_set_user_return_msr() if initialized is false on current CPU.