Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 13:56:26 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     <isaku.yamahata@intel.com>
CC:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
        "Sean Christopherson" <seanjc@google.com>,
        Kai Huang <kai.huang@intel.com>,
        "Will Deacon" <will@kernel.org>
Subject: Re: [PATCH v2 02/19] KVM: x86: Use this_cpu_ptr() instead of
 per_cpu_ptr(smp_processor_id())
Message-ID: <YxBJiquDmmdfD1fu@gao-cwp>
References: <cover.1661860550.git.isaku.yamahata@intel.com>
 <920dfe48e7255c2224a799386d720f34b4479e1a.1661860550.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <920dfe48e7255c2224a799386d720f34b4479e1a.1661860550.git.isaku.yamahata@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VPIGwVlzZRN77MbQzPonIMJ68ELrofSRWykDEUuRwD4+Fs/1EGIG/SWFQ7rS?=
 =?us-ascii?Q?OPxtC8+8vkUq1MLRFjIcDkEbIYmTzwSGTIuAa+HRk3fWbRgwK+18SXF3I+4N?=
 =?us-ascii?Q?jmSD0lOJMnLG5EHbje8Rs5c6oIbi4zEj8lTHUDX+wpiPlNB80kFUOZIkiHv8?=
 =?us-ascii?Q?dsW/ETloppJwYAH7v1HEX7el03rOvigtmdEp7UxhZ4nuAwZsvHfb9Lf/Ougl?=
 =?us-ascii?Q?GceIy3yrULH29MM9rcihvOyN1XahRYpYffZmtgR6t+EtD3XXspStuUAYv6nI?=
 =?us-ascii?Q?txhNHArE+r1DlMbCpmGTG0LxO4MPBY7//ay6vaSjt4+SFrRldyVYXoh/eBr5?=
 =?us-ascii?Q?+DbB83zyXu09d4abt5+XXrqsBiH6B8OZbYE1UfrVCIse+NZP7pHBpsqzeliK?=
 =?us-ascii?Q?hllrnSS9+yJYQnvuOeWn4u6Es3o3HhXgiD24Ys7VM+cxQ1gmqnjt8iJxChxj?=
 =?us-ascii?Q?BT5Jfl+oA+EiLEOu/RsIcBi8yG48x5E6jNaaqFFDvxZGfsa6jJrcOSZYeLle?=
 =?us-ascii?Q?hvwYru17n0K3JyC0kocNYrzsQ4xiCFOes/aYUnLhXnIf+WGRDj/ZiWogdjMu?=
 =?us-ascii?Q?Q/5K2ueHxHY+z/Y/KrREktYG4CFQaKEoLcQ2WAA77wQhrPkC3u1yxGO8Nlut?=
 =?us-ascii?Q?zNcSy11u5+m74HR2vcCRStXjziSNjMZkT3PfA7xpQDAde4pVnMmIFKtqMke8?=
 =?us-ascii?Q?DwAnLvk+1fwr/gXJqMDRbHBTyO6DFYMSOGGZZw/1AdMZE5xAPRBCSaWz4IQX?=
 =?us-ascii?Q?MuQM86AVPYQjyTwV5DWK3KFoiPjSygR+jQO/PCCUpK2a7pLt0lyG1jYBLaKu?=
 =?us-ascii?Q?bKyxBIPTwxphHusSHK9pZwduv7pCrlbGn2swCJZ1Eaa+GIPWdRwqL1JAvUt9?=
 =?us-ascii?Q?Ly/vZFpFc7f4WR+dJX6eDppaYsgUqzcr/Fs3QMHXrJJuf+lH4xhcMVziA8x4?=
 =?us-ascii?Q?/VmH+gW/doLvbQtTBIP/F0ezg3P3iQUYNP3bMabfQJcfX/TTEQFtw0DQ7r3O?=
 =?us-ascii?Q?89LzwUAK0K4jCcagCndAs1VbgfiToXGW6GhgJm7eEIvBPw3O/a5vX8mzk6YS?=
 =?us-ascii?Q?6C3c2p23cr9e+qA++lGGe+670C2j9yR1wXzvXjqook6AlKtKPbIrgwf8rC0k?=
 =?us-ascii?Q?OcB7prs+AKmhf3RgLENnymmcx9O2Gbtf1fcBs0zsa3xxGObi4BUXASnsbB31?=
 =?us-ascii?Q?Z0JzQUOuCspGclmM7A/iQBkXTaIDI7b8X9QyjuAyWdu2higcCvaZAt5V9yqi?=
 =?us-ascii?Q?EFCCWabTDtVMCTkwqnQKJibBq6HlAgCBoZuGGkRdSUtRquXvSW0nD/BVSe0K?=
 =?us-ascii?Q?sDOellPK+ZBOwpTzRDivvCqsZ9q6g4aOnW2CiboxFnO6xNap/zfq/USj9yR/?=
 =?us-ascii?Q?MOa8FSLmvn0UCJNTkXJ8qNsuk/GT+vfORPuBvQy22nWyBaY/+I2VSeMHyHOs?=
 =?us-ascii?Q?20AkAa/0hLVoJDFISMhe+iBx4z8Z6hQjOqFJVb+/j2wyXRuBDB5fdfGG2zsz?=
 =?us-ascii?Q?cvNNjSJABEKFtSEYwM//qxFAfjyse3BJxVEilBRDCWbPthRO4N5aYB3BVaUM?=
 =?us-ascii?Q?h/tPNJkF80dtEdzT9E4aWwixKg8rZSSongj3mgJA?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 765ff163-586f-482f-378b-08da8bdeb83e
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2221.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 05:56:31.7838
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: r2U3WTvrh4ZzDWUOXagahxJ55Jy/saSHp7OxOB+asBqcDqjQxHWSXsjMlaN8SVY9/qqyKHeMae9vzA7CbSvSIg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2082
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 30, 2022 at 05:01:17AM -0700, isaku.yamahata@intel.com wrote:
>From: Isaku Yamahata <isaku.yamahata@intel.com>
>
>convert per_cpu_ptr(smp_processor_id()) to this_cpu_ptr() as trivial
>cleanup.
>
>Signed-off-by: Isaku Yamahata <isaku.yamahata@intel.com>

Reviewed-by: Chao Gao <chao.gao@intel.com>

>---
> arch/x86/kvm/x86.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
>index 16104a2f7d8e..7d5fff68befe 100644
>--- a/arch/x86/kvm/x86.c
>+++ b/arch/x86/kvm/x86.c
>@@ -416,8 +416,7 @@ EXPORT_SYMBOL_GPL(kvm_find_user_return_msr);
> 
> int kvm_set_user_return_msr(unsigned slot, u64 value, u64 mask)
> {
>-	unsigned int cpu = smp_processor_id();
>-	struct kvm_user_return_msrs *msrs = per_cpu_ptr(user_return_msrs, cpu);
>+	struct kvm_user_return_msrs *msrs = this_cpu_ptr(user_return_msrs);
> 	struct kvm_user_return_msr_values *values = &msrs->values[slot];
> 	int err;
> 
>@@ -449,8 +448,7 @@ EXPORT_SYMBOL_GPL(kvm_set_user_return_msr);
> 
> static void drop_user_return_notifiers(void)
> {
>-	unsigned int cpu = smp_processor_id();
>-	struct kvm_user_return_msrs *msrs = per_cpu_ptr(user_return_msrs, cpu);
>+	struct kvm_user_return_msrs *msrs = this_cpu_ptr(user_return_msrs);
> 
> 	if (msrs->registered)
> 		kvm_on_user_return(&msrs->urn);
>-- 
>2.25.1
>