Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 12:01:53 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     Perry Yuan <Perry.Yuan@amd.com>
Cc:     rafael.j.wysocki@intel.com, ray.huang@amd.com,
        Deepak.Sharma@amd.com, Mario.Limonciello@amd.com,
        Nathan.Fontenot@amd.com, Alexander.Deucher@amd.com,
        Jinzhou.Su@amd.com, Shimmer.Huang@amd.com, Xiaojian.Du@amd.com,
        Li.Meng@amd.com, linux-pm@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and
 duplicated headers declaration
Message-ID: <20220901063153.zutwnnfykaz47sah@vireshk-i7>
References: <20220901062339.2357552-1-Perry.Yuan@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220901062339.2357552-1-Perry.Yuan@amd.com>
Precedence: bulk

On 01-09-22, 14:23, Perry Yuan wrote:
> Cleanup the headers declaration which are not used
> actually and 

This is okay.

> some duplicated declaration which is declarated in some
> other headers already, it will help to simplify the header part.

This isn't.

Every file should directly include headers they use definitions from,
instead of relying on indirect inclusions.

-- 
viresh