Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 13:59:49 +0800
From:   Chao Gao <chao.gao@intel.com>
To:     <isaku.yamahata@intel.com>
CC:     <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <isaku.yamahata@gmail.com>, Paolo Bonzini <pbonzini@redhat.com>,
        "Sean Christopherson" <seanjc@google.com>,
        Kai Huang <kai.huang@intel.com>,
        "Will Deacon" <will@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2 05/19] KVM: Rename and move CPUHP_AP_KVM_STARTING to
 ONLINE section
Message-ID: <YxBKVfG29/P+Kijv@gao-cwp>
References: <cover.1661860550.git.isaku.yamahata@intel.com>
 <d2c8815a56be1712e189ddcbea16c8b6cbc53e4a.1661860550.git.isaku.yamahata@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d2c8815a56be1712e189ddcbea16c8b6cbc53e4a.1661860550.git.isaku.yamahata@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?oSPq8SOs35mG588PIwMapFpjwkysd4w4GcsNWFX7T0+OOVh95MblxKPFwlqb?=
 =?us-ascii?Q?4sGX6rOmsch+QxCEK0MSQmeQabsi3lpWdAyu2h1iSYqVIOejxr6nHhim5SXo?=
 =?us-ascii?Q?PruWjn5CmH70mb/M3rWPPkrwDixhFHWdWUiifAyMtOz04cYTzQIpIuF3DFbR?=
 =?us-ascii?Q?Y2ICbaHeFD6pJmaITK/31bRK7coQwPtbT2qiOlS7tK9lz0Speb3wyTjnTd6w?=
 =?us-ascii?Q?ugfC2J5okmw1S7LG1qFh2ago2eTEhUBcvfoUZ3T/up5Do9zjnj1UntsOGYg/?=
 =?us-ascii?Q?fP9/9xI0XAPABZ3OvA6NbVLET9QHkzvdL0M/ZVNB9/gyAFnceSqNk/5k41Eo?=
 =?us-ascii?Q?R7yKcRT1Weht6D/SgECPOtbQAiON8Klg1VqRhBeUuIS3i/1P2dIjDerEF1cA?=
 =?us-ascii?Q?7bNUbIhhIfM+WjqiWCg1N88QRtENv2wH+F7x1fITcAOU5tUDVd6lLO2iPyF5?=
 =?us-ascii?Q?gXPa2C57unTC6hn0NdB/cg0rlKm+tqsUxr5q8p9Aj+Xea1HU32OuBH+VbwkR?=
 =?us-ascii?Q?YJoeh+t5tGKm+twYZae+pkdPMfesRq73IsA5t28cYvsAhjl0SdSHtEQoywbz?=
 =?us-ascii?Q?4dsa4O1tm+om/O1xt9j+9oVt9nvSxOkfZo4fJufZvJ11Zt2lKe91LBhflLpt?=
 =?us-ascii?Q?D+uYFIBjsL5l0azEJAmSFZH8acCWo4P+U1iyr/QhPrb+L6uBcZHiLU6z9KSs?=
 =?us-ascii?Q?vgkd666bTaLiYiS9uM3pCFLk4DVLqmuAY2ndwcVjn8BH1S2DZozzjyW10dmr?=
 =?us-ascii?Q?2K19eN4wP/E8Ag3EZZErVnLWD/VPjllwS93FOfLq7xbpzzbbR7d+L1Dzk7Lb?=
 =?us-ascii?Q?McGBaJmUhKN32qTkRVoSJxlONoj5WTPllVlop0XYOpX//ahNi5hyzP0+o82+?=
 =?us-ascii?Q?UrjtC9VwDEO3rDqVIARhxXzx/76A9imduJM15XKaHR51mN4Wtu+XBur+uKPt?=
 =?us-ascii?Q?EZ3TiyMifbfm6E7ZqBHTNOdJylNefI3L+lCYVParpkLzEeOb+2JR52imqTvB?=
 =?us-ascii?Q?oscVeKJhIeRDJMlynLMNhJo1i1I9RpfatTFCOmRuIK4wT0Ix+kv8e5ezuP1y?=
 =?us-ascii?Q?v5Vj3BZ1QrU2hxyBKzB9j/Maplj7N/rXoTxinmcqliY/yGQHGoEpAX0Iuf6d?=
 =?us-ascii?Q?ICf2YXilnZIcJOGSnFXshU5GF7Aak4xq7uxUk69QzhtDQ86+xqH286HQD3Jk?=
 =?us-ascii?Q?pH+F5MSGTOi75UWO+P4xsDXDNwXGsd5yVHTt4ufMnAWoFatW+2Pk9nPQkq1k?=
 =?us-ascii?Q?Hh4Wqyt33B4QnGfN6KM7Ga6yIxKMHz2TROh8OK1n56Bu0deDHuzdM9nIRvnX?=
 =?us-ascii?Q?VjnlG2ZP9Lk5zETxcVIP5chE7KJCR4NwlhiXoYGKkjvIsjGRgv1MzdsLvi+C?=
 =?us-ascii?Q?VXdB6lt5+AEqGAsrxXMfwONtIUUiBO5xBkPi/mrBC7zGI8yHJSVOElUN/j+/?=
 =?us-ascii?Q?E2ZsIKa+ydlpCOf2UZAGGxNnVvUbn4V8OWzf51D4ur0FZtEwbMYr9F6hVvvV?=
 =?us-ascii?Q?LfBh8F7YTIFNEBBwIvJymGRaFV9CuVAuqwaCB9He+tSGHX1txVMAdPZK226m?=
 =?us-ascii?Q?ucdaV+4aZkbe5ISbaBJ4mVlsA500+6hgHV9l8wBf?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 85ea0eff-9691-4085-7278-08da8bdf3163
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1101MB2221.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 05:59:55.0165
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ySVWZ/ZOZnDzyZ1c/FUnolpMX1lwJnFIYlKTKYUHplRAFwyAAOntQ9amXNLrwUQu1kxfa6PxNBqi5c56j5L39g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1101MB2082
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Aug 30, 2022 at 05:01:20AM -0700, isaku.yamahata@intel.com wrote:
>From: Chao Gao <chao.gao@intel.com>
>
>The CPU STARTING section doesn't allow callbacks to fail. Move KVM's
>hotplug callback to ONLINE section so that it can abort onlining a CPU in
>certain cases to avoid potentially breaking VMs running on existing CPUs.
>For example, when kvm fails to enable hardware virtualization on the
>hotplugged CPU.
>
>Place KVM's hotplug state before CPUHP_AP_SCHED_WAIT_EMPTY as it ensures
>when offlining a CPU, all user tasks and non-pinned kernel tasks have left
>the CPU, i.e. there cannot be a vCPU task around. So, it is safe for KVM's
>CPU offline callback to disable hardware virtualization at that point.
>Likewise, KVM's online callback can enable hardware virtualization before
>any vCPU task gets a chance to run on hotplugged CPUs.
>
>KVM's CPU hotplug callbacks are renamed as well.
>
>Suggested-by: Thomas Gleixner <tglx@linutronix.de>
>Signed-off-by: Chao Gao <chao.gao@intel.com>
>Link: https://lore.kernel.org/r/20220216031528.92558-6-chao.gao@intel.com

Note that Sean gave his Reviewed-by for KVM changes.

https://lore.kernel.org/all/Yg%2FmxKrB5ZoRBIG+@google.com/