Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 1 Sep 2022 12:30:28 +0530
From:   Viresh Kumar <viresh.kumar@linaro.org>
To:     "Yuan, Perry" <Perry.Yuan@amd.com>
Cc:     "rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
        "Huang, Ray" <Ray.Huang@amd.com>,
        "Sharma, Deepak" <Deepak.Sharma@amd.com>,
        "Limonciello, Mario" <Mario.Limonciello@amd.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@amd.com>,
        "Deucher, Alexander" <Alexander.Deucher@amd.com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
        "Huang, Shimmer" <Shimmer.Huang@amd.com>,
        "Du, Xiaojian" <Xiaojian.Du@amd.com>,
        "Meng, Li (Jassmine)" <Li.Meng@amd.com>,
        "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] cpufreq: amd-pstate: cleanup the unused and
 duplicated headers declaration
Message-ID: <20220901070028.gdm7uiszm35iom3e@vireshk-i7>
References: <20220901062339.2357552-1-Perry.Yuan@amd.com>
 <20220901063153.zutwnnfykaz47sah@vireshk-i7>
 <DM4PR12MB5278D01EA2D78367F182C7C69C7B9@DM4PR12MB5278.namprd12.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DM4PR12MB5278D01EA2D78367F182C7C69C7B9@DM4PR12MB5278.namprd12.prod.outlook.com>
Precedence: bulk

On 01-09-22, 06:56, Yuan, Perry wrote:
> > On 01-09-22, 14:23, Perry Yuan wrote:
> > > Cleanup the headers declaration which are not used actually and
> > 
> > This is okay.
> 
> Thank you help to confirm this . 
> 
> > 
> > > some duplicated declaration which is declarated in some other headers
> > > already, it will help to simplify the header part.
> > 
> > This isn't.
> > 
> > Every file should directly include headers they use definitions from, instead of
> > relying on indirect inclusions.
> > 
> > --
> > Viresh
> 
> Do I need to update the commit with another V7 version ?

I am not sure which headers you removed are still required, working
for now since included indirectly. If there are any, then better to
get a new version out.

-- 
viresh