Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <99e9d22b-5787-cc3f-eb6f-ae137f0282fd@amd.com>
Date:   Thu, 1 Sep 2022 08:54:22 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 10/21] RDMA/umem: Prepare to dynamic dma-buf locking
 specification
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        David Airlie <airlied@linux.ie>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Gurchetan Singh <gurchetansingh@chromium.org>,
        Chia-I Wu <olvaffe@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Daniel Almeida <daniel.almeida@collabora.com>,
        Gert Wollny <gert.wollny@collabora.com>,
        Gustavo Padovan <gustavo.padovan@collabora.com>,
        Daniel Stone <daniel@fooishbar.org>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Rob Clark <robdclark@gmail.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Tomasz Figa <tfiga@chromium.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= <thomas_os@shipmail.org>,
        Qiang Yu <yuq825@gmail.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Amol Maheshwari <amahesh@qti.qualcomm.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Tomi Valkeinen <tomba@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Lucas Stach <l.stach@pengutronix.de>,
        Christian Gmeiner <christian.gmeiner@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Dmitry Osipenko <digetx@gmail.com>,
        linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
        amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
        kernel@collabora.com, virtualization@lists.linux-foundation.org,
        linux-rdma@vger.kernel.org, linux-arm-msm@vger.kernel.org
References: <20220831153757.97381-1-dmitry.osipenko@collabora.com>
 <20220831153757.97381-11-dmitry.osipenko@collabora.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220831153757.97381-11-dmitry.osipenko@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MUZjUmJscWhsNHFNNWNVc2kyamF0a1N4L1NZbTlIdHg4TDRuRnBmMzM2N0Ry?=
 =?utf-8?B?b085NzBEMENQb0x0Mk9EdkhOSWZkSWxEa1NjOWE3RVNrd3RpVjJhWkpaaVRT?=
 =?utf-8?B?RFFpakZVUDVKU1ZpQkYzTENUR3IrQ2tuK3NUL1VJZ0pDNXU4YlFhVTJFeWtz?=
 =?utf-8?B?VU9JemVuWTBWQmNJdG56YmZ2OEpaQ1BXSDBXK2F3aHJLemorSnlBSEtxRzhk?=
 =?utf-8?B?dnFDYWpDaE1lYUZySmF5YzRaS1lqdXRmWWJWYm9ubWRUaHQ2UHR1cFkyOWM0?=
 =?utf-8?B?eTRyRWZwS1ZGS21TRm9kTDlRc25UNXZPOXBmZFh4SFVBM3ZNU0E2RjF4ODdV?=
 =?utf-8?B?R1hGMjQyOEZ1U3ZlSyt4RkpkNmZUVkNmV3JnbWFsa3FNNzFCbG9UWko5azI0?=
 =?utf-8?B?MzZ5cU5mRG9lMm1pRkJPMndtVzNlRG14NlU4K3dWelJJSWhPNHdyZEFvTWN1?=
 =?utf-8?B?RUJhcjN5eVBJZWwvR3hTQlovcU1sRDJxems4ZHlDVFVJQmZaZzJUR2g3bTha?=
 =?utf-8?B?ME45L0M2OVREYWl3UVNYeFI4aGxWazV2N2RQemlpQzNkNno3U2tKTGRoZ0Fj?=
 =?utf-8?B?ZGxIdnZTTlpvM2FvSTN6WjVKZStEakN4REYxeW4wRUFqUXhhbC95dVpBMEMy?=
 =?utf-8?B?QTVGc29TeGtWc2FJcTRmRzlra1htekM4TkExR2NtVzZQTUZieElGWkRvY2du?=
 =?utf-8?B?Nit1NzVyZ210NjhMYk5qaWtWTXgyc1BmTzFYYzJQZlhrV0lGQU9NcjZUTW1s?=
 =?utf-8?B?YnlwNFpycFREVEJ1TkJKeStENk5Ec05VU01HQUdObmdIRXcwZ0RsWmZKd1o1?=
 =?utf-8?B?c215N2hIMXVOUkQ5N3M3MWpiWWlMQXkzUE1yWFNZclB4SzN4RVQ3MTkrZmp5?=
 =?utf-8?B?NG5aVzEySkpKOWJRNW1SYmFSZHIxODlGd0dhdml3cDJCS1B1eGY4R3l3Q1lQ?=
 =?utf-8?B?ckhZZlpjWFJNRkNTZ2ZmM3NtUmtFbHQ0QkoxemxhRERPcE5UeThMY0RoUnBw?=
 =?utf-8?B?QXdtWUEzM0hhdkZNMEFJcFJMdzVWUGdqVTN1eXRqZ0h4UGxRZDNOcUhkWDJF?=
 =?utf-8?B?TXV3TVdwUlZqekNCY1JuQ2hvaFRuYmhWZTMzbTBES1BNL3I5MzFQM2ZmR1Yz?=
 =?utf-8?B?dFQzejRtYUlpbEhwZlN0endYellzbk9iVzJ6Z0d2cUhCYW1oc1lZenZ3SE1Z?=
 =?utf-8?B?a0cwaytmTkMzeVdoRVk4VnBmUzh0L1BidWRrQjNpdGtmM2VIaE1IcFppVTVW?=
 =?utf-8?B?S1lQV2t3ZnpjZDlTK25HbXpkYld6YVRvbWlMNTl2R3REKzJIcHZ4SjNYT1BS?=
 =?utf-8?B?aVVseXkvK3VweXlxOGU4b1ZOdGRBbndpb0J5RjR1blVXTGM4MVRscVFudlpt?=
 =?utf-8?B?TE55T25PaEorOWJ5OUlFTG0yMmViMTFkTEZBUElyQ0FpUGR2dElOU2t2UnpL?=
 =?utf-8?B?T25Pci9hTmdSdGdnU05DR25sYW43bWI5KzlPdlNHdVpIT3pzVmtlbkZESmZG?=
 =?utf-8?B?M2RBWnRlSDZNWDViR2p5aENsYVpLQkVObW9iSGJtWjYrRnp5RjByOWFldXBM?=
 =?utf-8?B?ek1RMTg3cUJoQkg0MW9hdDlHZDV4NG1uZStnbkZTam0rQzJBVnYvUjNVUjJv?=
 =?utf-8?B?T0s5WWdjZVRTekg0dGZHZWF3UHNIU092citvVUpDcVJkZEZKWmZWSWxlRzBS?=
 =?utf-8?B?Ulp6d1MzSU45Qm0rblpmaCtGejByWG9OeEFCUFFmKzdRRERMc3I0aDdmZ2cz?=
 =?utf-8?B?L0VuVDFyVGl3WVVnUWxWNzYxMEpLcmNmV3AxdXBMTTdpVVZBZ0k4QWk2UjB1?=
 =?utf-8?B?UDVVSGZlak9HZi9SclZYWHBnWmdwMVRXODF5Y2ZuVHlzVU9CUmsvanV5Nlpi?=
 =?utf-8?B?RDVVK0NTaXVGaUhvRFhIdzc4N0JXZGQ1NVFPaGI0czlQK25mN291RmIxWEM4?=
 =?utf-8?B?T3diMGpqalNKN2dqUHIrQkFjd0ZWVW9YemdjWWxwMFl0cGthZHdJTVF3ZWxI?=
 =?utf-8?B?eUgxSC84ZFoxbTRXVUdseDNjUEZ4R3Q1Ky9yWFJ6SHl6QVhnQjFvVm1DQ0kr?=
 =?utf-8?B?U0lqNmxJcHFHZTRZaHN3SW1xcEIvQTVmalBJMHVxMjZObmJiZytqK1UzMmJC?=
 =?utf-8?Q?+a15ShS2/2B3hYxbFLm99S1+f?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 307beed9-aa49-4c9e-27cd-08da8be6d397
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 06:54:33.6859
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: oU9/KTnB6nlu+f+6YJpX8z4UxcGCbDL8WeNjfrmYPO5JDurNWO/L800I6nxkIh0V
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4315
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
> Prepare InfiniBand drivers to the common dynamic dma-buf locking
> convention by starting to use the unlocked versions of dma-buf API
> functions.
>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/infiniband/core/umem_dmabuf.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/infiniband/core/umem_dmabuf.c b/drivers/infiniband/core/umem_dmabuf.c
> index 04c04e6d24c3..43b26bc12288 100644
> --- a/drivers/infiniband/core/umem_dmabuf.c
> +++ b/drivers/infiniband/core/umem_dmabuf.c
> @@ -26,7 +26,8 @@ int ib_umem_dmabuf_map_pages(struct ib_umem_dmabuf *umem_dmabuf)
>   	if (umem_dmabuf->sgt)
>   		goto wait_fence;
>   
> -	sgt = dma_buf_map_attachment(umem_dmabuf->attach, DMA_BIDIRECTIONAL);
> +	sgt = dma_buf_map_attachment_unlocked(umem_dmabuf->attach,
> +					      DMA_BIDIRECTIONAL);
>   	if (IS_ERR(sgt))
>   		return PTR_ERR(sgt);
>   
> @@ -102,8 +103,8 @@ void ib_umem_dmabuf_unmap_pages(struct ib_umem_dmabuf *umem_dmabuf)
>   		umem_dmabuf->last_sg_trim = 0;
>   	}
>   
> -	dma_buf_unmap_attachment(umem_dmabuf->attach, umem_dmabuf->sgt,
> -				 DMA_BIDIRECTIONAL);
> +	dma_buf_unmap_attachment_unlocked(umem_dmabuf->attach, umem_dmabuf->sgt,
> +					  DMA_BIDIRECTIONAL);
>   
>   	umem_dmabuf->sgt = NULL;
>   }