Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <94cdb302-98ea-2f8d-8bdf-cf81b45dddc1@amd.com>
Date:   Thu, 1 Sep 2022 08:43:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 05/21] drm/armada: Prepare to dynamic dma-buf locking
 specification
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        David Airlie <airlied@linux.ie>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Gurchetan Singh <gurchetansingh@chromium.org>,
        Chia-I Wu <olvaffe@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Daniel Almeida <daniel.almeida@collabora.com>,
        Gert Wollny <gert.wollny@collabora.com>,
        Gustavo Padovan <gustavo.padovan@collabora.com>,
        Daniel Stone <daniel@fooishbar.org>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Rob Clark <robdclark@gmail.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Tomasz Figa <tfiga@chromium.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= <thomas_os@shipmail.org>,
        Qiang Yu <yuq825@gmail.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Amol Maheshwari <amahesh@qti.qualcomm.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Tomi Valkeinen <tomba@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Lucas Stach <l.stach@pengutronix.de>,
        Christian Gmeiner <christian.gmeiner@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Dmitry Osipenko <digetx@gmail.com>,
        linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
        amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
        kernel@collabora.com, virtualization@lists.linux-foundation.org,
        linux-rdma@vger.kernel.org, linux-arm-msm@vger.kernel.org
References: <20220831153757.97381-1-dmitry.osipenko@collabora.com>
 <20220831153757.97381-6-dmitry.osipenko@collabora.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220831153757.97381-6-dmitry.osipenko@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVp4MEtkMmlDV3pHeUVEYU43azJndnpqNis5TGtKZThCbjRwVmUySzJrcGNB?=
 =?utf-8?B?YmNRbnlTR0tqV3FMSEtKLzN2M0l0T3U4eHZ1Nmw2RnN4ZGhHS0pXQUs0cVZR?=
 =?utf-8?B?ZGpmeFI0TldHaU43WWxJcVFoUDk3T1BaZFk3RUNpL1A0MjVteC93VmFsbjVT?=
 =?utf-8?B?Z1BTVjNkakMxZHFGSThNRUpEdG9wdWI4MVlwa2pzcjZUMDRXVFRUSlB1NHJq?=
 =?utf-8?B?RlM5U0h2THVQa2YrVStzMEtFTW9HUkxtMlRFWUNKQVJLTzBFQVFDNFBpd3lM?=
 =?utf-8?B?ajRhZmZIa3NzaVZoK3BUMjR6MmhSZ3FNdVVaVTRQb3RtWVNDVXBmT1FvMGU4?=
 =?utf-8?B?VDVmYmZvdnZiM3Rhd0R1ZkcvbUhVTi94RGFKZGRGZ3MvR2o4SFZmVG1qU2Fj?=
 =?utf-8?B?SFB6VWNnNFp0M1EvdGFrUDNFeWlZSEJmUExiWUJmVUVTYlVJQXNBeXU5Vjdy?=
 =?utf-8?B?Rnd0a2pSbE5BbFllcWxYTTdQbVRvN004bjc5QjdTYis2N3NudlFzRzlObTE3?=
 =?utf-8?B?dysyR2JNYXJsN1h6bzJhY3F3VDE1NUQ2QUlSM1k4dCtJenR5QXdhdEN4ZFNr?=
 =?utf-8?B?YnlwR0E3ME1oM0NzYkJRRVRIcDRPTU1uV3J4Tjl5SjZrNmlpczVIL2tXbFRW?=
 =?utf-8?B?dkpXMmNVSGdzMXQ3VHF3b2E0Vnc4WDhwYVB1WG81ai9pejBHM2JMR2liY05H?=
 =?utf-8?B?eUFqTjVOSWtBaGEwbmpUcnN1bndPWnJoV2tlSE9vSkthVkRHRGVzRDd2VStq?=
 =?utf-8?B?U0Vxd1BCZ08vVWc5aEROdXVvZkFjYmVwN3RoNFc2aEQ1K3d3MmprODErUk9I?=
 =?utf-8?B?UHRxdWZUYXYwMUxBaVRCQmxmclZhbG5QZ0hua1ZlcUVHdlY4cXJ6V2FqWVlI?=
 =?utf-8?B?dFRnWmU5Q05FM3RxTVFHcUV2RG5XZWt6MTd0cFZ0L1haN2xQZFZ5TVQ4U2xH?=
 =?utf-8?B?dWtYTjN0d2JhOHdsK1p6NkdYUWdYckdMS0JqNXBud2hieUJzTFZIQ2p6STRT?=
 =?utf-8?B?Q2sweTJjeVJqdjdUdTV4aWl6dmkrSWR0b01nRGJWYmtXY2ZCWHJqbWlML0ZI?=
 =?utf-8?B?dFVOU3Z0MWprd0tOSUUzT2lsNzVtVUs3R01icjZPQzY4eUFxcXNYbkdFRzRL?=
 =?utf-8?B?aUkyWVZZQWxqaU9KNXhPeDUwWkFxclhFSkhrcVVubmh3TUZGamJmT2FkaVl3?=
 =?utf-8?B?QisyTTlZckQ5bWIrWU1hc3ptaEM1SjJBQzZXVXVyYTcrRjJZZ3RYY1JqdHNM?=
 =?utf-8?B?MUVpQStxajVIMytyVHR1TWY3bSswRm5MNzRLVlpCWVZneG5ETWo1Ylh2R2Fa?=
 =?utf-8?B?Z2l1VEpyeUtUTWtGZ25xUDBqb1N6TkJ3bmlVSTd5RzdpQm9ZY3pjQVh2NDFI?=
 =?utf-8?B?L3FrczBDRy9NRm42SzNSZld6eGxEMWZ3bTFxRmFkSzZiWitmeEJWZFF0dHRa?=
 =?utf-8?B?M0dENFUwQllsK3Y5bEN3MmtBRGtFN1JLaGdwZmRkbmxlTUlNaVVSOWI2QzhB?=
 =?utf-8?B?bFJPVTJxWjV3c3ArWDRNUGhoK1NPM1lXU29sZHZVUDQwL3c4MDMzRmdBNGRT?=
 =?utf-8?B?RkdZeTAxQW5rTTc5OFVqRm5TN0l6Mlo2QXhYbjBmSXY1VWxhN29jZzB4TVNN?=
 =?utf-8?B?TktVdTk1eTVaV0d4RkFLTlo4cmRFZkZjVDdNR3cxYk1oRVFiekp0N1ZZenZ2?=
 =?utf-8?B?RlJ0RmR2ZWp3alZ2RkZQY1dxallQdEhWdkxTL01vWEFFeXBLdnNJRCtaaGNz?=
 =?utf-8?B?NmhkYTB0SGJHZlJ4MWh4bkRtdm9pQW9IcnhDZ3NUSVAxeUJRV0NneGxzdUpO?=
 =?utf-8?B?SjR4dGJaKzBQanYwU2pqeC9JUzdEUnkxeUtvL2pVdTN5MXBlcVRUcmZ3amF6?=
 =?utf-8?B?RE5PVzFuSjBTbmt0STZUajhUWGhNck5VOFBLcGFLQk1kZVlEd2JFTm9WMHBt?=
 =?utf-8?B?OHZhYWtWVzl2dFpCbk5jR2Urb1FKUWdGb05KYjJOUUJvaWQvQWI3YTZzMU54?=
 =?utf-8?B?eW5BcGRaTUdNdS9JN25VekZMeXN5WXFzdXJkOFVjZThERXhLdkRVemh3ckxs?=
 =?utf-8?B?dFJ0NWpsU0VxSE1wWkVaN1BNWXVrdEczbW03VGpzRnc2Vm1lZDk1Mkx6VmNQ?=
 =?utf-8?Q?trMV3gWCXJHC/iDBIP6nnjaJx?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25ae735a-7f2d-402d-ccc1-08da8be53e1e
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 06:43:13.4355
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AulUexLYpzl72xOD6yOBuYcVnSKwfakmvRqXDY1U1BArPusLF1h2FYIRut6joxsX
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR12MB5156
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
> Prepare Armada driver to the common dynamic dma-buf locking convention
> by starting to use the unlocked versions of dma-buf API functions.
>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/armada/armada_gem.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/armada/armada_gem.c b/drivers/gpu/drm/armada/armada_gem.c
> index 5430265ad458..26d10065d534 100644
> --- a/drivers/gpu/drm/armada/armada_gem.c
> +++ b/drivers/gpu/drm/armada/armada_gem.c
> @@ -66,8 +66,8 @@ void armada_gem_free_object(struct drm_gem_object *obj)
>   	if (dobj->obj.import_attach) {
>   		/* We only ever display imported data */
>   		if (dobj->sgt)
> -			dma_buf_unmap_attachment(dobj->obj.import_attach,
> -						 dobj->sgt, DMA_TO_DEVICE);
> +			dma_buf_unmap_attachment_unlocked(dobj->obj.import_attach,
> +							  dobj->sgt, DMA_TO_DEVICE);
>   		drm_prime_gem_destroy(&dobj->obj, NULL);
>   	}
>   
> @@ -539,8 +539,8 @@ int armada_gem_map_import(struct armada_gem_object *dobj)
>   {
>   	int ret;
>   
> -	dobj->sgt = dma_buf_map_attachment(dobj->obj.import_attach,
> -					   DMA_TO_DEVICE);
> +	dobj->sgt = dma_buf_map_attachment_unlocked(dobj->obj.import_attach,
> +						    DMA_TO_DEVICE);
>   	if (IS_ERR(dobj->sgt)) {
>   		ret = PTR_ERR(dobj->sgt);
>   		dobj->sgt = NULL;