Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <641f372f-4a30-72bb-ec8b-4fd6ff825594@amd.com>
Date:   Thu, 1 Sep 2022 08:50:13 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 09/21] drm/etnaviv: Prepare to dynamic dma-buf locking
 specification
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        David Airlie <airlied@linux.ie>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Gurchetan Singh <gurchetansingh@chromium.org>,
        Chia-I Wu <olvaffe@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Daniel Almeida <daniel.almeida@collabora.com>,
        Gert Wollny <gert.wollny@collabora.com>,
        Gustavo Padovan <gustavo.padovan@collabora.com>,
        Daniel Stone <daniel@fooishbar.org>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Rob Clark <robdclark@gmail.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Tomasz Figa <tfiga@chromium.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= <thomas_os@shipmail.org>,
        Qiang Yu <yuq825@gmail.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Amol Maheshwari <amahesh@qti.qualcomm.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Tomi Valkeinen <tomba@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Lucas Stach <l.stach@pengutronix.de>,
        Christian Gmeiner <christian.gmeiner@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Dmitry Osipenko <digetx@gmail.com>,
        linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
        amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
        kernel@collabora.com, virtualization@lists.linux-foundation.org,
        linux-rdma@vger.kernel.org, linux-arm-msm@vger.kernel.org
References: <20220831153757.97381-1-dmitry.osipenko@collabora.com>
 <20220831153757.97381-10-dmitry.osipenko@collabora.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220831153757.97381-10-dmitry.osipenko@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dVZlVVhVdVRWcEFlU3BEQk1NZFVIS1pvRkt2LzlCTWxoY1JpT2V6a0h5N2xC?=
 =?utf-8?B?SmJ1elF3ZXBHRFJmdGVWdTF5Q1JwcDdycjVYN0VxTm4rTmlCOVpZczRNUVlm?=
 =?utf-8?B?NHBIWEVjMlhwZlFoR1RPK3VNZW11YXcrSVh1eFpXRlNjOXEzUWdGVG1zUFRS?=
 =?utf-8?B?K3F3MCt3eENiZ3N2NFJrTnBGaEhaQ3NOY0tvRWtTTDFIWEE5UkdSLzRmUy8w?=
 =?utf-8?B?SXdzQ0VJenVyUWMvWjNGZ1lqQ0Myc09mQkVvYWh2NWlJR3hGRDJzS1FoLzl1?=
 =?utf-8?B?Vzkva2RGVEJGOFlORUVPZTN0ZkEzQzloYlRPcmZKbk9lUnEzS0laNC9yMWhr?=
 =?utf-8?B?MFlvY2VHaGxZR0V3VktnZ21qZnY0bDhJUUEzbnd4MnZuZDVjVXl0ejZQbEk3?=
 =?utf-8?B?bWFwSG1ienEyS2NZcnBhS3hFSm8rdlVVaS9MY1lITTd2aXdSaEVQd282dHVT?=
 =?utf-8?B?dURkU2MrQ3ExN2FSdEUrV3BSaUw3aGJWZzdnNlBYbXIyZXpUelpWOVU5Y1VS?=
 =?utf-8?B?N1VBNzJHb29aUng1RjFCdjJlOFRscXQ1aGE0aTlQcUFnZVVlMEg2N1dqTFBX?=
 =?utf-8?B?My9laTI3NEtjSlpEekNhRWxIb2NWamdBZVVHdUVwK3RQR3c0QkhBWC81ZGYr?=
 =?utf-8?B?RUpRZ1JXM3VRMGkycFZUWjg4Y25MMFNERG5BN1lpQlBWY25DeCtrNlFWUzFm?=
 =?utf-8?B?NUQrK1hOSUpqV0ZWb283YmU5R0ZuOVlvODBzL1c4STJ4L04xNFhHcG9YcjRN?=
 =?utf-8?B?MGJKUWhkV0tBMWYvL0o0UThSNkJzS1dDZFN0NzhwanpNdGhObTFrc0c0Z1Jk?=
 =?utf-8?B?MVNQOHZqNjNYaDFvWGIwSlUrL1FrU080WllLQWU2cGJkdWlZQjJUUjdQMnlB?=
 =?utf-8?B?REZJaEI1RUEwYWNyc0FxZEU5QmZUR3VQVXZ3YmQ4NUlNa1Ewc3pSRnJqVmVM?=
 =?utf-8?B?SU1Hd3UwOFdMQlFrMU03NjdFQllVTy9BV29yQzUzY3k1U2hhVWpmRThjYkFE?=
 =?utf-8?B?WWkwODFXNndwRTVNUUdXVzQ3YnpzL0tucE1hNVd1MHU4U1JzRTZ4NDE4OTlW?=
 =?utf-8?B?ZExsWU5KY0NIMDl4aDZoS291WUR1dVVsTHpWY3FiRThuWWkwR3BCdm5iRVNa?=
 =?utf-8?B?eFBxRlpPNDBKTGVkSmdid1VxN3E4Vk5YNnFJOUxHbENYMVNEdXYwQnpDSDVP?=
 =?utf-8?B?UFp5RXJvanp6cEpYdmtLbWNyL0hBb29Wakhac016VEFBSkEzM3YrRFQyUW5G?=
 =?utf-8?B?c3VHa0tvcE91T2VFcTNJZ0pTeGZCR3dLZTBKVDI3ZG1rOTdwQklLMkJpUUxQ?=
 =?utf-8?B?U1k5NVR5N1NJaWVhTXczeXVnVk9qVHhoRWticWZvUEV5UmprelZKNDVtRldm?=
 =?utf-8?B?K2hBU2Jzc2VnS3hab3R1WVl0QTZBektpcy9YNnlBYUY1bitZUFZ6VDJxbWpU?=
 =?utf-8?B?WFBuTm10NW1aSjcvb2cyR3RZNjI5VjF6dVRKcENJalNrS24wRVdtMUl1UnR0?=
 =?utf-8?B?dVlHRHcvU3IvMmc5ZDFZaUIwbHprSEt0MDU5cjl0SlVYUFp3NUFQMlVidHlq?=
 =?utf-8?B?QVF0ek9oOHE2SWY0L3NIcmM4TENQT052MVJRMlprc2hJcWZNck91QXpaK1c1?=
 =?utf-8?B?MnBBcVFuNVROemhuai8yR0IxUTcwUkFwZUFPUE9saUlXS0M5ZHYzRFRFYnJk?=
 =?utf-8?B?ODFDUld2NHFFU3FaclFBN251cStGUkc4MzI2eDQ5OTVXYmQvMlFHNU85OXJJ?=
 =?utf-8?B?NlE4aldIRTg2N1FkTlFvU0NSL3VPc0dFUTROVmFlRHVFNUhlUk9XaUZkR3JI?=
 =?utf-8?B?QkZpNGlZZXB5b3lFb09GS3BGQUhYbzZXZllqVURVUHUzVlR3N0tMaGdJa05k?=
 =?utf-8?B?R2dJSGloTU4ybkN0aUVqVGxZNFIwVXhWTi9FamJFWk5PckNKTkRzdWFPVDRk?=
 =?utf-8?B?Wldab0FaY2F4aTh3anNKRTFUVmNwWDRUVzlLNm5ZYThpV2JPaUt6M3NMNWRr?=
 =?utf-8?B?SkJJSmVvU0ZOQjF0aVRURUtiRHY5NXlZSi9oa3JxSkk4dlZlMUROVXFaMkhr?=
 =?utf-8?B?dENnSGpzNjNkdlpwb2FqeG9jVThNT0JQaTdRc3NwNFB4SE1mSEpGdGFDRE5m?=
 =?utf-8?Q?tDO5VkcxVb0GesmHuui/cPbM2?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e38163cc-49ab-4860-2151-08da8be63f53
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3587.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 06:50:25.1247
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZiB7fjshmml/8gQ3BPLMGftskJ3cHXzwcEscqW4ZWTzEK9456jizc6fobvHEeBjJ
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4360
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
> Prepare Etnaviv driver to the common dynamic dma-buf locking convention
> by starting to use the unlocked versions of dma-buf API functions.
>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

Interesting, where is the matching vmap()?

Anyway, this patch is Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> index 3fa2da149639..7031db145a77 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem_prime.c
> @@ -65,7 +65,7 @@ static void etnaviv_gem_prime_release(struct etnaviv_gem_object *etnaviv_obj)
>   	struct iosys_map map = IOSYS_MAP_INIT_VADDR(etnaviv_obj->vaddr);
>   
>   	if (etnaviv_obj->vaddr)
> -		dma_buf_vunmap(etnaviv_obj->base.import_attach->dmabuf, &map);
> +		dma_buf_vunmap_unlocked(etnaviv_obj->base.import_attach->dmabuf, &map);
>   
>   	/* Don't drop the pages for imported dmabuf, as they are not
>   	 * ours, just free the array we allocated: