Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <0093f4c9-9935-3bc5-caf8-54669487634a@amd.com>
Date:   Thu, 1 Sep 2022 09:04:05 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 12/21] xen/gntdev: Prepare to dynamic dma-buf locking
 specification
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        David Airlie <airlied@linux.ie>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Gurchetan Singh <gurchetansingh@chromium.org>,
        Chia-I Wu <olvaffe@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Daniel Almeida <daniel.almeida@collabora.com>,
        Gert Wollny <gert.wollny@collabora.com>,
        Gustavo Padovan <gustavo.padovan@collabora.com>,
        Daniel Stone <daniel@fooishbar.org>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Rob Clark <robdclark@gmail.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Tomasz Figa <tfiga@chromium.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= <thomas_os@shipmail.org>,
        Qiang Yu <yuq825@gmail.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Amol Maheshwari <amahesh@qti.qualcomm.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Tomi Valkeinen <tomba@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Lucas Stach <l.stach@pengutronix.de>,
        Christian Gmeiner <christian.gmeiner@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Dmitry Osipenko <digetx@gmail.com>,
        linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
        amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
        kernel@collabora.com, virtualization@lists.linux-foundation.org,
        linux-rdma@vger.kernel.org, linux-arm-msm@vger.kernel.org
References: <20220831153757.97381-1-dmitry.osipenko@collabora.com>
 <20220831153757.97381-13-dmitry.osipenko@collabora.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220831153757.97381-13-dmitry.osipenko@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NVRGNzMvRnpud2xXU1FxWXIyRTFYQXBvWWcvSElVaHh1djJmb0t1WDBLdTdE?=
 =?utf-8?B?WE1TY1QyeHFEM3hvb2ZwTGtMZlhnUFR0Rm1iTG1UUTN2MzZGWGs0bGR5R0Fr?=
 =?utf-8?B?Vm4wQTZ2WkY1RlZKenNZZHJudEhIV1JaOEFDc2xSdUxjMUlrMzRkRDRBbGV3?=
 =?utf-8?B?blZ4THFpN1l1NjRJT1JnZ3E5NHRKTGk2RXR6Y3BoYkFTTGsyWDU2eVRVREFx?=
 =?utf-8?B?MUhkNjdvNkZZWUNzR2IycjZuUjY2ZWZwdG9rQW84U2ljS3ZrVWxjOUtUUU4w?=
 =?utf-8?B?MEtsS3grSUJuam5ldGNoMjc3V2Z2b1kzZ0taTzNJZFBFWWtjRGtSRHBTZHNx?=
 =?utf-8?B?OXlQaUhRS1RhMS92ZEVKZFdxUXFGV3hBQmplajBJYlVvc0hsRzN2UGFDUE1N?=
 =?utf-8?B?Mm5EWUF6YmxLRW91SENwbDdUcVIyeTBVUEIxYTVBaVY0U0RLRkhlUi9rdmZt?=
 =?utf-8?B?NnJJMlJVeGk0elJJUXRhYTBINERXWGdQL2luaEl6cTduRnljdjVaTkJYOHUw?=
 =?utf-8?B?VU03d0taakw2dEIxLzAwcUZiUml4d3o1WU0zZmx4bW9vNDl1V1orcDE3NVc4?=
 =?utf-8?B?YXhQS25FdzVTNk5aTTJua040Zk9aTjRXVGhteDM4TG5oZ21ySXlHZlE2ekk2?=
 =?utf-8?B?QkN5Q0tORjZaNUxuR0JJeWgxNEpxS0NaTndwRWF6U3Rnc0c4b01yMWN3M0tp?=
 =?utf-8?B?anVRaEJlTHdSUTNhU2k0V2Zibm1hdSsvNDNuY1BLeVM4bW9QSG00WTdCYmdj?=
 =?utf-8?B?YlQzQkVLcFo3Z1ZnVE5LWTlBTVU4WllITldSbEh4MCtnbzBaZWJiSlFQV2xS?=
 =?utf-8?B?RXBQWG1WWFQ0U0RRKzFzSkVrYTc0VVNnQmtuKzJjTmFPRDQ2dVNOR1N1RVhl?=
 =?utf-8?B?dHBNUTFMak1KNHJwWUlkWmI5NFY3UkZDRjM3SEprWTc4bGRYZGQwMFZhNEhQ?=
 =?utf-8?B?ZTNXMzY4SmdSK0JONkdmMnBobC9odzFxUjZwZHd0ZXRXOFcwQW5kNllEbFI1?=
 =?utf-8?B?Rm0vMnhycDd5aloySUNtOGJsMUZZL2U5NXJydzMwdW1sVDR2blVrQ0pHSFFi?=
 =?utf-8?B?TmgvUWZ4aGFHN3hpUFRLSDVSWEVkUDJLL1pEV2k4R1B5Q0lQQVNJR0lTdzVx?=
 =?utf-8?B?N2FPeGdPTXVtWmdEV2dQTXJTMGNCK2N2M2xXam5KVzNBYUEvNFlhSGx5S3Rz?=
 =?utf-8?B?OW1qdThjU1VoSVBIL3lmSzB5OGEvRm9wb2JWWnlrVHd0elF2NmlxdEFPR0VW?=
 =?utf-8?B?ZXk1TEVpcVlXbDgzeDRVSHlLNk5kZGJGbjRMcDIxN3RUYWl4ektXSEVXTXpl?=
 =?utf-8?B?MEJZTFRJOGhsR0FmRUt1bnE0QmpRSnl6blJsQ2hqRXBmWWd1cnJwaHBaSktB?=
 =?utf-8?B?T0lZcVdiUTB4cnFreWdRYXRYTzByN2hxZzhNeE5hRG9hb2c4Q0hRWGpZMWQ1?=
 =?utf-8?B?MGNSRlBZSTQvR0NJdnlYdGR3ZFgrQ2VLNlgrOGxGSVRTeVNJNW5tV2UvKzNS?=
 =?utf-8?B?S05OVTNVUDY4MHpUQmlvVXJ1SHJVdlJUb09tNU5iWkREN25YR2dqMzBuREFy?=
 =?utf-8?B?Sk9KL1lnakVtdTJVSk83NWZpbzYzK2hZZHVQUFNCQkdqN01CTHdxVWU3VVp5?=
 =?utf-8?B?akJ1enpDSW9xNXl2a3l0bTVKYURLRWhZU29vSmZMQU42ODEvQUN3UjZjUU9Y?=
 =?utf-8?B?dk9UTXZJbVNzUXdhbnZIdFFzQlh6UE1IcjVyNWNQc0VOMGRBUDMvb0FsbHRQ?=
 =?utf-8?B?VFQrdWNES2dpNUllU3M4RElnVG5MVHE5QkFtWXZuZnNQbjFBSXZaM1BXSUJF?=
 =?utf-8?B?NHo2My91c0lhTXpKWUNyTy9ESTdaSDBZbDlnTXBYdDRXa244NWJWSDBUR3RR?=
 =?utf-8?B?Y2Z0aWVEcmZjaW8zamM4Umo1ZXJONmdyRlBJaklEVEs2WEZ5aW1zNWVTZkVn?=
 =?utf-8?B?RVlEc0k4S3JnWGZGZlIwbFlUdEhKWWlISGxzc3dhV1QwUGJsUUxoelBXdDA0?=
 =?utf-8?B?QjNCTmNUR1YyNWx0ZE5VVmxlbUpXdE9iQ1p5M2QzbGczVnQyaWVFZGl1bDlQ?=
 =?utf-8?B?bnJwaStjWlRHK2JMRW1CcXJ1UUpOejN4OFJsckZFK3F1UG9rRG55aEUwRENj?=
 =?utf-8?Q?WoU141B3IFaXA+w/Z1ONu0aUh?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fd4b6807-4cca-4d46-089c-08da8be831d0
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3589.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 07:04:21.6518
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: CX2Mov5TsFEO9Y8CQ4QJiT+iGJUdiUOOg+WUsDKNeD+3ITFaC/flbrRCer9EJVK2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4299
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
> Prepare gntdev driver to the common dynamic dma-buf locking convention
> by starting to use the unlocked versions of dma-buf API functions.
>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/xen/gntdev-dmabuf.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/xen/gntdev-dmabuf.c b/drivers/xen/gntdev-dmabuf.c
> index 940e5e9e8a54..4440e626b797 100644
> --- a/drivers/xen/gntdev-dmabuf.c
> +++ b/drivers/xen/gntdev-dmabuf.c
> @@ -600,7 +600,7 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, struct device *dev,
>   
>   	gntdev_dmabuf->u.imp.attach = attach;
>   
> -	sgt = dma_buf_map_attachment(attach, DMA_BIDIRECTIONAL);
> +	sgt = dma_buf_map_attachment_unlocked(attach, DMA_BIDIRECTIONAL);
>   	if (IS_ERR(sgt)) {
>   		ret = ERR_CAST(sgt);
>   		goto fail_detach;
> @@ -658,7 +658,7 @@ dmabuf_imp_to_refs(struct gntdev_dmabuf_priv *priv, struct device *dev,
>   fail_end_access:
>   	dmabuf_imp_end_foreign_access(gntdev_dmabuf->u.imp.refs, count);
>   fail_unmap:
> -	dma_buf_unmap_attachment(attach, sgt, DMA_BIDIRECTIONAL);
> +	dma_buf_unmap_attachment_unlocked(attach, sgt, DMA_BIDIRECTIONAL);
>   fail_detach:
>   	dma_buf_detach(dma_buf, attach);
>   fail_free_obj:
> @@ -708,8 +708,8 @@ static int dmabuf_imp_release(struct gntdev_dmabuf_priv *priv, u32 fd)
>   	attach = gntdev_dmabuf->u.imp.attach;
>   
>   	if (gntdev_dmabuf->u.imp.sgt)
> -		dma_buf_unmap_attachment(attach, gntdev_dmabuf->u.imp.sgt,
> -					 DMA_BIDIRECTIONAL);
> +		dma_buf_unmap_attachment_unlocked(attach, gntdev_dmabuf->u.imp.sgt,
> +						  DMA_BIDIRECTIONAL);
>   	dma_buf = attach->dmabuf;
>   	dma_buf_detach(attach->dmabuf, attach);
>   	dma_buf_put(dma_buf);