Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <624cdfa4-2953-00b8-5890-e40bc1434f2d@amd.com>
Date:   Thu, 1 Sep 2022 09:05:27 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH v4 14/21] media: tegra-vde: Prepare to dynamic dma-buf
 locking specification
Content-Language: en-US
To:     Dmitry Osipenko <dmitry.osipenko@collabora.com>,
        David Airlie <airlied@linux.ie>,
        Gerd Hoffmann <kraxel@redhat.com>,
        Gurchetan Singh <gurchetansingh@chromium.org>,
        Chia-I Wu <olvaffe@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
        Daniel Almeida <daniel.almeida@collabora.com>,
        Gert Wollny <gert.wollny@collabora.com>,
        Gustavo Padovan <gustavo.padovan@collabora.com>,
        Daniel Stone <daniel@fooishbar.org>,
        Tomeu Vizoso <tomeu.vizoso@collabora.com>,
        Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <mripard@kernel.org>,
        Thomas Zimmermann <tzimmermann@suse.de>,
        Rob Clark <robdclark@gmail.com>,
        Sumit Semwal <sumit.semwal@linaro.org>,
        "Pan, Xinhui" <Xinhui.Pan@amd.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Tomasz Figa <tfiga@chromium.org>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
        =?UTF-8?Q?Thomas_Hellstr=c3=b6m?= <thomas_os@shipmail.org>,
        Qiang Yu <yuq825@gmail.com>,
        Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
        Amol Maheshwari <amahesh@qti.qualcomm.com>,
        Jason Gunthorpe <jgg@ziepe.ca>,
        Leon Romanovsky <leon@kernel.org>,
        Juergen Gross <jgross@suse.com>,
        Stefano Stabellini <sstabellini@kernel.org>,
        Oleksandr Tyshchenko <oleksandr_tyshchenko@epam.com>,
        Tomi Valkeinen <tomba@kernel.org>,
        Russell King <linux@armlinux.org.uk>,
        Lucas Stach <l.stach@pengutronix.de>,
        Christian Gmeiner <christian.gmeiner@gmail.com>
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Dmitry Osipenko <digetx@gmail.com>,
        linux-media@vger.kernel.org, linaro-mm-sig@lists.linaro.org,
        amd-gfx@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
        kernel@collabora.com, virtualization@lists.linux-foundation.org,
        linux-rdma@vger.kernel.org, linux-arm-msm@vger.kernel.org
References: <20220831153757.97381-1-dmitry.osipenko@collabora.com>
 <20220831153757.97381-15-dmitry.osipenko@collabora.com>
From:   =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
In-Reply-To: <20220831153757.97381-15-dmitry.osipenko@collabora.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZDBJMDFCUjhhQ3VXc1Y3cVQ3VWhjM0lwWEtIS3Zwb3p6eGIwL3kyaklNZmRT?=
 =?utf-8?B?dzhEL2VDWjZHeXJWeXcyUXlPaVM3ZXBLdkJqUEJ2SzR3enpHVzcrK1FkdjVS?=
 =?utf-8?B?RFVMLzVFRnVrUS9CWis5V1QvVWcybnRkQVRUU2xFQnpVKzVsT0FKRlZSWVFK?=
 =?utf-8?B?RVBIM1RVY213eW05TXNnNTVWQkFCTkdiWXZKbDZrWkpONjRuWXJkcDhGQmVR?=
 =?utf-8?B?U0VUZUQ0bDNXTVMvbkdjdXk2RTRpL2hMOEljVUJRTy91clB3MkFYODVOaHo1?=
 =?utf-8?B?T1EyMkpiZzMrOUcvUFB3OUZUTnc0RXhWN0pqNG1lVm5meUJOR2JuSHdBdy8z?=
 =?utf-8?B?Q2s0N0ZDTHR5Z2VzcVZqK2VxVVUzUURVdTY0SG1GWEFObm5vWUU0Um0xbXFy?=
 =?utf-8?B?R2ZqVWNIeDlldElJMlZ5L3VObFY3Q0VicnN6dC80OHl2TTk5NDZoL0dIajFs?=
 =?utf-8?B?ZksyUStCZXNDZ29zSVJac2dLcEhoVlJzSHVHdVoxeHN3dmJmUXNib2d3RHE3?=
 =?utf-8?B?eml6Y0E1SDN3VnRKV2RvNzB1ZTlIS1B6RDlPYXMvbFc4QkN5dGhpaHVkY0xn?=
 =?utf-8?B?T1pDbE16MTcyOEFGNjVGc2x6V00rSnRYbGxhYzF5ZXJQUXhzMmtnbm5vcHJk?=
 =?utf-8?B?SElRTFhGOENhaVRGVGY0TlprK1dyeWRNNEhJY21hWUd6ME1ISlRTLzJFVE5i?=
 =?utf-8?B?a2V1aVM4RFZEaE52U1lRYml0K0p1MjZPZmdlQWRVdkRyUkpLRFp5SFd1S3Vm?=
 =?utf-8?B?YlUwR2trcTVTZGNsVW1Wenp2TE5CUzdDTkducHN6VkhwT1EzbkIzTk8rZXpC?=
 =?utf-8?B?cC81SEN3YmNkNlQ0KzVnZEZaMGYxSGc0L3Y1UnlJYW1teTlYV0daaXU4NG5x?=
 =?utf-8?B?SUFJZWk4TEMxb2ordXYwMnRpeFNGVnhrTnhsYnZBYkdWS0QzTVFTK1JRcjZC?=
 =?utf-8?B?L0xKV3ZsbzlXVHYwUEkrbndHcHFNYVpLTmZPc3NZanEwclIxWWxkQlo1eXM5?=
 =?utf-8?B?UWppOERxYnl6NnFCYXRTWm5QZTB4bkNNZU5uK3R6dDhiUEhzenpFT04xSU5J?=
 =?utf-8?B?aVQ0SmIvcGphTVk0K3J4NUFvZmlmSHU4WHhkR0VYMXZGVHhxa2FLV0d5OG5Y?=
 =?utf-8?B?Qm9FUFZ3SFI0TnpzRGtSOEVoSC9sN281aWx1UmJ1YVFiYjBpSUNyYjJzMXBE?=
 =?utf-8?B?N2E0SzBUS3dJVG1waHNWditvcEVHQml6YVlmR3hQbzN5N1Fycnc1NGFZTG9v?=
 =?utf-8?B?QlFwZGhqVkxIaThJcEVQRk5mdGJlbDdqMi8xK2FiWlNEWDM4SHFLUVZGVFVk?=
 =?utf-8?B?M01aWkUzQWo3eXlub0tnbG15aXg1WGJmUktVRVVtOWcvRDlma1kvM05HTlpy?=
 =?utf-8?B?STRndmgyNDhoMGoyaUJPc3I2YlQxTUJ6Qkp1WHZPYXRlT2NFTnVvZURncGsw?=
 =?utf-8?B?QlpsM3VoUlptODRPSXVFSDl5ZE5JaXRpZVpWUjdHdVJxTHBjRm93bFZoSkwr?=
 =?utf-8?B?Ylh0Z3RkUW05YkpFSDlFT0xKNy8xZFVSMHYvdHpPbXkwS1N4QWtIelFpeDVX?=
 =?utf-8?B?Wk1QZHFjVStHKzRhcjN3VHFOdXpvMWRrYTBIVHFFcElQbmFNR2xxWTcxclpV?=
 =?utf-8?B?c0tYWWNhTTJud2xEUzB4L3BqNXo1SStPaUdWRkRvL2NiOTNqdzcrdnhXcWFo?=
 =?utf-8?B?N2Z6akRTKzRBaExOS1Vud1dGK01pZDlmS2NQTlRhazg2dlljL2JoZi93Nmpk?=
 =?utf-8?B?SDQrUFFuaVp5VmZpRUN1ZkJPbFJtdHU5OXR2bHdlSm5IT09LanloM0FNbkMy?=
 =?utf-8?B?QU1BdFlTelRJVnIrclNNMXFsYnVQUmE2V0x2alJKOEUraVNuKzJISVE3TXBB?=
 =?utf-8?B?T014KzJNa0JhVkxKeHA5Q2d6TVV2YXhab3JDby9ZOUdudXpDKzduODU5TXdM?=
 =?utf-8?B?TzZ3aUdXRDg4VUYwVWJWNVJPcFdFY0lib0tKbWVYSzhEVkV0VTBhcDlNTjdJ?=
 =?utf-8?B?WXJDaXdHMERUOExrVk9naDd1SWY0Q0ZTNUtVS1RuUHVieXdiK28zTjN1Q3RH?=
 =?utf-8?B?amJackdaajhMU20xQ3hiSERMeXVucXVzY2pVREUzdmNZMUk4cllYMGdGVnMw?=
 =?utf-8?Q?fuRoD8uVV68XVC04lWIvID+pM?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c228fbff-d746-4c28-f09c-08da8be862c4
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB3589.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2022 07:05:43.7093
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Y5xJLBjck23PA3lcjtOyiCBXc47FcTNjk7EmTrwrdphvYlgfGOZvzcVEt98AWE7G
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4299
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 31.08.22 um 17:37 schrieb Dmitry Osipenko:
> Prepare Tegra video decoder driver to the common dynamic dma-buf
> locking convention by starting to use the unlocked versions of dma-buf
> API functions.
>
> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/media/platform/nvidia/tegra-vde/dmabuf-cache.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/nvidia/tegra-vde/dmabuf-cache.c b/drivers/media/platform/nvidia/tegra-vde/dmabuf-cache.c
> index 69c346148070..1c5b94989aec 100644
> --- a/drivers/media/platform/nvidia/tegra-vde/dmabuf-cache.c
> +++ b/drivers/media/platform/nvidia/tegra-vde/dmabuf-cache.c
> @@ -38,7 +38,7 @@ static void tegra_vde_release_entry(struct tegra_vde_cache_entry *entry)
>   	if (entry->vde->domain)
>   		tegra_vde_iommu_unmap(entry->vde, entry->iova);
>   
> -	dma_buf_unmap_attachment(entry->a, entry->sgt, entry->dma_dir);
> +	dma_buf_unmap_attachment_unlocked(entry->a, entry->sgt, entry->dma_dir);
>   	dma_buf_detach(dmabuf, entry->a);
>   	dma_buf_put(dmabuf);
>   
> @@ -102,7 +102,7 @@ int tegra_vde_dmabuf_cache_map(struct tegra_vde *vde,
>   		goto err_unlock;
>   	}
>   
> -	sgt = dma_buf_map_attachment(attachment, dma_dir);
> +	sgt = dma_buf_map_attachment_unlocked(attachment, dma_dir);
>   	if (IS_ERR(sgt)) {
>   		dev_err(dev, "Failed to get dmabufs sg_table\n");
>   		err = PTR_ERR(sgt);
> @@ -152,7 +152,7 @@ int tegra_vde_dmabuf_cache_map(struct tegra_vde *vde,
>   err_free:
>   	kfree(entry);
>   err_unmap:
> -	dma_buf_unmap_attachment(attachment, sgt, dma_dir);
> +	dma_buf_unmap_attachment_unlocked(attachment, sgt, dma_dir);
>   err_detach:
>   	dma_buf_detach(dmabuf, attachment);
>   err_unlock: